From jcid at dillo.org  Mon Jun  1 00:08:23 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun  1 00:08:33 2009
Subject: [Dillo-dev] view source dpi question
In-Reply-To: <20090531195527.GG20769@local.gobigwest.com>
References: <20090531193951.GA2632@blob.baaderstrasse.com>
	<20090531195527.GG20769@local.gobigwest.com>
Message-ID: <20090531220823.GH3646@dillo.org>

On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote:
> > annoyed by the slow source view widget I'd like to play with
> > a source viewer dpi (Jorge, I think you suggested to use a
> > dpi instead of coding it in dillo directly).
> > However I want to avoid to reload the page from the dpi, as I want
> > to be able to view the source exactly as it is currently displayed.
> > 
> > How should I pass the html document from dillo to the dpi? Any
> > ideas?
> 
> Can you borrow the start_send_page stuff used to send local files to dillo?

  That's the idea.

  You  have  to pass the source to the dpi to create a table with
the line number. That way you have the handy line number and find
text functionality.

  Something like:

  <table>
   <tr><td>1
       <td> LINE_CONTENT_HERE
   <tr><td>2
       <td> LINE_CONTENT_HERE
       ...
  </table>

-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Mon Jun  1 00:17:23 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Mon Jun  1 00:18:31 2009
Subject: [Dillo-dev] view source dpi question
In-Reply-To: <20090531220823.GH3646@dillo.org>
References: <20090531193951.GA2632@blob.baaderstrasse.com>
	<20090531195527.GG20769@local.gobigwest.com>
	<20090531220823.GH3646@dillo.org>
Message-ID: <20090531221723.GA60638@blob.baaderstrasse.com>

On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote:
> On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote:
> > > annoyed by the slow source view widget I'd like to play with
> > > a source viewer dpi (Jorge, I think you suggested to use a
> > > dpi instead of coding it in dillo directly).
> > > However I want to avoid to reload the page from the dpi, as I want
> > > to be able to view the source exactly as it is currently displayed.
> > > 
> > > How should I pass the html document from dillo to the dpi? Any
> > > ideas?
> > 
> > Can you borrow the start_send_page stuff used to send local files to dillo?
> 
>   That's the idea.
> 
>   You  have  to pass the source to the dpi to create a table with
> the line number. That way you have the handy line number and find
> text functionality.
> 
>   Something like:
> 
>   <table>
>    <tr><td>1
>        <td> LINE_CONTENT_HERE
>    <tr><td>2
>        <td> LINE_CONTENT_HERE
>        ...
>   </table>

Yes, that will be the fun part :) I also think about an option to
pass the html to tidy to make it more readable.
However first I need to get the html from dillo to the dpi. Is
the start_send_page already working in that direction or is a new
equivalent method needed?

Cheers,
Johannes

From jcid at dillo.org  Mon Jun  1 03:26:57 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun  1 03:27:08 2009
Subject: [Dillo-dev] view source dpi question
In-Reply-To: <20090531221723.GA60638@blob.baaderstrasse.com>
References: <20090531193951.GA2632@blob.baaderstrasse.com>
	<20090531195527.GG20769@local.gobigwest.com>
	<20090531220823.GH3646@dillo.org>
	<20090531221723.GA60638@blob.baaderstrasse.com>
Message-ID: <20090601012657.GI3646@dillo.org>

On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote:
> On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote:
> > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote:
> > > > annoyed by the slow source view widget I'd like to play with
> > > > a source viewer dpi (Jorge, I think you suggested to use a
> > > > dpi instead of coding it in dillo directly).
> > > > However I want to avoid to reload the page from the dpi, as I want
> > > > to be able to view the source exactly as it is currently displayed.
> > > > 
> > > > How should I pass the html document from dillo to the dpi? Any
> > > > ideas?
> > > 
> > > Can you borrow the start_send_page stuff used to send local files to dillo?
> > 
> >   That's the idea.
> > 
> >   You  have  to pass the source to the dpi to create a table with
> > the line number. That way you have the handy line number and find
> > text functionality.
> > 
> >   Something like:
> > 
> >   <table>
> >    <tr><td>1
> >        <td> LINE_CONTENT_HERE
> >    <tr><td>2
> >        <td> LINE_CONTENT_HERE
> >        ...
> >   </table>
> 
> Yes, that will be the fun part :) I also think about an option to
> pass the html to tidy to make it more readable.
> However first I need to get the html from dillo to the dpi. Is
> the start_send_page already working in that direction or is a new
> equivalent method needed?

  From  the  top  of my head (because I haven't worked there in a
long  time):  start_send_page is the canonical way to send a page
to dillo from a dpi. The missing part may be how to send the page
to  the dpi first. I remember making a short and funny dialog for
adding  bookmarks  to  illustrate how bidirectional data exchange
could be done; it's still in the code!
  (take a look in a_Bookmarks_chat_add())

  If it gets unclear, please let me know to allocate some time to
help on it.

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Mon Jun  1 03:37:29 2009
From: corvid at lavabit.com (corvid)
Date: Mon Jun  1 03:40:28 2009
Subject: patch: Re: [Dillo-dev] https through a proxy
In-Reply-To: <20090531191204.GB2296@blob.baaderstrasse.com>
References: <20090525152146.GB6001@local.gobigwest.com>
	<20090526043657.GD6001@local.gobigwest.com>
	<20090527001726.GF6001@local.gobigwest.com>
	<20090531191204.GB2296@blob.baaderstrasse.com>
Message-ID: <20090601013729.GK20769@local.gobigwest.com>

Jorge wrote:
> Please commit the necessary parts.

Done.

All: To borrow Jorge's usual line, "Please test."



From Johannes.Hofmann at gmx.de  Tue Jun  2 21:43:57 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Tue Jun  2 21:45:09 2009
Subject: [Dillo-dev] view source dpi question
In-Reply-To: <20090601012657.GI3646@dillo.org>
References: <20090531193951.GA2632@blob.baaderstrasse.com>
	<20090531195527.GG20769@local.gobigwest.com>
	<20090531220823.GH3646@dillo.org>
	<20090531221723.GA60638@blob.baaderstrasse.com>
	<20090601012657.GI3646@dillo.org>
Message-ID: <20090602194357.GA31905@blob.baaderstrasse.com>

On Sun, May 31, 2009 at 09:26:57PM -0400, Jorge Arellano Cid wrote:
> On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote:
> > On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote:
> > > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote:
> > > > > annoyed by the slow source view widget I'd like to play with
> > > > > a source viewer dpi (Jorge, I think you suggested to use a
> > > > > dpi instead of coding it in dillo directly).
> > > > > However I want to avoid to reload the page from the dpi, as I want
> > > > > to be able to view the source exactly as it is currently displayed.
> > > > > 
> > > > > How should I pass the html document from dillo to the dpi? Any
> > > > > ideas?
> > > > 
> > > > Can you borrow the start_send_page stuff used to send local files to dillo?
> > > 
> > >   That's the idea.
> > > 
> > >   You  have  to pass the source to the dpi to create a table with
> > > the line number. That way you have the handy line number and find
> > > text functionality.
> > > 
> > >   Something like:
> > > 
> > >   <table>
> > >    <tr><td>1
> > >        <td> LINE_CONTENT_HERE
> > >    <tr><td>2
> > >        <td> LINE_CONTENT_HERE
> > >        ...
> > >   </table>
> > 
> > Yes, that will be the fun part :) I also think about an option to
> > pass the html to tidy to make it more readable.
> > However first I need to get the html from dillo to the dpi. Is
> > the start_send_page already working in that direction or is a new
> > equivalent method needed?
> 
>   From  the  top  of my head (because I haven't worked there in a
> long  time):  start_send_page is the canonical way to send a page
> to dillo from a dpi. The missing part may be how to send the page
> to  the dpi first. I remember making a short and funny dialog for
> adding  bookmarks  to  illustrate how bidirectional data exchange
> could be done; it's still in the code!
>   (take a look in a_Bookmarks_chat_add())
> 
>   If it gets unclear, please let me know to allocate some time to
> help on it.

Here are two questions already :)

* the DPIs seem to send
  <cmd='start_send_page' url='dpi:/hello/' '>
  before sending the actual html page.
  Note the quote in front of '>'.
  Is this intended? At least it doesn't seem to work when I remove
  it.

* What is the reason for the SockHandler stuff. Why are DPIs not
  just using plain printf and friends?

Cheers,
Johannes

From jcid at dillo.org  Tue Jun  2 22:24:30 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun  2 22:24:42 2009
Subject: [Dillo-dev] view source dpi question
In-Reply-To: <20090602194357.GA31905@blob.baaderstrasse.com>
References: <20090531193951.GA2632@blob.baaderstrasse.com>
	<20090531195527.GG20769@local.gobigwest.com>
	<20090531220823.GH3646@dillo.org>
	<20090531221723.GA60638@blob.baaderstrasse.com>
	<20090601012657.GI3646@dillo.org>
	<20090602194357.GA31905@blob.baaderstrasse.com>
Message-ID: <20090602202430.GA9791@dillo.org>

On Tue, Jun 02, 2009 at 09:43:57PM +0200, Johannes Hofmann wrote:
> On Sun, May 31, 2009 at 09:26:57PM -0400, Jorge Arellano Cid wrote:
> > On Mon, Jun 01, 2009 at 12:17:23AM +0200, Johannes Hofmann wrote:
> > > On Sun, May 31, 2009 at 06:08:23PM -0400, Jorge Arellano Cid wrote:
> > > > On Sun, May 31, 2009 at 07:55:27PM +0000, corvid wrote:
> > > > > > annoyed by the slow source view widget I'd like to play with
> > > > > > a source viewer dpi (Jorge, I think you suggested to use a
> > > > > > dpi instead of coding it in dillo directly).
> > > > > > However I want to avoid to reload the page from the dpi, as I want
> > > > > > to be able to view the source exactly as it is currently displayed.
> > > > > > 
> > > > > > How should I pass the html document from dillo to the dpi? Any
> > > > > > ideas?
> > > > > 
> > > > > Can you borrow the start_send_page stuff used to send local files to dillo?
> > > > 
> > > >   That's the idea.
> > > > 
> > > >   You  have  to pass the source to the dpi to create a table with
> > > > the line number. That way you have the handy line number and find
> > > > text functionality.
> > > > 
> > > >   Something like:
> > > > 
> > > >   <table>
> > > >    <tr><td>1
> > > >        <td> LINE_CONTENT_HERE
> > > >    <tr><td>2
> > > >        <td> LINE_CONTENT_HERE
> > > >        ...
> > > >   </table>
> > > 
> > > Yes, that will be the fun part :) I also think about an option to
> > > pass the html to tidy to make it more readable.
> > > However first I need to get the html from dillo to the dpi. Is
> > > the start_send_page already working in that direction or is a new
> > > equivalent method needed?
> > 
> >   From  the  top  of my head (because I haven't worked there in a
> > long  time):  start_send_page is the canonical way to send a page
> > to dillo from a dpi. The missing part may be how to send the page
> > to  the dpi first. I remember making a short and funny dialog for
> > adding  bookmarks  to  illustrate how bidirectional data exchange
> > could be done; it's still in the code!
> >   (take a look in a_Bookmarks_chat_add())
> > 
> >   If it gets unclear, please let me know to allocate some time to
> > help on it.
> 
> Here are two questions already :)
> 
> * the DPIs seem to send
>   <cmd='start_send_page' url='dpi:/hello/' '>
>   before sending the actual html page.
>   Note the quote in front of '>'.
>   Is this intended? At least it doesn't seem to work when I remove
>   it.

   Absolutely!

   You can find a detailed explanation in dpip/dpip.c


> * What is the reason for the SockHandler stuff. Why are DPIs not
>   just using plain printf and friends?

  There  were some problems. e.g. The stream functions block when
reading.
  Dpis  also  can  be  filters  (stdin/stdout) or servers using a
single  socket  (stdin/stdin)  for  read  and write, and the sock
handler unifies this with common code and a single interface.
  Dpis  handle  different  tasks  and transfer sizes so buffering
becomes  important, and all that is unified in a single layer (as
now)  instead  of a myriad of approaches that break sometimes for
no  clear  reason  (as  before.  e.g. different default buffering
across OS).

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Wed Jun  3 03:37:34 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun  3 03:40:26 2009
Subject: [Dillo-dev] patch: smaller findbar buttons for narrow screen
Message-ID: <20090603013734.GA28743@local.gobigwest.com>

I resized my window to make it narrower and discovered that
the findbar buttons eat all of the space and make the
input widget disappear.

With button width reduced to 40 with a narrow window,
if I resize down to match that ipaq screenshot that Andreas made,
I can still see a reasonable amount of input field.

-------------- next part --------------
diff -r c886e4d974f1 src/findbar.cc
--- a/src/findbar.cc	Mon Jun 01 03:57:15 2009 +0000
+++ b/src/findbar.cc	Wed Jun 03 01:19:14 2009 +0000
@@ -108,10 +108,12 @@ Findbar::Findbar(int width, int height) 
 Findbar::Findbar(int width, int height) :
    Group(0, 0, width, height)
 {
-   int button_width = 70;
+   bool cramped = width < 500;
    int gap = 2;
    int border = 2;
+   int button_width = cramped ? 40 : 70;
    int input_width = width - (2 * border + 4 * (button_width + gap));
+   const char *label;
    int x = border;
    height -= 2 * border;
 
@@ -136,7 +138,8 @@ Findbar::Findbar(int width, int height) 
     i->clear_tab_to_focus();
     i->set_click_to_focus();
 
-    next_btn = new HighlightButton(x, border, button_width, height, "Next");
+    label = "Next";
+    next_btn = new HighlightButton(x, border, button_width, height, label);
     x += button_width + gap;
     next_btn->tooltip("Find next occurrence of the search phrase\n"
                       "shortcut: Enter");
@@ -145,7 +148,8 @@ Findbar::Findbar(int width, int height) 
     next_btn->callback(search_cb, this);
     next_btn->clear_tab_to_focus();
 
-    prev_btn= new HighlightButton(x, border, button_width, height, "Previous");
+    label = cramped ? "Prev" : "Previous";
+    prev_btn= new HighlightButton(x, border, button_width, height, label);
     prev_btn->tooltip("Find previous occurrence of the search phrase\n"
                       "shortcut: Shift+Enter");
     prev_btn->add_shortcut(SHIFT+ReturnKey);
@@ -153,8 +157,8 @@ Findbar::Findbar(int width, int height) 
     prev_btn->clear_tab_to_focus();
     x += button_width + gap;
 
-    check_btn = new CheckButton(x, border, 2*button_width, height,
-                              "Case-sensitive");
+    label = cramped ? "Case" : "Case-sensitive";
+    check_btn = new CheckButton(x, border, 2*button_width, height, label);
     check_btn->clear_tab_to_focus();
     x += 2 * button_width + gap;
 
From corvid at lavabit.com  Wed Jun  3 16:22:53 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun  3 16:25:43 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
Message-ID: <20090603142253.GD28743@local.gobigwest.com>

Back in November, furaisanjin wrote:
> 2008/11/12 corvid <corvid@lavabit.com>:
> > dillo people: It turns out that dillo handles Chinese quite badly because the
> > text doesn't contain whitespace (BUG 827). It looks like Japanese is that
> > way as well.
> 
> Yes, dillo doesn't handle Japanese either when a line is long and
> doesn't have break on it.
> 
> I modified html_process_word so that each Japanese word is added by
> addText. In this way appearance is better but sometimes table looks
> bad.

I made a new version that goes in html_process_word
(handles numeric character references).

-------------- next part --------------
diff -r 3153db5d894a src/html.cc
--- a/src/html.cc	Mon Jun 01 05:15:10 2009 +0000
+++ b/src/html.cc	Wed Jun 03 06:02:02 2009 +0000
@@ -802,6 +802,39 @@ void a_Html_stash_init(DilloHtml *html)
    html->StashSpace = false;
    dStr_truncate(html->Stash, 0);
 }
+
+/*
+ * Does s point to a UTF-8-encoded ideographic character?
+ * This is based on http://unicode.org/reports/tr14/#ID plus some guesses
+ * as to what might make the most sense for Dillo. Surprisingly, they include
+ * Hangul Compatibility Jamo, but they're the experts, so I'll follow along.
+ *
+ * If something like this were to go into dillo "for real" someday,
+ * utf8.cc would be a better place, being a Unicode matter.
+ * If Dillo ever got really sophisticated line breaking (which might
+ * not be compatible with its goals), all of that might fit best in
+ * Textblock in Dw.
+ */
+static bool Html_ideographic(const char *s, const char *end, int *len)
+{
+   bool ret = false;
+
+   if (*s&0xe2 == 0xe2) {
+      /* Unicode char >= U+2000. This test assumes text is within the Basic
+       * Multilingual Plane (character < 4 bytes)
+       */
+
+      unsigned unicode = a_Utf8_decode(s, end, len);
+
+      if (unicode >= 0x2e80 &&
+           ((unicode <= 0xa4cf) ||
+            (unicode >= 0xf900 && unicode <= 0xfaff) ||
+            (unicode >= 0xff00 && unicode <= 0xff9f))) {
+         ret = true;
+      }
+   }
+   return ret;
+}   
 
 /* Entities list from the HTML 4.01 DTD */
 typedef struct {
@@ -1168,12 +1201,16 @@ static void Html_process_word(DilloHtml 
       dFree(Pword);
 
    } else {
+      char *Pword_end;
+
       if (!memchr(word,'&', size)) {
          /* No entities */
-         HT2TB(html)->addText(word, html->styleEngine->wordStyle ());
+         Pword = dStrndup(word, size);
+         Pword_end = Pword + size - 1;
       } else {
          /* Collapse white-space entities inside the word (except &nbsp;) */
          Pword = a_Html_parse_entities(html, word, size);
+         Pword_end = Pword + strlen(Pword) - 1;
          /* Collapse adjacent "\t\f\n\r" characters into a single space */
          for (i = j = 0; (Pword[i] = Pword[j]); ++i, ++j) {
             if (strchr("\t\f\n\r", Pword[i])) {
@@ -1183,9 +1220,33 @@ static void Html_process_word(DilloHtml 
                   for (--i; strchr("\t\f\n\r", Pword[j+1]); ++j) ;
             }
          }
-         HT2TB(html)->addText(Pword, html->styleEngine->wordStyle ());
-         dFree(Pword);
-      }
+      }
+      for (start = i = 0; Pword[i]; start = i) {
+         int len;
+
+         if (isspace(Pword[i])) {
+            while (Pword[++i] && isspace(Pword[i])) ;
+            Html_process_space(html, Pword + start, i - start);
+         } else if (Html_ideographic(Pword+i, Pword_end, &len)) {
+            i += len;
+            ch = Pword[i];
+            Pword[i] = '\0';
+            HT2TB(html)->addText(Pword + start,
+                                 html->styleEngine->wordStyle ());
+            Pword[i] = ch;
+            html->PrevWasSPC = false;
+         } else {
+            while (Pword[++i] && !isspace(Pword[i]) &&
+                   !Html_ideographic(Pword+i, Pword_end, &len)) ;
+            ch = Pword[i];
+            Pword[i] = 0;
+            HT2TB(html)->addText(Pword + start,
+                                 html->styleEngine->wordStyle ());
+            Pword[i] = ch;
+            html->PrevWasSPC = false;
+         }
+      }
+      dFree(Pword);
    }
 
    html->PrevWasSPC = false;
From paul at claws-mail.org  Thu Jun  4 07:22:34 2009
From: paul at claws-mail.org (Paul)
Date: Thu Jun  4 07:23:01 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
Message-ID: <20090604062234.6d42a06c@thewildbeast>

Hi,

I've got recent code from mercurial, June 1st.
No keyboard shortcuts are working for me using KDE 3.5.10.

I was speaking to Johannes Hofmann about this problem, he asked me
what my locale was (it's en-GB.UTF-8) and also asked me to report
the problem here.

Do you need more information from me?

Whilst I'm here I would like to say thanks to Johannes for sorting
out the --xid option, Claws Mail now has a dillo plugin again!

with regards

Paul

-- 
"Thanks to his green candle, the 'Pataphysician can
 lighten our darkness."

From Johannes.Hofmann at gmx.de  Thu Jun  4 10:46:07 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Thu Jun  4 10:47:22 2009
Subject: [Dillo-dev] patch: smaller findbar buttons for narrow screen
In-Reply-To: <20090603013734.GA28743@local.gobigwest.com>
References: <20090603013734.GA28743@local.gobigwest.com>
Message-ID: <20090604084607.GA957@blob.baaderstrasse.com>

On Wed, Jun 03, 2009 at 01:37:34AM +0000, corvid wrote:
> I resized my window to make it narrower and discovered that
> the findbar buttons eat all of the space and make the
> input widget disappear.
> 
> With button width reduced to 40 with a narrow window,
> if I resize down to match that ipaq screenshot that Andreas made,
> I can still see a reasonable amount of input field.

Nice. It doesn't work however when manually resizing the window.
What about using cramped mode unconditionally?

Cheers,
Johannes

From Johannes.Hofmann at gmx.de  Thu Jun  4 16:58:14 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Thu Jun  4 16:59:50 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604062234.6d42a06c@thewildbeast>
References: <20090604062234.6d42a06c@thewildbeast>
Message-ID: <20090604145813.GA889@blob.baaderstrasse.com>

On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote:
> Hi,
> 
> I've got recent code from mercurial, June 1st.
> No keyboard shortcuts are working for me using KDE 3.5.10.
> 
> I was speaking to Johannes Hofmann about this problem, he asked me
> what my locale was (it's en-GB.UTF-8) and also asked me to report
> the problem here.

Thanks for reporting.

> 
> Do you need more information from me?

Is anyone else seeing this? dillo shortcuts don't seem to work at
all for Paul. Shortcuts in test/editor from fltk2 seem to work
though.
I can't reproduce the problem so far.

Cheers,
Johannes

From jcid at dillo.org  Thu Jun  4 18:23:57 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun  4 18:24:04 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604145813.GA889@blob.baaderstrasse.com>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
Message-ID: <20090604162357.GB10725@dillo.org>

On Thu, Jun 04, 2009 at 04:58:14PM +0200, Johannes Hofmann wrote:
> On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote:
> > Hi,
> > 
> > I've got recent code from mercurial, June 1st.
> > No keyboard shortcuts are working for me using KDE 3.5.10.
> > 
> > I was speaking to Johannes Hofmann about this problem, he asked me
> > what my locale was (it's en-GB.UTF-8) and also asked me to report
> > the problem here.
> 
> Thanks for reporting.
> 
> > 
> > Do you need more information from me?
> 
> Is anyone else seeing this? dillo shortcuts don't seem to work at
> all for Paul. Shortcuts in test/editor from fltk2 seem to work
> though.
> I can't reproduce the problem so far.

  Paul, please let us know what binding are you trying to make,
what is failing and your keysrc.

-- 
  Cheers
  Jorge.-

From paul at claws-mail.org  Thu Jun  4 19:08:44 2009
From: paul at claws-mail.org (Paul)
Date: Thu Jun  4 19:09:12 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604162357.GB10725@dillo.org>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604162357.GB10725@dillo.org>
Message-ID: <20090604180844.23f2db63@thewildbeast>

Hi Jorge,

On Thu, 4 Jun 2009 12:23:57 -0400
Jorge Arellano Cid <jcid@dillo.org> wrote: 

>   Paul, please let us know what binding are you trying to make,
> what is failing and your keysrc.

I'm not actually trying to make any. I got on to this problem when
talking to Johannes on #claws - dillo1 had 'show controls' and
'reload' in the context menu, which was always very useful in Claws
Mail with the plugin, because it runs `dillo -f`, but anyway...

Even the default keybindings don't work for me. I don't have a keysrc
file, but I did create one, at Johannes suggestion, but this didn't
have any effect either. Pressing key-combos has no effect.  


best regards

Paul


-- 
"Thanks to his green candle, the 'Pataphysician can
 lighten our darkness."

From rogutes at googlemail.com  Thu Jun  4 19:29:43 2009
From: rogutes at googlemail.com (=?utf-8?Q?Rogut=C4=97s?= Sparnuotos)
Date: Thu Jun  4 19:28:42 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604145813.GA889@blob.baaderstrasse.com>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
Message-ID: <20090604172943.GA3610@urvas>

Johannes Hofmann (2009-06-04 16:58):
> On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote:
> > Hi,
> > 
> > I've got recent code from mercurial, June 1st.
> > No keyboard shortcuts are working for me using KDE 3.5.10.
> > 
> > I was speaking to Johannes Hofmann about this problem, he asked me
> > what my locale was (it's en-GB.UTF-8) and also asked me to report
> > the problem here.
> 
> Thanks for reporting.
> 
> > 
> > Do you need more information from me?
> 
> Is anyone else seeing this? dillo shortcuts don't seem to work at
> all for Paul. Shortcuts in test/editor from fltk2 seem to work
> though.
> I can't reproduce the problem so far.

Paul,

Does anything change when you save the keysrc file attached to this
e-mail to ~/.dillo/keysrc ? I think I had something similar, but
I didn't have time to report...and now I forgot what it was :/


P.S.
Actually, dillo doesn't even start for me anymore, saying 
  "Can't do 24-bit 0xff0000 0xff00 0xff visual"
Indeed, I am temporarily running a 24bpp desktop with an old graphics
card and I've put
  Option "Pixmap" "24"
in the ServerFlags section of xorg.conf.

Also, it is most probably unrelated and I'm only a casual dillo user,
but after basically every 15+ minute session, keyboard shortcuts start
misbehaving: i.e. they work as if the <Alt> modifier was pressed (for
example, typing 'a' in the location bar moves the cursor to the far
left, as with <Alt>a or Home). Only solution I've found was restarting
dillo (and this is where I missed something like session saving).
I haven't reported yet, because I have no idea how to reproduce it.


-- 
--  Rogut?s Sparnuotos
-------------- next part --------------
<Ctrl>o = open
<Ctrl>n = new-window

<Ctrl>t = new-tab
<Shift>Tab = left-tab
<Ctrl>Tab = right-tab
<Ctrl>q = close-tab

<Ctrl>f = find

<Ctrl>s = websearch
<Ctrl>b = bookmarks

<Ctrl>Space = fullscreen

<Ctrl>r = reload

#Esc = stop

<Alt>f = file-menu
<Alt>q = close-all

, = back
. = forward

Backspace = back
<Shift>Backspace = forward

<Ctrl>l = goto
<Ctrl>h = home
From paul at claws-mail.org  Thu Jun  4 19:36:28 2009
From: paul at claws-mail.org (Paul)
Date: Thu Jun  4 19:36:54 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604172943.GA3610@urvas>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
Message-ID: <20090604183628.4122ec94@thewildbeast>

Hi,

On Thu, 4 Jun 2009 20:29:43 +0300
Rogut?s Sparnuotos <rogutes@googlemail.com> wrote: 

> Does anything change when you save the keysrc file attached to this
> e-mail to ~/.dillo/keysrc ?

Unfortunately not.

best regards

Paul


-- 
"Thanks to his green candle, the 'Pataphysician can
 lighten our darkness."

From corvid at lavabit.com  Thu Jun  4 19:40:37 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun  4 19:43:27 2009
Subject: [Dillo-dev] patch: smaller findbar buttons for narrow screen
In-Reply-To: <20090603013734.GA28743@local.gobigwest.com>
References: <20090603013734.GA28743@local.gobigwest.com>
Message-ID: <20090604174037.GI28743@local.gobigwest.com>

Johannes wrote:
> On Wed, Jun 03, 2009 at 01:37:34AM +0000, corvid wrote:
> > I resized my window to make it narrower and discovered that
> > the findbar buttons eat all of the space and make the
> > input widget disappear.
> > 
> > With button width reduced to 40 with a narrow window,
> > if I resize down to match that ipaq screenshot that Andreas made,
> > I can still see a reasonable amount of input field.
>
> Nice. It doesn't work however when manually resizing the window.

Yeah.

> What about using cramped mode unconditionally?

I would like that.

PS I am constructing this mail manually from dillo-dev archive data because
 I didn't receive any dillo-dev mail after my Chinese patch and before the
 message Rogutes just sent. Maybe they'll show up eventually...



From corvid at lavabit.com  Thu Jun  4 19:59:14 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun  4 20:02:03 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604172943.GA3610@urvas>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
Message-ID: <20090604175914.GA1683@local.gobigwest.com>

Rogut?s wrote:
> Also, it is most probably unrelated and I'm only a casual dillo user,
> but after basically every 15+ minute session, keyboard shortcuts start
> misbehaving: i.e. they work as if the <Alt> modifier was pressed (for
> example, typing 'a' in the location bar moves the cursor to the far
> left, as with <Alt>a or Home). Only solution I've found was restarting
> dillo (and this is where I missed something like session saving).
> I haven't reported yet, because I have no idea how to reproduce it.

I saw the same thing for a little while, and it was completely
bewildering. I don't think it's happened for the last week or two, though.



From paul at claws-mail.org  Thu Jun  4 20:05:24 2009
From: paul at claws-mail.org (Paul)
Date: Thu Jun  4 20:05:51 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
Message-ID: <20090604190524.5db85513@thewildbeast>

Hi,

When opening dillo from the CLI I noticed the following message:

paths: Cannot open file '/home/user/.dillo/dillorc'
paths: Cannot open file '/etc/dillo/dillorc'
paths: Using internal defaults...

Checked my system and saw that dillorc had been installed
in /usr/etc/dillorc

Checking config.log showed sysconfdir='${prefix}/etc', so no
surprises there. But Paths::getPrefsFP() in src/paths.cc uses
PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
as specified in src/Makefile.am, instead. Now all is fine!

Seems the right thing to do.

with regards

Paul

-- 
"Thanks to his green candle, the 'Pataphysician can
 lighten our darkness."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_dillorc_path.patch
Type: text/x-patch
Size: 701 bytes
Desc: not available
Url : /pipermail/attachments/20090604/6cd9adf2/fix_dillorc_path.bin
From corvid at lavabit.com  Thu Jun  4 20:11:43 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun  4 20:14:31 2009
Subject: [Dillo-dev] form widgets, ascent/descent
Message-ID: <20090604181143.GA1688@local.gobigwest.com>

I was playing around in dw, and noticed that,
whereas form widgets normally like to put
much of their height into descent, when style
sets the height, Textblock::calcWidgetSize()
puts it all into ascent. 

I checked firefox and saw that their form widgets ascend.

If we made everything ascend and just put font->descent
into the descent, it would make life simpler.
Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I
could almost ignore that...



From corvid at lavabit.com  Thu Jun  4 20:26:40 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun  4 20:29:29 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090604190524.5db85513@thewildbeast>
References: <20090604190524.5db85513@thewildbeast>
Message-ID: <20090604182640.GB1688@local.gobigwest.com>

Paul wrote:
> When opening dillo from the CLI I noticed the following message:
> 
> paths: Cannot open file '/home/user/.dillo/dillorc'
> paths: Cannot open file '/etc/dillo/dillorc'
> paths: Using internal defaults...
> 
> Checked my system and saw that dillorc had been installed
> in /usr/etc/dillorc
> 
> Checking config.log showed sysconfdir='${prefix}/etc', so no
> surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> as specified in src/Makefile.am, instead. Now all is fine!

In addition, perhaps we should make sysconfdir have '/dillo' at the end.
If I look in an etc dir and see dillorc, I'd know what it's for,
but I wouldn't know what uses keysrc.



From corvid at lavabit.com  Fri Jun  5 03:50:58 2009
From: corvid at lavabit.com (corvid)
Date: Fri Jun  5 03:53:56 2009
Subject: [Dillo-dev] patch: NOP keybinding
Message-ID: <20090605015058.GA598@local.gobigwest.com>

I think it would be nice to have a NOP binding to
get rid of a default binding.

complicated patch:
-------------- next part --------------
diff -r fb041759363c src/keys.cc
--- a/src/keys.cc	Fri Jun 05 01:22:16 2009 +0000
+++ b/src/keys.cc	Fri Jun 05 01:43:47 2009 +0000
@@ -78,6 +78,7 @@ static const Mapping_t modifierNames[] =
 };
 
 static const KeyBinding_t default_keys[] = {
+   { "NOP"          , KEYS_NOP          , 0            , 0                  },
    { "open"         , KEYS_OPEN         , fltk::CTRL   , 'o'                },
    { "new-window"   , KEYS_NEW_WINDOW   , fltk::CTRL   , 'n'                },
    { "new-tab"      , KEYS_NEW_TAB      , fltk::CTRL   , 't'                },
From Johannes.Hofmann at gmx.de  Fri Jun  5 19:42:31 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Fri Jun  5 19:44:15 2009
Subject: [Dillo-dev] patch: NOP keybinding
In-Reply-To: <20090605015058.GA598@local.gobigwest.com>
References: <20090605015058.GA598@local.gobigwest.com>
Message-ID: <20090605174231.GA1335@blob.baaderstrasse.com>

On Fri, Jun 05, 2009 at 01:50:58AM +0000, corvid wrote:
> I think it would be nice to have a NOP binding to
> get rid of a default binding.
> 
> complicated patch:

+1

maybe lowercase the "NOP"?

Cheers,
Johannes


> diff -r fb041759363c src/keys.cc
> --- a/src/keys.cc	Fri Jun 05 01:22:16 2009 +0000
> +++ b/src/keys.cc	Fri Jun 05 01:43:47 2009 +0000
> @@ -78,6 +78,7 @@ static const Mapping_t modifierNames[] =
>  };
>  
>  static const KeyBinding_t default_keys[] = {
> +   { "NOP"          , KEYS_NOP          , 0            , 0                  },
>     { "open"         , KEYS_OPEN         , fltk::CTRL   , 'o'                },
>     { "new-window"   , KEYS_NEW_WINDOW   , fltk::CTRL   , 'n'                },
>     { "new-tab"      , KEYS_NEW_TAB      , fltk::CTRL   , 't'                },

> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

From furaisanjin at gmail.com  Sat Jun  6 05:37:57 2009
From: furaisanjin at gmail.com (furaisanjin)
Date: Sat Jun  6 05:38:51 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <20090603142253.GD28743@local.gobigwest.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
Message-ID: <144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>

Hi.

I just wonder why this condiction exists in the patch.

if (*s&0xe2 == 0xe2) {

There are characters which start from 0xe5 in Japanese.

Regards,
furaisanjin

From corvid at lavabit.com  Sat Jun  6 08:11:00 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun  6 08:14:01 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
	<144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
Message-ID: <20090606061100.GE598@local.gobigwest.com>

furaisanjin wrote:
> I just wonder why this condiction exists in the patch.
> 
> if (*s&0xe2 == 0xe2) {
> 
> There are characters which start from 0xe5 in Japanese.

Ah yes, that is an error. Thank you.

Any problems with "if (*s&0xe0 == 0xe0) {" instead?
I believe that would force everything above U+0800
through the decoding, but oh well.
(unicode blocks for the curious: http://unicode.org/Public/UNIDATA/Blocks.txt)

Oh, by the way, I noticed in the line breaking document that they also listed
20000..2A6D6CJK UNIFIED IDEOGRAPHS EXTENSION B
2F800..2FA1DCJK COMPATIBILITY IDEOGRAPHS SUPPLEMENT
but I wasn't sure whether anyone makes any real use of characters above U+FFFF.



From corvid at lavabit.com  Sat Jun  6 08:36:43 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun  6 08:39:45 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <20090606061100.GE598@local.gobigwest.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
	<144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
	<20090606061100.GE598@local.gobigwest.com>
Message-ID: <20090606063643.GF598@local.gobigwest.com>

I wrote:
> furaisanjin wrote:
> > I just wonder why this condiction exists in the patch.
> > 
> > if (*s&0xe2 == 0xe2) {
> > 
> > There are characters which start from 0xe5 in Japanese.
> 
> Ah yes, that is an error. Thank you.
> 
> Any problems with "if (*s&0xe0 == 0xe0) {" instead?
> I believe that would force everything above U+0800
> through the decoding, but oh well.

Wait, why don't I just use
if (*s >= 0xe2)

(My excuse now is that I'm tired and it's time for bed, but
I don't know what my excuse is for the other day :)

How UTF-8 works, if anyone cares:
0x000000-00007F is  0xxxxxxx
0x000080-0007FF is  110xxxxx 10xxxxxx
0x000800-00FFFF is  1110xxxx 10xxxxxx 10xxxxxx
0x010000-1FFFFF is  11110xxx 10xxxxxx 10xxxxxx 10xxxxxx

so (*s >= 0xe2) is at least
                    1110xxxx 10xxxxxx 10xxxxxx
                        0010   000000   000000 == U+2000



From jcid at dillo.org  Sat Jun  6 18:38:33 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun  6 18:38:47 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <20090606063643.GF598@local.gobigwest.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
	<144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
	<20090606061100.GE598@local.gobigwest.com>
	<20090606063643.GF598@local.gobigwest.com>
Message-ID: <20090606163833.GA8570@dillo.org>

On Sat, Jun 06, 2009 at 06:36:43AM +0000, corvid wrote:
> I wrote:
> > furaisanjin wrote:
> > > I just wonder why this condiction exists in the patch.
> > > 
> > > if (*s&0xe2 == 0xe2) {
> > > 
> > > There are characters which start from 0xe5 in Japanese.
> > 
> > Ah yes, that is an error. Thank you.
> > 
> > Any problems with "if (*s&0xe0 == 0xe0) {" instead?
> > I believe that would force everything above U+0800
> > through the decoding, but oh well.
> 
> Wait, why don't I just use
> if (*s >= 0xe2)
> 
> (My excuse now is that I'm tired and it's time for bed, but
> I don't know what my excuse is for the other day :)
> 
> How UTF-8 works, if anyone cares:
> 0x000000-00007F is  0xxxxxxx
> 0x000080-0007FF is  110xxxxx 10xxxxxx
> 0x000800-00FFFF is  1110xxxx 10xxxxxx 10xxxxxx
> 0x010000-1FFFFF is  11110xxx 10xxxxxx 10xxxxxx 10xxxxxx
> 
> so (*s >= 0xe2) is at least
>                     1110xxxx 10xxxxxx 10xxxxxx
>                         0010   000000   000000 == U+2000

  Whatever the C code finally is, please be sure
to comment it well (it had happen to me to forget later
why my own code was doing something... ;).

  Sometimes I've "cleaned it up" to rediscover some days
or months later (by bug reports) why it was there.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Sat Jun  6 19:45:39 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun  6 19:45:48 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <20090606063643.GF598@local.gobigwest.com>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
	<144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
	<20090606061100.GE598@local.gobigwest.com>
	<20090606063643.GF598@local.gobigwest.com>
Message-ID: <20090606174539.GD8570@dillo.org>

On Sat, Jun 06, 2009 at 06:36:43AM +0000, corvid wrote:
> I wrote:
> > furaisanjin wrote:
> > > I just wonder why this condiction exists in the patch.
> > > 
> > > if (*s&0xe2 == 0xe2) {
> > > 
> > > There are characters which start from 0xe5 in Japanese.
> > 
> > Ah yes, that is an error. Thank you.
> > 
> > Any problems with "if (*s&0xe0 == 0xe0) {" instead?
> > I believe that would force everything above U+0800
> > through the decoding, but oh well.
> 
> Wait, why don't I just use
> if (*s >= 0xe2)
> 
> (My excuse now is that I'm tired and it's time for bed, but
> I don't know what my excuse is for the other day :)
> 
> How UTF-8 works, if anyone cares:
> 0x000000-00007F is  0xxxxxxx
> 0x000080-0007FF is  110xxxxx 10xxxxxx
> 0x000800-00FFFF is  1110xxxx 10xxxxxx 10xxxxxx
> 0x010000-1FFFFF is  11110xxx 10xxxxxx 10xxxxxx 10xxxxxx
> 
> so (*s >= 0xe2) is at least
>                     1110xxxx 10xxxxxx 10xxxxxx
>                         0010   000000   000000 == U+2000

  FWIW, please consider this work "in progress".
  Not to be committed into dillo-2.1 (to be released soon).

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Sat Jun  6 21:01:41 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun  6 21:04:41 2009
Subject: [Dillo-dev] experimental patch: Re: dillo2 wrapping Chinese
In-Reply-To: <20090606174539.GD8570@dillo.org>
References: <20081110185710.GA16730@local.gobigwest.com>
	<49192930.1000508@tom.com>
	<20081111215424.GA19355@local.gobigwest.com>
	<144aa14b0811111455p6422950bgf59806fff8ec6e5e@mail.gmail.com>
	<20090603142253.GD28743@local.gobigwest.com>
	<144aa14b0906052037w6b4b6ee4sbe6266b2925eae23@mail.gmail.com>
	<20090606061100.GE598@local.gobigwest.com>
	<20090606063643.GF598@local.gobigwest.com>
	<20090606174539.GD8570@dillo.org>
Message-ID: <20090606190141.GH598@local.gobigwest.com>

Jorge wrote:
> On Sat, Jun 06, 2009 at 06:36:43AM +0000, corvid wrote:
> > I wrote:
> > > furaisanjin wrote:
> > > > I just wonder why this condiction exists in the patch.
> > > > 
> > > > if (*s&0xe2 == 0xe2) {
> > > > 
> > > > There are characters which start from 0xe5 in Japanese.
> > > 
> > > Ah yes, that is an error. Thank you.
> > > 
> > > Any problems with "if (*s&0xe0 == 0xe0) {" instead?
> > > I believe that would force everything above U+0800
> > > through the decoding, but oh well.
> > 
> > Wait, why don't I just use
> > if (*s >= 0xe2)
> > 
> > (My excuse now is that I'm tired and it's time for bed, but
> > I don't know what my excuse is for the other day :)
> > 
> > How UTF-8 works, if anyone cares:
> > 0x000000-00007F is  0xxxxxxx
> > 0x000080-0007FF is  110xxxxx 10xxxxxx
> > 0x000800-00FFFF is  1110xxxx 10xxxxxx 10xxxxxx
> > 0x010000-1FFFFF is  11110xxx 10xxxxxx 10xxxxxx 10xxxxxx
> > 
> > so (*s >= 0xe2) is at least
> >                     1110xxxx 10xxxxxx 10xxxxxx
> >                         0010   000000   000000 == U+2000
> 
>   FWIW, please consider this work "in progress".
>   Not to be committed into dillo-2.1 (to be released soon).

Right, I'm not regarding it as anything that would
go into 2.1. It's just something available for those
who have a use for it.



From jcid at dillo.org  Sun Jun  7 00:29:18 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sun Jun  7 00:29:28 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090604182640.GB1688@local.gobigwest.com>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
Message-ID: <20090606222918.GE8570@dillo.org>

On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> Paul wrote:
> > When opening dillo from the CLI I noticed the following message:
> > 
> > paths: Cannot open file '/home/user/.dillo/dillorc'
> > paths: Cannot open file '/etc/dillo/dillorc'
> > paths: Using internal defaults...
> > 
> > Checked my system and saw that dillorc had been installed
> > in /usr/etc/dillorc
> > 
> > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > as specified in src/Makefile.am, instead. Now all is fine!
> 
> In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> If I look in an etc dir and see dillorc, I'd know what it's for,
> but I wouldn't know what uses keysrc.

  Yes, a '/dillo' suffix looks OK.
  Please merge both ideas and commit.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Sun Jun  7 00:34:36 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sun Jun  7 00:34:50 2009
Subject: [Dillo-dev] form widgets, ascent/descent
In-Reply-To: <20090604181143.GA1688@local.gobigwest.com>
References: <20090604181143.GA1688@local.gobigwest.com>
Message-ID: <20090606223436.GF8570@dillo.org>

On Thu, Jun 04, 2009 at 06:11:43PM +0000, corvid wrote:
> I was playing around in dw, and noticed that,
> whereas form widgets normally like to put
> much of their height into descent, when style
> sets the height, Textblock::calcWidgetSize()
> puts it all into ascent. 
> 
> I checked firefox and saw that their form widgets ascend.
> 
> If we made everything ascend and just put font->descent
> into the descent, it would make life simpler.
> Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I
> could almost ignore that...

  Not knowing exactly about the details, I'd be very careful
in changing ascents, descents and friends because the may
interfere with correct handling of CSS.

  If you're sure it's OK to do it, even considering the "details"
(e.g. reliefs, spacings, paddings), then why not.

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Sun Jun  7 04:08:22 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun  7 04:11:13 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090606222918.GE8570@dillo.org>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
	<20090606222918.GE8570@dillo.org>
Message-ID: <20090607020822.GL598@local.gobigwest.com>

Jorge wrote:
> On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> > Paul wrote:
> > > When opening dillo from the CLI I noticed the following message:
> > > 
> > > paths: Cannot open file '/home/user/.dillo/dillorc'
> > > paths: Cannot open file '/etc/dillo/dillorc'
> > > paths: Using internal defaults...
> > > 
> > > Checked my system and saw that dillorc had been installed
> > > in /usr/etc/dillorc
> > > 
> > > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > > as specified in src/Makefile.am, instead. Now all is fine!
> > 
> > In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> > If I look in an etc dir and see dillorc, I'd know what it's for,
> > but I wouldn't know what uses keysrc.
> 
>   Yes, a '/dillo' suffix looks OK.
>   Please merge both ideas and commit.

I defined a DILLO_SYSCONF instead of DILLORC_SYS
so that a system keysrc will work someday.
Please test.



From Johannes.Hofmann at gmx.de  Sun Jun  7 12:29:51 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Sun Jun  7 12:31:35 2009
Subject: [Dillo-dev] two image problems
Message-ID: <20090607102951.GA8620@blob.baaderstrasse.com>

Hi,

I noticed two problems related to images:

Some websites seems to send images with a charset set in the header,
e.g: Content-Type: image/jpeg;charset=ISO-8859-1
In that case dillo seems to decode the data resulting in:
Not a JPEG file: starts with 0xc3 0xbf
Not sure whether we can/want to do anything about that.


I don't understand the other problem:
http://sz-magazin.sueddeutsche.de/upl/images/user/8059/17337.jpg
loads and displays fine.
from html however it doesn't work
<img src="http://sz-magazin.sueddeutsche.de/upl/images/user/8059/17337.jpg" />

Cheers,
Johannes

From corvid at lavabit.com  Sun Jun  7 16:47:39 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun  7 16:50:42 2009
Subject: [Dillo-dev] two image problems
In-Reply-To: <20090607102951.GA8620@blob.baaderstrasse.com>
References: <20090607102951.GA8620@blob.baaderstrasse.com>
Message-ID: <20090607144739.GO598@local.gobigwest.com>

Johannes wrote:
> I noticed two problems related to images:
> 
> Some websites seems to send images with a charset set in the header,
> e.g: Content-Type: image/jpeg;charset=ISO-8859-1
> In that case dillo seems to decode the data resulting in:
> Not a JPEG file: starts with 0xc3 0xbf
> Not sure whether we can/want to do anything about that.

It seems like it would make sense to restrict decoding to text/*.
I'll look in the rfc to see whether it says something relevant.

It might be good to have text decoded outside of cache to UTF-8
in the same way that images are decoded outside of cache to RGB.
(Right now that would be a problem with view src using getbuf,
 and perhaps for text/css following @charset="..." eventually,
 but still it would be nice to have one way of doing things.)


Speaking of the rfc, I noticed just recently that it says
"The value of Content-Location also defines the base URI for the entity."
and I wonder whether that's ever a problem in practice because dillo
makes no use of this header.

> I don't understand the other problem:
> http://sz-magazin.sueddeutsche.de/upl/images/user/8059/17337.jpg
> loads and displays fine.
> from html however it doesn't work
> <img src="http://sz-magazin.sueddeutsche.de/upl/images/user/8059/17337.jpg" />

When you load it by itself, dillo follows the redirection to
http://szmimg.sueddeutsche.de/upl/images/user/8059/17337.jpg


From jcid at dillo.org  Sun Jun  7 18:34:31 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sun Jun  7 18:34:40 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090607020822.GL598@local.gobigwest.com>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
	<20090606222918.GE8570@dillo.org>
	<20090607020822.GL598@local.gobigwest.com>
Message-ID: <20090607163431.GB5221@dillo.org>

On Sun, Jun 07, 2009 at 02:08:22AM +0000, corvid wrote:
> Jorge wrote:
> > On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> > > Paul wrote:
> > > > When opening dillo from the CLI I noticed the following message:
> > > > 
> > > > paths: Cannot open file '/home/user/.dillo/dillorc'
> > > > paths: Cannot open file '/etc/dillo/dillorc'
> > > > paths: Using internal defaults...
> > > > 
> > > > Checked my system and saw that dillorc had been installed
> > > > in /usr/etc/dillorc
> > > > 
> > > > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > > > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > > > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > > > as specified in src/Makefile.am, instead. Now all is fine!
> > > 
> > > In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> > > If I look in an etc dir and see dillorc, I'd know what it's for,
> > > but I wouldn't know what uses keysrc.
> > 
> >   Yes, a '/dillo' suffix looks OK.
> >   Please merge both ideas and commit.
> 
> I defined a DILLO_SYSCONF instead of DILLORC_SYS
> so that a system keysrc will work someday.
> Please test.

  dillorc and dpidrc got into "/usr/local/etc".
(I was expecting them in "/usr/local/etc/dillo").

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Sun Jun  7 18:40:50 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun  7 18:43:42 2009
Subject: [Dillo-dev] two image problems
In-Reply-To: <20090607144739.GO598@local.gobigwest.com>
References: <20090607102951.GA8620@blob.baaderstrasse.com>
	<20090607144739.GO598@local.gobigwest.com>
Message-ID: <20090607164050.GP598@local.gobigwest.com>

I wrote:
> Johannes wrote:
> > Some websites seems to send images with a charset set in the header,
> > e.g: Content-Type: image/jpeg;charset=ISO-8859-1
> > In that case dillo seems to decode the data resulting in:
> > Not a JPEG file: starts with 0xc3 0xbf
> > Not sure whether we can/want to do anything about that.
> 
> It seems like it would make sense to restrict decoding to text/*.
> I'll look in the rfc to see whether it says something relevant.

Fix committed.
RFC 2046 defines a charset parameter for text/*
(and it's also mentioned in the RFCs for text/html and text/css media types).
Nothing mentions any parameters defined for image/*, or for the specific
image types that dillo displays.

Interestingly, I learned of RFC 5147, which is a proposed standard
involving URI fragments and text/plain:
http://tools.ietf.org/html/rfc5147#section-5



From Johannes.Hofmann at gmx.de  Sun Jun  7 18:43:25 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Sun Jun  7 18:45:08 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090607163431.GB5221@dillo.org>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
	<20090606222918.GE8570@dillo.org>
	<20090607020822.GL598@local.gobigwest.com>
	<20090607163431.GB5221@dillo.org>
Message-ID: <20090607164324.GA13637@blob.baaderstrasse.com>

On Sun, Jun 07, 2009 at 12:34:31PM -0400, Jorge Arellano Cid wrote:
> On Sun, Jun 07, 2009 at 02:08:22AM +0000, corvid wrote:
> > Jorge wrote:
> > > On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> > > > Paul wrote:
> > > > > When opening dillo from the CLI I noticed the following message:
> > > > > 
> > > > > paths: Cannot open file '/home/user/.dillo/dillorc'
> > > > > paths: Cannot open file '/etc/dillo/dillorc'
> > > > > paths: Using internal defaults...
> > > > > 
> > > > > Checked my system and saw that dillorc had been installed
> > > > > in /usr/etc/dillorc
> > > > > 
> > > > > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > > > > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > > > > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > > > > as specified in src/Makefile.am, instead. Now all is fine!
> > > > 
> > > > In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> > > > If I look in an etc dir and see dillorc, I'd know what it's for,
> > > > but I wouldn't know what uses keysrc.
> > > 
> > >   Yes, a '/dillo' suffix looks OK.
> > >   Please merge both ideas and commit.
> > 
> > I defined a DILLO_SYSCONF instead of DILLORC_SYS
> > so that a system keysrc will work someday.
> > Please test.
> 
>   dillorc and dpidrc got into "/usr/local/etc".
> (I was expecting them in "/usr/local/etc/dillo").

Works fine for me. Did you call ./autogen.sh before configuring/
compiling?

Cheers,
Johannes

From corvid at lavabit.com  Sun Jun  7 18:52:10 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun  7 18:55:06 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090607163431.GB5221@dillo.org>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
	<20090606222918.GE8570@dillo.org>
	<20090607020822.GL598@local.gobigwest.com>
	<20090607163431.GB5221@dillo.org>
Message-ID: <20090607165210.GQ598@local.gobigwest.com>

Jorge wrote:
> On Sun, Jun 07, 2009 at 02:08:22AM +0000, corvid wrote:
> > Jorge wrote:
> > > On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> > > > Paul wrote:
> > > > > When opening dillo from the CLI I noticed the following message:
> > > > > 
> > > > > paths: Cannot open file '/home/user/.dillo/dillorc'
> > > > > paths: Cannot open file '/etc/dillo/dillorc'
> > > > > paths: Using internal defaults...
> > > > > 
> > > > > Checked my system and saw that dillorc had been installed
> > > > > in /usr/etc/dillorc
> > > > > 
> > > > > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > > > > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > > > > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > > > > as specified in src/Makefile.am, instead. Now all is fine!
> > > > 
> > > > In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> > > > If I look in an etc dir and see dillorc, I'd know what it's for,
> > > > but I wouldn't know what uses keysrc.
> > > 
> > >   Yes, a '/dillo' suffix looks OK.
> > >   Please merge both ideas and commit.
> > 
> > I defined a DILLO_SYSCONF instead of DILLORC_SYS
> > so that a system keysrc will work someday.
> > Please test.
> 
>   dillorc and dpidrc got into "/usr/local/etc".
> (I was expecting them in "/usr/local/etc/dillo").

Was a new 'configure' generated?
I get:
test -z "/usr/local/etc/dillo" || mkdir -p -- "/usr/local/etc/dillo"
list='dillorc'; for p in $list; do \
          if test -f "$p"; then d=; else d="./"; fi; \
          f=`echo $p | sed -e 's|^.*/||'`; \
          echo " /usr/bin/ginstall -c -m 644 '$d$p' '/usr/local/etc/dillo/$f'"; \
          /usr/bin/ginstall -c -m 644 "$d$p" "/usr/local/etc/dillo/$f"; \
        done



From corvid at lavabit.com  Sun Jun  7 19:11:53 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun  7 19:14:45 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604172943.GA3610@urvas>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
Message-ID: <20090607171153.GR598@local.gobigwest.com>

Rogutes wrote:
> Johannes Hofmann (2009-06-04 16:58):
> > On Thu, Jun 04, 2009 at 06:22:34AM +0100, Paul wrote:
> > > Hi,
> > > 
> > > I've got recent code from mercurial, June 1st.
> > > No keyboard shortcuts are working for me using KDE 3.5.10.
> > > 
> > > I was speaking to Johannes Hofmann about this problem, he asked me
> > > what my locale was (it's en-GB.UTF-8) and also asked me to report
> > > the problem here.
> > 
> > Thanks for reporting.
> > 
> > > 
> > > Do you need more information from me?
> > 
> > Is anyone else seeing this? dillo shortcuts don't seem to work at
> > all for Paul. Shortcuts in test/editor from fltk2 seem to work
> > though.
> > I can't reproduce the problem so far.
> 
> Paul,
> 
> Does anything change when you save the keysrc file attached to this
> e-mail to ~/.dillo/keysrc ? I think I had something similar, but
> I didn't have time to report...and now I forgot what it was :/

Did it have anything to do with your earlier mail
(http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-May/006378.html)
for restricting the modifiers?



From jcid at dillo.org  Sun Jun  7 21:05:46 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sun Jun  7 21:05:58 2009
Subject: [Dillo-dev] [PATCH] fix dillorc path
In-Reply-To: <20090607164324.GA13637@blob.baaderstrasse.com>
References: <20090604190524.5db85513@thewildbeast>
	<20090604182640.GB1688@local.gobigwest.com>
	<20090606222918.GE8570@dillo.org>
	<20090607020822.GL598@local.gobigwest.com>
	<20090607163431.GB5221@dillo.org>
	<20090607164324.GA13637@blob.baaderstrasse.com>
Message-ID: <20090607190546.GC5221@dillo.org>

On Sun, Jun 07, 2009 at 06:43:25PM +0200, Johannes Hofmann wrote:
> On Sun, Jun 07, 2009 at 12:34:31PM -0400, Jorge Arellano Cid wrote:
> > On Sun, Jun 07, 2009 at 02:08:22AM +0000, corvid wrote:
> > > Jorge wrote:
> > > > On Thu, Jun 04, 2009 at 06:26:40PM +0000, corvid wrote:
> > > > > Paul wrote:
> > > > > > When opening dillo from the CLI I noticed the following message:
> > > > > > 
> > > > > > paths: Cannot open file '/home/user/.dillo/dillorc'
> > > > > > paths: Cannot open file '/etc/dillo/dillorc'
> > > > > > paths: Using internal defaults...
> > > > > > 
> > > > > > Checked my system and saw that dillorc had been installed
> > > > > > in /usr/etc/dillorc
> > > > > > 
> > > > > > Checking config.log showed sysconfdir='${prefix}/etc', so no
> > > > > > surprises there. But Paths::getPrefsFP() in src/paths.cc uses
> > > > > > PATHS_RC_SYS, which is "/etc/dillo/", so my patch uses DILLORC_SYS,
> > > > > > as specified in src/Makefile.am, instead. Now all is fine!
> > > > > 
> > > > > In addition, perhaps we should make sysconfdir have '/dillo' at the end.
> > > > > If I look in an etc dir and see dillorc, I'd know what it's for,
> > > > > but I wouldn't know what uses keysrc.
> > > > 
> > > >   Yes, a '/dillo' suffix looks OK.
> > > >   Please merge both ideas and commit.
> > > 
> > > I defined a DILLO_SYSCONF instead of DILLORC_SYS
> > > so that a system keysrc will work someday.
> > > Please test.
> > 
> >   dillorc and dpidrc got into "/usr/local/etc".
> > (I was expecting them in "/usr/local/etc/dillo").
> 
> Works fine for me. Did you call ./autogen.sh before configuring/
> compiling?

  Sorry, my mistake. I run autoreconf before the "hg up".
  It works fine now.

-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Thu Jun 11 15:03:32 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Thu Jun 11 15:05:15 2009
Subject: [Dillo-dev] [patch] change font size on the fly
Message-ID: <20090611130332.GA34605@blob.baaderstrasse.com>

Hi,

attached patch allows to change the font size form the tools menu.
I find this quite handy sometimes. What do you think?

Cheers,
Johannes
-------------- next part --------------
diff -r d297c7cecbc6 src/menu.cc
--- a/src/menu.cc	Wed Jun 10 20:24:52 2009 +0000
+++ b/src/menu.cc	Thu Jun 11 15:01:08 2009 +0200
@@ -690,6 +690,20 @@
    }
 }
 
+static void Menu_fontsize_inc_cb(Widget *wid)
+{
+   _MSG("Menu_fontsize_inc_cb\n");
+   prefs.font_factor += 0.2;
+   a_UIcmd_repush(popup_bw);
+}
+
+static void Menu_fontsize_dec_cb(Widget *wid)
+{
+   _MSG("Menu_fontsize_dec_cb\n");
+   prefs.font_factor -= 0.2;
+   a_UIcmd_repush(popup_bw);
+}
+
 /*
  * Tools popup menu (construction & popup)
  */
@@ -705,6 +719,11 @@
    if (!pm) {
       pm = new PopupMenu(0,0,0,0, "TOOLS");
       pm->begin();
+       it = new Item("Larger fonts");
+       it->callback(Menu_fontsize_inc_cb);
+       it = new Item("Smaller fonts");
+       it->callback(Menu_fontsize_dec_cb);
+       new Divider();
        it = new ToggleItem("Use remote CSS");
        it->callback(Menu_remote_css_cb);
        it->state(prefs.load_stylesheets);
From corvid at lavabit.com  Thu Jun 11 17:32:35 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun 11 17:35:30 2009
Subject: [Dillo-dev] [patch] change font size on the fly
In-Reply-To: <20090611130332.GA34605@blob.baaderstrasse.com>
References: <20090611130332.GA34605@blob.baaderstrasse.com>
Message-ID: <20090611153235.GG29793@local.gobigwest.com>

Johannes wrote:
> attached patch allows to change the font size form the tools menu.
> I find this quite handy sometimes. What do you think?

No objections here.
(although I've been content since increasing font_min_size a bit)



From jcid at dillo.org  Fri Jun 12 18:47:10 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Fri Jun 12 18:47:23 2009
Subject: [Dillo-dev] [patch] change font size on the fly
In-Reply-To: <20090611153235.GG29793@local.gobigwest.com>
References: <20090611130332.GA34605@blob.baaderstrasse.com>
	<20090611153235.GG29793@local.gobigwest.com>
Message-ID: <20090612164710.GA3621@dillo.org>

On Thu, Jun 11, 2009 at 03:32:35PM +0000, corvid wrote:
> Johannes wrote:
> > attached patch allows to change the font size form the tools menu.
> > I find this quite handy sometimes. What do you think?

  As is, it's handy for developers, although it may be confusing
for users. Sometimes it works, sometimes it doesn't. When it doesn't
it looks as if nothing happened, but when going to another page,
the font factor surprises with a change.

  e.g. http://www.linuxpackages.net

  (click larger fonts a few times, then go back).


> No objections here.
> (although I've been content since increasing font_min_size a bit)

  As is now, I'd go for a plain explanation of font_min_size and
font_factor in the FAQ.

  I'd prefer to polish the patch until is behaves "as expected"
in all cases, but that may involve keeping a per page font_factor.
It may take some time...


-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Fri Jun 12 19:55:26 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Fri Jun 12 19:57:09 2009
Subject: [Dillo-dev] [patch] change font size on the fly
In-Reply-To: <20090612164710.GA3621@dillo.org>
References: <20090611130332.GA34605@blob.baaderstrasse.com>
	<20090611153235.GG29793@local.gobigwest.com>
	<20090612164710.GA3621@dillo.org>
Message-ID: <20090612175525.GA46894@blob.baaderstrasse.com>

On Fri, Jun 12, 2009 at 12:47:10PM -0400, Jorge Arellano Cid wrote:
> On Thu, Jun 11, 2009 at 03:32:35PM +0000, corvid wrote:
> > Johannes wrote:
> > > attached patch allows to change the font size form the tools menu.
> > > I find this quite handy sometimes. What do you think?
> 
>   As is, it's handy for developers, although it may be confusing
> for users. Sometimes it works, sometimes it doesn't. When it doesn't
> it looks as if nothing happened, but when going to another page,
> the font factor surprises with a change.
> 
>   e.g. http://www.linuxpackages.net
> 
>   (click larger fonts a few times, then go back).

That happens when websites specify fixed font sizes (e.g. 12pt). In
that case font_factor does not change it.
It only changes font sizes like "small", "medium" ... and font sizes
relatively defined to the base font.
Here is a related discussion:
http://css-discuss.incutio.com/?page=ForceFontSize

> 
> 
> > No objections here.
> > (although I've been content since increasing font_min_size a bit)
> 
>   As is now, I'd go for a plain explanation of font_min_size and
> font_factor in the FAQ.

Ok.

> 
>   I'd prefer to polish the patch until is behaves "as expected"
> in all cases, but that may involve keeping a per page font_factor.
> It may take some time...

Hm, let's check what other browsers do.

Cheers,
Johannes

From jcid at dillo.org  Sat Jun 13 02:45:49 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 13 02:46:02 2009
Subject: [Dillo-dev] memory use
In-Reply-To: <20090420220449.GD6155@dillo.org>
References: <20090223181757.GA3678@tim-laptop.tuxnet>
	<20090301170413.GD26251@dillo.org>
	<20090309155457.GA3623@tim-laptop.tuxnet>
	<20090325154922.GC20258@dillo.org>
	<20090325162018.GA5523@local.gobigwest.com>
	<20090325163614.GD20258@dillo.org>
	<20090325164633.GB5523@local.gobigwest.com>
	<20090325185558.GF20258@dillo.org>
	<20090327200523.GH26933@mutt.xyzz.org>
	<20090420220449.GD6155@dillo.org>
Message-ID: <20090613004549.GB3621@dillo.org>

Hi,

  After a long time, a memory usage page was added!
There's a link from the first bullet point of dillo.org, 
and another form the 9years page.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Sat Jun 13 15:29:58 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 13 15:30:11 2009
Subject: [Dillo-dev] memory use
In-Reply-To: <20090613011451.GI29793@local.gobigwest.com>
References: <20090309155457.GA3623@tim-laptop.tuxnet>
	<20090325154922.GC20258@dillo.org>
	<20090325162018.GA5523@local.gobigwest.com>
	<20090325163614.GD20258@dillo.org>
	<20090325164633.GB5523@local.gobigwest.com>
	<20090325185558.GF20258@dillo.org>
	<20090327200523.GH26933@mutt.xyzz.org>
	<20090420220449.GD6155@dillo.org> <20090613004549.GB3621@dillo.org>
	<20090613011451.GI29793@local.gobigwest.com>
Message-ID: <20090613132958.GA3839@dillo.org>

On Sat, Jun 13, 2009 at 01:14:51AM +0000, corvid wrote:
> Interesting that Firefox has a greater VSZ without images.
> I don't think I noticed that earlier.

  Oh, I didn't notice too.
  Is this result reproducible in your computer?
 
-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Sat Jun 13 16:54:52 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun 13 16:57:48 2009
Subject: [Dillo-dev] memory use
In-Reply-To: <20090613132958.GA3839@dillo.org>
References: <20090325154922.GC20258@dillo.org>
	<20090325162018.GA5523@local.gobigwest.com>
	<20090325163614.GD20258@dillo.org>
	<20090325164633.GB5523@local.gobigwest.com>
	<20090325185558.GF20258@dillo.org>
	<20090327200523.GH26933@mutt.xyzz.org>
	<20090420220449.GD6155@dillo.org> <20090613004549.GB3621@dillo.org>
	<20090613011451.GI29793@local.gobigwest.com>
	<20090613132958.GA3839@dillo.org>
Message-ID: <20090613145452.GA3045@local.gobigwest.com>

Jorge wrote:
> On Sat, Jun 13, 2009 at 01:14:51AM +0000, corvid wrote:
> > Interesting that Firefox has a greater VSZ without images.
> > I don't think I noticed that earlier.
> 
>   Oh, I didn't notice too.
>   Is this result reproducible in your computer?

I just tried with http://fltk.org/shots.php
which is easier to deal with.

dillo
8812 4668   -g, no optimization
10940 5852  opening page
14844 9732  retrieving images

I noticed that opening the page had to pull in fonts, libXcursor, libXcompat,
libnss*, libresolv, and some other things I've already forgotten.

firefox 2.0.0.20
54280 21952 to start
57108 23916 to show the page (only had to pull in fonts)
55996 25120 with images
49968 25124 after waiting a little while without having touched anything.

firefox 2.0.0.20 second try because it occurred to me that the dialog box
for preferences for turning on image loading is very heavyweight
47084 21872 to start (seven megs less this time??)
50804 23716 to show page
51764 24812  pref dialog up
49816 25052 with images
47768 25048 after waiting a while



From Johannes.Hofmann at gmx.de  Sat Jun 13 17:33:57 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Sat Jun 13 17:35:40 2009
Subject: [Dillo-dev] memory use
In-Reply-To: <20090613145452.GA3045@local.gobigwest.com>
References: <20090325162018.GA5523@local.gobigwest.com>
	<20090325163614.GD20258@dillo.org>
	<20090325164633.GB5523@local.gobigwest.com>
	<20090325185558.GF20258@dillo.org>
	<20090327200523.GH26933@mutt.xyzz.org>
	<20090420220449.GD6155@dillo.org> <20090613004549.GB3621@dillo.org>
	<20090613011451.GI29793@local.gobigwest.com>
	<20090613132958.GA3839@dillo.org>
	<20090613145452.GA3045@local.gobigwest.com>
Message-ID: <20090613153357.GA12209@blob.baaderstrasse.com>

On Sat, Jun 13, 2009 at 02:54:52PM +0000, corvid wrote:
> Jorge wrote:
> > On Sat, Jun 13, 2009 at 01:14:51AM +0000, corvid wrote:
> > > Interesting that Firefox has a greater VSZ without images.
> > > I don't think I noticed that earlier.
> > 
> >   Oh, I didn't notice too.
> >   Is this result reproducible in your computer?
> 
> I just tried with http://fltk.org/shots.php
> which is easier to deal with.
> 
> dillo
> 8812 4668   -g, no optimization
> 10940 5852  opening page
> 14844 9732  retrieving images
> 
> I noticed that opening the page had to pull in fonts, libXcursor, libXcompat,
> libnss*, libresolv, and some other things I've already forgotten.
> 
> firefox 2.0.0.20
> 54280 21952 to start
> 57108 23916 to show the page (only had to pull in fonts)
> 55996 25120 with images
> 49968 25124 after waiting a little while without having touched anything.
> 
> firefox 2.0.0.20 second try because it occurred to me that the dialog box
> for preferences for turning on image loading is very heavyweight
> 47084 21872 to start (seven megs less this time??)
> 50804 23716 to show page
> 51764 24812  pref dialog up
> 49816 25052 with images
> 47768 25048 after waiting a while
> 

afaik firefox stores pixmaps on the server side, so you probabely need
to keep an eye on Xorg memory usage too.

Cheers,
Johannes

From jcid at dillo.org  Sat Jun 13 19:02:27 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 13 19:02:53 2009
Subject: [Dillo-dev] release candidate 1
Message-ID: <20090613170227.GB3839@dillo.org>

Johannes, Corvid,

  I'll be out of town this weekend, please attend any
problem on the repo. as it's rc1. The idea is to make
a release next week.

  On the pending things that you may like to advance:
    - write the dillo-2.1 about:splash page
    - check making packages
    - polish FAQ and help text


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Mon Jun 15 19:43:29 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun 15 19:43:45 2009
Subject: [Dillo-dev] release candidate 1
In-Reply-To: <20090613170227.GB3839@dillo.org>
References: <20090613170227.GB3839@dillo.org>
Message-ID: <20090615174329.GB6224@dillo.org>

On Sat, Jun 13, 2009 at 01:02:27PM -0400, Jorge Arellano Cid wrote:
> Johannes, Corvid,
> 
>   I'll be out of town this weekend, please attend any
> problem on the repo. as it's rc1. The idea is to make
> a release next week.
> 
>   On the pending things that you may like to advance:
>     - write the dillo-2.1 about:splash page

  A splash page was committed. Please comment or send
suggestions/patches/ideas/kudos :)

  We're almost there...

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Mon Jun 15 20:21:37 2009
From: corvid at lavabit.com (corvid)
Date: Mon Jun 15 20:24:46 2009
Subject: [Dillo-dev] release candidate 1
In-Reply-To: <20090615174329.GB6224@dillo.org>
References: <20090613170227.GB3839@dillo.org> <20090615174329.GB6224@dillo.org>
Message-ID: <20090615182137.GB8031@local.gobigwest.com>

Jorge wrote:
>   A splash page was committed. Please comment or send
> suggestions/patches/ideas/kudos :)

Edited slightly.



From dennisn at dennisn.dyndns.org  Mon Jun 15 23:40:56 2009
From: dennisn at dennisn.dyndns.org (Dennis Nezic)
Date: Mon Jun 15 23:45:30 2009
Subject: [Dillo-dev] Limiting number connections made to server
Message-ID: <20090615174056.9c5ed3ec.dennisn@dennisn.dyndns.org>

Currently, I don't think dillo places any kind of regulation on the
number of connections it tries to make with an http server, and this
causes bad things to happen with some -- ie. if it tries to open a page
with hundreds of thumbnails, it can crash some http servers. Is there a
way to limit the number of connections made?


From corvid at lavabit.com  Tue Jun 16 04:15:00 2009
From: corvid at lavabit.com (corvid)
Date: Tue Jun 16 04:18:00 2009
Subject: [Dillo-dev] Limiting number connections made to server
In-Reply-To: <20090615174056.9c5ed3ec.dennisn@dennisn.dyndns.org>
References: <20090615174056.9c5ed3ec.dennisn@dennisn.dyndns.org>
Message-ID: <20090616021500.GD8031@local.gobigwest.com>

Dennis wrote:
> Currently, I don't think dillo places any kind of regulation on the
> number of connections it tries to make with an http server, and this
> causes bad things to happen with some -- ie. if it tries to open a page
> with hundreds of thumbnails, it can crash some http servers. Is there a
> way to limit the number of connections made?

I really wish there were.
Dillo should be a good citizen.

(Well, there's always the 'solution' of turning off automatic image loading :)



From jcid at dillo.org  Tue Jun 16 17:51:40 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 16 19:15:57 2009
Subject: [Dillo-dev] Limiting number connections made to server
In-Reply-To: <20090616021500.GD8031@local.gobigwest.com>
References: <20090615174056.9c5ed3ec.dennisn@dennisn.dyndns.org>
	<20090616021500.GD8031@local.gobigwest.com>
Message-ID: <20090616155140.GA4239@dillo.org>

On Tue, Jun 16, 2009 at 02:15:00AM +0000, corvid wrote:
> Dennis wrote:
> > Currently, I don't think dillo places any kind of regulation on the
> > number of connections it tries to make with an http server, and this
> > causes bad things to happen with some -- ie. if it tries to open a page
> > with hundreds of thumbnails, it can crash some http servers. Is there a
> > way to limit the number of connections made?
> 
> I really wish there were.
> Dillo should be a good citizen.

  Currently Dillo doesn't have a way to limit the number of
connections. I assume that apache has a way on the server side and
that more or less has made of it a smaller problem. What http server
are you using?

  This will probably get into the feature request queue for dillo-2.2.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Tue Jun 16 20:09:54 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 16 20:10:10 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
Message-ID: <20090616180954.GD4239@dillo.org>

Hi there,

   We're approaching quickly to the release of dillo-2.1 ! :)
The idea is to make the official announcement this Thursday 18 (June)

   I've uploaded the source tarball:

     http://www.dillo.org/download/


   We need the main .deb and .rpm before Thursday (e.g. Ubuntu & Debian
current, same for the most used Fedora). Would you mind Andreas, Kelson?

   Any comments, confirmation of OK-ness, tests or last minute touches,
this is the moment.

   TIA.
   
-- 
  Cheers
  Jorge.-

From dennisn at dennisn.dyndns.org  Tue Jun 16 21:23:27 2009
From: dennisn at dennisn.dyndns.org (Dennis Nezic)
Date: Tue Jun 16 21:24:06 2009
Subject: [Dillo-dev] Re: Limiting number connections made to server
References: <20090615174056.9c5ed3ec.dennisn@dennisn.dyndns.org>
	<20090616021500.GD8031@local.gobigwest.com>
	<20090616155140.GA4239@dillo.org>
Message-ID: <20090616152327.737f0646.dennisn@dennisn.dyndns.org>

On Tue, 16 Jun 2009 11:51:40 -0400, Jorge Arellano Cid wrote:
> On Tue, Jun 16, 2009 at 02:15:00AM +0000, corvid wrote:
> > Dennis wrote:
> > > Currently, I don't think dillo places any kind of regulation on
> > > the number of connections it tries to make with an http server,
> > > and this causes bad things to happen with some -- ie. if it tries
> > > to open a page with hundreds of thumbnails, it can crash some
> > > http servers. Is there a way to limit the number of connections
> > > made?
> > 
> > I really wish there were.
> > Dillo should be a good citizen.
> 
>   Currently Dillo doesn't have a way to limit the number of
> connections. I assume that apache has a way on the server side and
> that more or less has made of it a smaller problem. What http server
> are you using?

Freenet's fproxy :P. Currently dillo DoS'es the server if it tries
opening a page with hundreds of images. (It causes the server to exceed
the thread limit, which stalls everything :|). I hope they'll do
something on their end as well :).

> 
>   This will probably get into the feature request queue for dillo-2.2.
> 


From jcid at dillo.org  Tue Jun 16 22:10:59 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 16 22:11:12 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
Message-ID: <20090616201059.GE4239@dillo.org>

On Tue, Jun 16, 2009 at 09:34:43PM +0200, Devid Antonio Filoni wrote:
> I'm working on the Debian/Ubuntu package. I'm the Debian developer of
> dillo so I know what I do, however I will not upload this in Debian
> until fltk doesn't fix the license (it should be December 2001 in
> order to get uploaded in Debian). I will send you the package
> tomorrow.

  Excellent.


-- 
  Cheers
  Jorge.-

From newman.x at gmail.com  Tue Jun 16 23:18:23 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Tue Jun 16 23:19:21 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090616201059.GE4239@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
Message-ID: <20090616211822.GB5061@assam.Belkin>

On Tue, Jun 16, 2009 at 04:10:59PM -0400, Jorge Arellano Cid wrote:
> On Tue, Jun 16, 2009 at 09:34:43PM +0200, Devid Antonio Filoni wrote:
> > I'm working on the Debian/Ubuntu package. I'm the Debian developer of
> > dillo so I know what I do, however I will not upload this in Debian
> > until fltk doesn't fix the license (it should be December 2001 in
> > order to get uploaded in Debian). I will send you the package
> > tomorrow.
> 
>   Excellent.
> 

I'd like to create Fedora RPM's (since I am Fedora packager), the
problem is that fltk2 is not in Fedora (Package Review's pending [1],
help welcomed), so, only unofficial packages are doable now.

Problem with Fedora 11 is that fltk2 can't be built with recent g++ 
[2]. I might check with with F-10, it used to work.

Michal

[1] https://bugzilla.redhat.com/show_bug.cgi?id=477683
[2] http://fltk.org/str.php?L2205

> 
> -- 
>   Cheers
>   Jorge.-
> 
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

-- 
Regards,
Michal Nowak

From higuita7 at yahoo.co.uk  Wed Jun 17 00:47:42 2009
From: higuita7 at yahoo.co.uk (higuita)
Date: Wed Jun 17 00:48:44 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090604172943.GA3610@urvas>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
Message-ID: <20090616234742.4e54df2d@Couracado.homelinux.net>

Hi all

On Thu, 4 Jun 2009 20:29:43 +0300, Rogut?s Sparnuotos <rogutes@googlemail.com> wrote:
> > > I've got recent code from mercurial, June 1st.
> > > No keyboard shortcuts are working for me using KDE 3.5.10.

	i checkout the latest HG and i found that i also have this
	problem.

	i'm using fluxbox on a slamd64 linux system. here is my
	locale:

LANG=pt_PT@euro
LC_CTYPE="pt_PT@euro"
LC_NUMERIC="pt_PT@euro"
LC_TIME="pt_PT@euro"
LC_COLLATE="pt_PT@euro"
LC_MONETARY="pt_PT@euro"
LC_MESSAGES=en_US.utf8
LC_PAPER="pt_PT@euro"
LC_NAME="pt_PT@euro"
LC_ADDRESS="pt_PT@euro"
LC_TELEPHONE="pt_PT@euro"
LC_MEASUREMENT="pt_PT@euro"
LC_IDENTIFICATION="pt_PT@euro"
LC_ALL=

	i tried to remove the .dillo, put the previous post
	keysrc, remove the system keysrc and nothing works,
	any shortcut i try will not do anything.

	if the 	focus is in the url bar and i do a ctrl+q it will
	show ^Q ... ^V do the paste, ^H erases, ^T swaps the 
	letters and some others... it seems like i'm in a terminal
	using the terminal shortcuts. I don't recall doing this in
	the past.

	i don't know exactly what previous version i was using, 
	it was also a HG checkout, maybe a month or two old

	i'm ready to do more tests and rebuilds to help debug
	this problem.

Thanks
higuita
-- 
Naturally the common people don't want war... but after all it is the
leaders of a country who determine the policy, and it is always a 
simple matter to drag the people along, whether it is a democracy, or
a fascist dictatorship, or a parliament, or a communist dictatorship.
Voice or no voice, the people can always be brought to the bidding of
the leaders. That is easy. All you have to do is tell them they are 
being attacked, and denounce the pacifists for lack of patriotism and
exposing the country to danger.  It works the same in every country.
           -- Hermann Goering, Nazi and war criminal, 1883-1946
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20090616/fedb9e84/signature.pgp
From corvid at lavabit.com  Wed Jun 17 01:54:17 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 17 01:57:17 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090616234742.4e54df2d@Couracado.homelinux.net>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
	<20090616234742.4e54df2d@Couracado.homelinux.net>
Message-ID: <20090616235417.GE8031@local.gobigwest.com>

higuita wrote:
> On Thu, 4 Jun 2009 20:29:43 +0300, Rogut?s Sparnuotos <rogutes@googlemail.com> wrote:
> > > > I've got recent code from mercurial, June 1st.
> > > > No keyboard shortcuts are working for me using KDE 3.5.10.
> 
> 	i checkout the latest HG and i found that i also have this
> 	problem.
> 
> 	i'm using fluxbox on a slamd64 linux system. here is my
> 	locale:
> 
> LANG=pt_PT@euro
> LC_CTYPE="pt_PT@euro"
> LC_NUMERIC="pt_PT@euro"
> LC_TIME="pt_PT@euro"
> LC_COLLATE="pt_PT@euro"
> LC_MONETARY="pt_PT@euro"
> LC_MESSAGES=en_US.utf8
> LC_PAPER="pt_PT@euro"
> LC_NAME="pt_PT@euro"
> LC_ADDRESS="pt_PT@euro"
> LC_TELEPHONE="pt_PT@euro"
> LC_MEASUREMENT="pt_PT@euro"
> LC_IDENTIFICATION="pt_PT@euro"
> LC_ALL=
> 
> 	i tried to remove the .dillo, put the previous post
> 	keysrc, remove the system keysrc and nothing works,
> 	any shortcut i try will not do anything.
> 
> 	if the 	focus is in the url bar and i do a ctrl+q it will
> 	show ^Q ... ^V do the paste, ^H erases, ^T swaps the 
> 	letters and some others... it seems like i'm in a terminal
> 	using the terminal shortcuts. I don't recall doing this in
> 	the past.
> 
> 	i don't know exactly what previous version i was using, 
> 	it was also a HG checkout, maybe a month or two old
> 
> 	i'm ready to do more tests and rebuilds to help debug
> 	this problem.

Does this
http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-May/006378.html
make any difference for you?



From higuita7 at yahoo.co.uk  Wed Jun 17 03:31:43 2009
From: higuita7 at yahoo.co.uk (higuita)
Date: Wed Jun 17 03:32:44 2009
Subject: [Dillo-dev] keyboard shortcuts non-functioning under KDE 3.5.10
In-Reply-To: <20090616235417.GE8031@local.gobigwest.com>
References: <20090604062234.6d42a06c@thewildbeast>
	<20090604145813.GA889@blob.baaderstrasse.com>
	<20090604172943.GA3610@urvas>
	<20090616234742.4e54df2d@Couracado.homelinux.net>
	<20090616235417.GE8031@local.gobigwest.com>
Message-ID: <20090617023143.030d1c49@Couracado.homelinux.net>

On Tue, 16 Jun 2009 23:54:17 +0000, "corvid" <corvid@lavabit.com> wrote:
> > > > > No keyboard shortcuts are working for me using KDE 3.5.10.
> > 	i checkout the latest HG and i found that i also have this
> > 	problem.
> Does this
> http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-May/006378.html
> make any difference for you?

	well... at least if i turn on the numlock, the key shortcuts
	start to work again. what a easy workaround :)

	after applying the email patch and rebuilding, i have the
	shortcuts working, with or without numlock on... so that patch
	fix this. Thanks!

	by the way, i also think that command=keybinding is more
	friendly, in a quick check we can see what are the actions
	available and their shortcut

	Thanks for dillo
higuita
-- 
Naturally the common people don't want war... but after all it is the
leaders of a country who determine the policy, and it is always a 
simple matter to drag the people along, whether it is a democracy, or
a fascist dictatorship, or a parliament, or a communist dictatorship.
Voice or no voice, the people can always be brought to the bidding of
the leaders. That is easy. All you have to do is tell them they are 
being attacked, and denounce the pacifists for lack of patriotism and
exposing the country to danger.  It works the same in every country.
           -- Hermann Goering, Nazi and war criminal, 1883-1946
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
Url : /pipermail/attachments/20090617/89a17a3e/signature.pgp
From newman.x at gmail.com  Wed Jun 17 15:11:44 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Wed Jun 17 15:12:09 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <4A3812C4.4040207@pobox.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org> <20090616211822.GB5061@assam.Belkin>
	<4A3812C4.4040207@pobox.com>
Message-ID: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>

On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
> Michal Nowak wrote:
>>
>> I'd like to create Fedora RPM's (since I am Fedora packager), the
>> problem is that fltk2 is not in Fedora (Package Review's pending [1],
>> help welcomed), so, only unofficial packages are doable now.
>>
>> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
>> might check with with F-10, it used to work.
>
> I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
> work there.

In http://fltk.org/str.php?L2205 I was suggested to make a code change in
FLTK2, I did so and it compiles fine now. I am not sure of the root cause
because fltk guys suggested that the problem is glibc-2.10 and pointed to
patch but the patch looks to be incorporated in F-11 glibc.

>
> If you want to take a look, my SRPMS are available at
> http://www.hyperborea.org/software/dillo/rpms/
>
> The spec for FLTK2 is *very* rough, and the spec for Dillo has a lot of
> cruft from back when I was maintaining packages for a bunch of different
> distros.

While looking at [1] it looks like you are using static archives (.a), while I
turned on shared libs [2] option in FLTK2 and provide them instead.

I fixed the remaining issues from package review [3], I guess FLTK2 might
be in Fedora in near future.

But now:

FLTK2 packages for Fedora 10, 11, 12 (Rawhide) for ix86 and x86-64

---> http://mnowak.fedorapeople.org/fltk2/

Enjoy

[1] http://www.hyperborea.org/software/dillo/rpms/fltk2-2.0.x.r6786-0.1.f10.x86_64.rpm
[2] http://mnowak.fedorapeople.org/fltk2/
[3] https://bugzilla.redhat.com/show_bug.cgi?id=fltk2

>
> --
> Kelson Vibber
> Hyperborea.org - SpeedForce.org
>

Michal

From jcid at dillo.org  Wed Jun 17 20:30:58 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 17 20:31:10 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617033355.GF8031@local.gobigwest.com>
References: <20090616180954.GD4239@dillo.org>
	<20090617033355.GF8031@local.gobigwest.com>
Message-ID: <20090617183058.GA10602@dillo.org>

On Wed, Jun 17, 2009 at 03:33:56AM +0000, corvid wrote:
> I just remembered that the README needs to be updated
> since it talks about all of the new things that 2.0 brought.

  I  just  updated  the  repo.  Please  give  it a review and fix
the grammar where necessary.

  The patch for working keyboard under numlock was also committed
(overlooked by me). Those having trouble with rc1, please confirm
the repo (rc2) works OK now.

  When  I  get both OKs, I'll upload a new tarball for making the
respective packages. If there's anything else pending, speak now!


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 17 21:02:17 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 17 21:02:30 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
Message-ID: <20090617190217.GB10602@dillo.org>

Hi Michal,

On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
> > Michal Nowak wrote:
> >>
> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
> >> help welcomed), so, only unofficial packages are doable now.
> >>
> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
> >> might check with with F-10, it used to work.
> >
> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
> > work there.

  It's  good  to  see  you're  already  coordinating with Kelson,
because that's exactly what I was to suggest.


> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
> because fltk guys suggested that the problem is glibc-2.10 and pointed to
> patch but the patch looks to be incorporated in F-11 glibc.

  FLTK2 is giving some confusion even to FLTK developers:
http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
("pre-release thread").

  In a nutshell (from my point of view):

   * fltk2 is not officially released, and maybe never will.
   * dillo2 uses fltk2, and this creates pressure to package it.
   * Distros have a policy against statically-linked binaries.
   * We can provide unofficial statically-linked packages until
     the distro provides a shared fltk2 lib.

  So, I'd suggest to package a statically-linked binary until the
shared  fltk2  is  available from the distro. Once this happen we
can provide a dynamic one.

  This  avoids  having to sort out the patching/adjusting problem
of packaging a shared library, which is best solved by the distro
itself.

  Now,  it looks like you are the Fedora distro developer working
on  both  fltk2  and  dillo2,  so in this case you can decide and
suggest what looks best from your point of view.

  From  a user perspective, it looks simpler to download a single
binary  and  install it. If the shared way is decided, we need to
provide nutshell directions.

  In  the  Debian  case, I assume a statically linked deb will be
produced (until the license problem is solved).

  Comments?

-- 
  Cheers
  Jorge.-

From devidfil at gmail.com  Wed Jun 17 22:01:12 2009
From: devidfil at gmail.com (Devid Antonio Filoni)
Date: Wed Jun 17 22:02:07 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617190217.GB10602@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org> <20090616211822.GB5061@assam.Belkin>
	<4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
Message-ID: <64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>

On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> Hi Michal,
>
> On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
>> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
>> > Michal Nowak wrote:
>> >>
>> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
>> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
>> >> help welcomed), so, only unofficial packages are doable now.
>> >>
>> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
>> >> might check with with F-10, it used to work.
>> >
>> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
>> > work there.
>
> ?It's ?good ?to ?see ?you're ?already ?coordinating with Kelson,
> because that's exactly what I was to suggest.
>
>
>> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
>> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
>> because fltk guys suggested that the problem is glibc-2.10 and pointed to
>> patch but the patch looks to be incorporated in F-11 glibc.
>
> ?FLTK2 is giving some confusion even to FLTK developers:
> http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
> ("pre-release thread").
>
> ?In a nutshell (from my point of view):
>
> ? * fltk2 is not officially released, and maybe never will.
> ? * dillo2 uses fltk2, and this creates pressure to package it.
> ? * Distros have a policy against statically-linked binaries.
> ? * We can provide unofficial statically-linked packages until
> ? ? the distro provides a shared fltk2 lib.
>
> ?So, I'd suggest to package a statically-linked binary until the
> shared ?fltk2 ?is ?available from the distro. Once this happen we
> can provide a dynamic one.
>
> ?This ?avoids ?having to sort out the patching/adjusting problem
> of packaging a shared library, which is best solved by the distro
> itself.
>
> ?Now, ?it looks like you are the Fedora distro developer working
> on ?both ?fltk2 ?and ?dillo2, ?so in this case you can decide and
> suggest what looks best from your point of view.
>
> ?From ?a user perspective, it looks simpler to download a single
> binary ?and ?install it. If the shared way is decided, we need to
> provide nutshell directions.
>
> ?In ?the ?Debian ?case, I assume a statically linked deb will be
> produced (until the license problem is solved).
Yes, I preparated an FLTK2 Debian package and it is built as static
lib but this should be avoided if possible, the problem is that fltk2
isn't stable enough so ATM it is static... The Debian license is the
issue that doesn't allow me to upload the fltk2  (and also dillo2)
package in Debian, there is an open bug about this
(http://www.fltk.org/str.php?L2198+P0+S-2+C0+I0+E0+Qlicense).
> ?Comments?
>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org

Devid
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From jcid at dillo.org  Wed Jun 17 23:45:02 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 17 23:45:16 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
Message-ID: <20090617214502.GD10602@dillo.org>

On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
> On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > Hi Michal,
> >
> > On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
> >> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
> >> > Michal Nowak wrote:
> >> >>
> >> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
> >> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
> >> >> help welcomed), so, only unofficial packages are doable now.
> >> >>
> >> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
> >> >> might check with with F-10, it used to work.
> >> >
> >> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
> >> > work there.
> >
> > ?It's ?good ?to ?see ?you're ?already ?coordinating with Kelson,
> > because that's exactly what I was to suggest.
> >
> >
> >> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
> >> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
> >> because fltk guys suggested that the problem is glibc-2.10 and pointed to
> >> patch but the patch looks to be incorporated in F-11 glibc.
> >
> > ?FLTK2 is giving some confusion even to FLTK developers:
> > http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
> > ("pre-release thread").
> >
> > ?In a nutshell (from my point of view):
> >
> > ? * fltk2 is not officially released, and maybe never will.
> > ? * dillo2 uses fltk2, and this creates pressure to package it.
> > ? * Distros have a policy against statically-linked binaries.
> > ? * We can provide unofficial statically-linked packages until
> > ? ? the distro provides a shared fltk2 lib.
> >
> > ?So, I'd suggest to package a statically-linked binary until the
> > shared ?fltk2 ?is ?available from the distro. Once this happen we
> > can provide a dynamic one.
> >
> > ?This ?avoids ?having to sort out the patching/adjusting problem
> > of packaging a shared library, which is best solved by the distro
> > itself.
> >
> > ?Now, ?it looks like you are the Fedora distro developer working
> > on ?both ?fltk2 ?and ?dillo2, ?so in this case you can decide and
> > suggest what looks best from your point of view.
> >
> > ?From ?a user perspective, it looks simpler to download a single
> > binary ?and ?install it. If the shared way is decided, we need to
> > provide nutshell directions.
> >
> > ?In ?the ?Debian ?case, I assume a statically linked deb will be
> > produced (until the license problem is solved).
> Yes, I preparated an FLTK2 Debian package and it is built as static
> lib but this should be avoided if possible, the problem is that fltk2
> isn't stable enough so ATM it is static... The Debian license is the
> issue that doesn't allow me to upload the fltk2  (and also dillo2)
> package in Debian, there is an open bug about this
> (http://www.fltk.org/str.php?L2198+P0+S-2+C0+I0+E0+Qlicense).

  OK.

  BTW, the rc2 version of dillo-2.1 (hopefully final) was
just uploaded to http://www.dillo.org/download/ so packagers
can make the respective files.

  The idea is to make the announcement tomorrow in the morning.

  Devid: please send me the .deb and its directions when done.

  Same for rpm.

  TIA.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Thu Jun 18 00:00:22 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 00:00:37 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617214502.GD10602@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
Message-ID: <20090617220022.GE10602@dillo.org>

On Wed, Jun 17, 2009 at 05:45:02PM -0400, Jorge Arellano Cid wrote:
> On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
> > On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > > Hi Michal,
> > >
> > > On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
> > >> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
> > >> > Michal Nowak wrote:
> > >> >>
> > >> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
> > >> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
> > >> >> help welcomed), so, only unofficial packages are doable now.
> > >> >>
> > >> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
> > >> >> might check with with F-10, it used to work.
> > >> >
> > >> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
> > >> > work there.
> > >
> > > ?It's ?good ?to ?see ?you're ?already ?coordinating with Kelson,
> > > because that's exactly what I was to suggest.
> > >
> > >
> > >> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
> > >> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
> > >> because fltk guys suggested that the problem is glibc-2.10 and pointed to
> > >> patch but the patch looks to be incorporated in F-11 glibc.
> > >
> > > ?FLTK2 is giving some confusion even to FLTK developers:
> > > http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
> > > ("pre-release thread").
> > >
> > > ?In a nutshell (from my point of view):
> > >
> > > ? * fltk2 is not officially released, and maybe never will.
> > > ? * dillo2 uses fltk2, and this creates pressure to package it.
> > > ? * Distros have a policy against statically-linked binaries.
> > > ? * We can provide unofficial statically-linked packages until
> > > ? ? the distro provides a shared fltk2 lib.
> > >
> > > ?So, I'd suggest to package a statically-linked binary until the
> > > shared ?fltk2 ?is ?available from the distro. Once this happen we
> > > can provide a dynamic one.
> > >
> > > ?This ?avoids ?having to sort out the patching/adjusting problem
> > > of packaging a shared library, which is best solved by the distro
> > > itself.
> > >
> > > ?Now, ?it looks like you are the Fedora distro developer working
> > > on ?both ?fltk2 ?and ?dillo2, ?so in this case you can decide and
> > > suggest what looks best from your point of view.
> > >
> > > ?From ?a user perspective, it looks simpler to download a single
> > > binary ?and ?install it. If the shared way is decided, we need to
> > > provide nutshell directions.
> > >
> > > ?In ?the ?Debian ?case, I assume a statically linked deb will be
> > > produced (until the license problem is solved).
> > Yes, I preparated an FLTK2 Debian package and it is built as static
> > lib but this should be avoided if possible, the problem is that fltk2
> > isn't stable enough so ATM it is static... The Debian license is the
> > issue that doesn't allow me to upload the fltk2  (and also dillo2)
> > package in Debian, there is an open bug about this
> > (http://www.fltk.org/str.php?L2198+P0+S-2+C0+I0+E0+Qlicense).
> 
>   OK.
> 
>   BTW, the rc2 version of dillo-2.1 (hopefully final) was
> just uploaded to http://www.dillo.org/download/ so packagers
> can make the respective files.
> 
>   The idea is to make the announcement tomorrow in the morning.
> 
>   Devid: please send me the .deb and its directions when done.
> 
>   Same for rpm.

  Last but not the least.

  I use "./configure --enable-ssl" bacause that way dillo is much
more  useful (mainly for reading forums and bug trackers). So I'd
suggest  to  make  the packages with SSL enabled, unless somebody
reembers a compelling reason not to do so.

  There're  times  when  the  certificate asking dialog bombs the
user,  but maybe not so often, or annoyingly enough, to avoid the
SSL dpi.

  Comments?

  
-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Thu Jun 18 01:09:16 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun 18 01:12:16 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617220022.GE10602@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
Message-ID: <20090617230916.GI8031@local.gobigwest.com>

Jorge wrote:
>   I use "./configure --enable-ssl" bacause that way dillo is much
> more  useful (mainly for reading forums and bug trackers). So I'd
> suggest  to  make  the packages with SSL enabled, unless somebody
> reembers a compelling reason not to do so.
> 
>   There're  times  when  the  certificate asking dialog bombs the
> user,  but maybe not so often, or annoyingly enough, to avoid the
> SSL dpi.
> 
>   Comments?

iirc it stops giving you those messages if the dpi can find
a directory containing certificates, in which case the fact
that we don't check (I don't think we do, anyway) that the
server is presenting _its_ certificate is a problem.



From jcid at dillo.org  Thu Jun 18 04:54:42 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 04:54:58 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617230916.GI8031@local.gobigwest.com>
References: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<20090617230916.GI8031@local.gobigwest.com>
Message-ID: <20090618025442.GH10602@dillo.org>

On Wed, Jun 17, 2009 at 11:09:16PM +0000, corvid wrote:
> Jorge wrote:
> >   I use "./configure --enable-ssl" bacause that way dillo is much
> > more  useful (mainly for reading forums and bug trackers). So I'd
> > suggest  to  make  the packages with SSL enabled, unless somebody
> > reembers a compelling reason not to do so.
> > 
> >   There're  times  when  the  certificate asking dialog bombs the
> > user,  but maybe not so often, or annoyingly enough, to avoid the
> > SSL dpi.
> > 
> >   Comments?
> 
> iirc it stops giving you those messages if the dpi can find
> a directory containing certificates, in which case the fact
> that we don't check (I don't think we do, anyway) that the
> server is presenting _its_ certificate is a problem.

  *Sigh*

  Well in that case, I assume that no SSL as default is OK.

  OTOH packagers may provide an enabled version with the warning
that no certificates are being checked.

-- 
  Cheers
  Jorge.-

From newman.x at gmail.com  Thu Jun 18 10:27:20 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Thu Jun 18 10:27:45 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617190217.GB10602@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org> <20090616211822.GB5061@assam.Belkin>
	<4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
Message-ID: <5e9a80350906180127q9994cd4gc60d5bf8a4dfbb67@mail.gmail.com>

On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> Hi Michal,

Hola Jorge,

>
> On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
>> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
>> > Michal Nowak wrote:
>> >>
>> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
>> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
>> >> help welcomed), so, only unofficial packages are doable now.
>> >>
>> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
>> >> might check with with F-10, it used to work.
>> >
>> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
>> > work there.
>
> ?It's ?good ?to ?see ?you're ?already ?coordinating with Kelson,
> because that's exactly what I was to suggest.
>
>
>> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
>> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
>> because fltk guys suggested that the problem is glibc-2.10 and pointed to
>> patch but the patch looks to be incorporated in F-11 glibc.
>
> ?FLTK2 is giving some confusion even to FLTK developers:
> http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
> ("pre-release thread").

Yes. While I did not read the license yet, if  Debian feels the fltk2 one is
problematic, Fedora legal will feel probably the same (aka blocker).

>
> ?In a nutshell (from my point of view):
>
> ? * fltk2 is not officially released, and maybe never will.
> ? * dillo2 uses fltk2, and this creates pressure to package it.
> ? * Distros have a policy against statically-linked binaries.

Definitely agree. The first and the second one can be somehow
sorted out and fltk2 pushed to distribution, the last one is blocker.

> ? * We can provide unofficial statically-linked packages until
> ? ? the distro provides a shared fltk2 lib.
>

That's of course possible and doable but pita anyway. We can't
ever make package for every distro out there, that's obvious.

> ?So, I'd suggest to package a statically-linked binary until the
> shared ?fltk2 ?is ?available from the distro. Once this happen we
> can provide a dynamic one.
>

I can do F-11 builds if needed.

> ?This ?avoids ?having to sort out the patching/adjusting problem
> of packaging a shared library, which is best solved by the distro
> itself.
>
> ?Now, ?it looks like you are the Fedora distro developer working
> on ?both ?fltk2 ?and ?dillo2, ?so in this case you can decide and
> suggest what looks best from your point of view.
>

I'm behind fltk2 in Fedora, Dillo is maintained by someone else but
is prepared for bump to Dillo-2 (there's bugzilla for this) when is
fltk2 in place...

> ?From ?a user perspective, it looks simpler to download a single
> binary ?and ?install it. If the shared way is decided, we need to
> provide nutshell directions.

I believe the simplest way for user how to get distro conforming
packages is via distribution repositories (+ receives security,
in-between-release problems solving, not necessary to check third party
websites, etc).

You greatly outlined the problems with having Dillo-2 in distribution;
the problem is FLTK2. While watching at "changes" in FLTK2 snapshots
I can't thing that the development is stalled or even stopped.

I understand that my proposal won't be popular but switching from
FLTK2 is necessary - we hardly have FLTK2 in distributions (read: no
Dillo-2 in distribution) and that's shortening our user base.

How hard it would be to rewrite/port Dillo-2 to FLTK-1.3?

(I see that the speed of v1.3 development is nothing exciting, but
from what I read months ago they at least plan to have a release
ever.)

While looking at the devel cycle of Dillo - two releases per year -
I believe this porting should be mid-term goal. Unless we wanna
spend another year out of mainstream distributions. (And frankly:
even with Dillo-2 based on FLTK-1.3 we are quite far from Dillo-2
in distribution...)

>
> ?In ?the ?Debian ?case, I assume a statically linked deb will be
> produced (until the license problem is solved).
>
> ?Comments?
>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From newman.x at gmail.com  Thu Jun 18 10:36:39 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Thu Jun 18 10:37:32 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090617220022.GE10602@dillo.org>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org> <20090616211822.GB5061@assam.Belkin>
	<4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
Message-ID: <5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>

On Thu, Jun 18, 2009 at 12:00 AM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> On Wed, Jun 17, 2009 at 05:45:02PM -0400, Jorge Arellano Cid wrote:
>> On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
>> > On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
>> > > Hi Michal,
>> > >
>> > > On Wed, Jun 17, 2009 at 03:11:44PM +0200, Michal Nowak wrote:
>> > >> On Tue, Jun 16, 2009 at 11:46 PM, Kelson Vibber<kelson@pobox.com> wrote:
>> > >> > Michal Nowak wrote:
>> > >> >>
>> > >> >> I'd like to create Fedora RPM's (since I am Fedora packager), the
>> > >> >> problem is that fltk2 is not in Fedora (Package Review's pending [1],
>> > >> >> help welcomed), so, only unofficial packages are doable now.
>> > >> >>
>> > >> >> Problem with Fedora 11 is that fltk2 can't be built with recent g++ [2]. I
>> > >> >> might check with with F-10, it used to work.
>> > >> >
>> > >> > I've just built FLTK2 r6786 and Dillo 2.1 on a Fedora 10 system, so it does
>> > >> > work there.
>> > >
>> > > ?It's ?good ?to ?see ?you're ?already ?coordinating with Kelson,
>> > > because that's exactly what I was to suggest.
>> > >
>> > >
>> > >> In http://fltk.org/str.php?L2205 I was suggested to make a code change in
>> > >> FLTK2, I did so and it compiles fine now. I am not sure of the root cause
>> > >> because fltk guys suggested that the problem is glibc-2.10 and pointed to
>> > >> patch but the patch looks to be incorporated in F-11 glibc.
>> > >
>> > > ?FLTK2 is giving some confusion even to FLTK developers:
>> > > http://fltk.org/newsgroups.php?s6818+gfltk.development+T1
>> > > ("pre-release thread").
>> > >
>> > > ?In a nutshell (from my point of view):
>> > >
>> > > ? * fltk2 is not officially released, and maybe never will.
>> > > ? * dillo2 uses fltk2, and this creates pressure to package it.
>> > > ? * Distros have a policy against statically-linked binaries.
>> > > ? * We can provide unofficial statically-linked packages until
>> > > ? ? the distro provides a shared fltk2 lib.
>> > >
>> > > ?So, I'd suggest to package a statically-linked binary until the
>> > > shared ?fltk2 ?is ?available from the distro. Once this happen we
>> > > can provide a dynamic one.
>> > >
>> > > ?This ?avoids ?having to sort out the patching/adjusting problem
>> > > of packaging a shared library, which is best solved by the distro
>> > > itself.
>> > >
>> > > ?Now, ?it looks like you are the Fedora distro developer working
>> > > on ?both ?fltk2 ?and ?dillo2, ?so in this case you can decide and
>> > > suggest what looks best from your point of view.
>> > >
>> > > ?From ?a user perspective, it looks simpler to download a single
>> > > binary ?and ?install it. If the shared way is decided, we need to
>> > > provide nutshell directions.
>> > >
>> > > ?In ?the ?Debian ?case, I assume a statically linked deb will be
>> > > produced (until the license problem is solved).
>> > Yes, I preparated an FLTK2 Debian package and it is built as static
>> > lib but this should be avoided if possible, the problem is that fltk2
>> > isn't stable enough so ATM it is static... The Debian license is the
>> > issue that doesn't allow me to upload the fltk2 ?(and also dillo2)
>> > package in Debian, there is an open bug about this
>> > (http://www.fltk.org/str.php?L2198+P0+S-2+C0+I0+E0+Qlicense).
>>
>> ? OK.
>>
>> ? BTW, the rc2 version of dillo-2.1 (hopefully final) was
>> just uploaded to http://www.dillo.org/download/ so packagers
>> can make the respective files.
>>
>> ? The idea is to make the announcement tomorrow in the morning.
>>
>> ? Devid: please send me the .deb and its directions when done.
>>
>> ? Same for rpm.
>
> ?Last but not the least.
>
> ?I use "./configure --enable-ssl" bacause that way dillo is much
> more ?useful (mainly for reading forums and bug trackers). So I'd
> suggest ?to ?make ?the packages with SSL enabled, unless somebody
> reembers a compelling reason not to do so.
>
> ?There're ?times ?when ?the ?certificate asking dialog bombs the
> user, ?but maybe not so often, or annoyingly enough, to avoid the
> SSL dpi.
>
> ?Comments?
>

Generally speaking for Fedora, we won't turn on options which are not
turned on by default in upstream - it usually brings divergence from
upstream and comments in upstream mailing lists (not this one :) )
like: "That poor distroX turned on --enable-coolness so we are not
supporting users of this distro at all."

Turning on SSL in upstream means more pressure for fixing it, usually
:). But I am reading dillo-dev long enough to know it's not that easy.

>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From corvid at lavabit.com  Thu Jun 18 16:43:31 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun 18 16:46:30 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906180127q9994cd4gc60d5bf8a4dfbb67@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<5e9a80350906180127q9994cd4gc60d5bf8a4dfbb67@mail.gmail.com>
Message-ID: <20090618144331.GL8031@local.gobigwest.com>

Michal wrote:
> I understand that my proposal won't be popular but switching from
> FLTK2 is necessary - we hardly have FLTK2 in distributions (read: no
> Dillo-2 in distribution) and that's shortening our user base.
> 
> How hard it would be to rewrite/port Dillo-2 to FLTK-1.3?
> 
> (I see that the speed of v1.3 development is nothing exciting, but
> from what I read months ago they at least plan to have a release
> ever.)
> 
> While looking at the devel cycle of Dillo - two releases per year -
> I believe this porting should be mid-term goal. Unless we wanna
> spend another year out of mainstream distributions. (And frankly:
> even with Dillo-2 based on FLTK-1.3 we are quite far from Dillo-2
> in distribution...)

It seems to be the consensus that going to 1.3 will happen eventually.

They still have some work on UTF-8 to do first:
  http://svn.easysw.com/public/fltk/fltk/branches/branch-1.3/TODO.utf8

Out of curiosity, I once made a dillo that compiled with 1.3.
It failed to work at all because I don't know the fltk and dw code
well enough in general, but I was satisfied with getting an idea
of how much there was to it.
- We would have to get Johannes to do dw/fltkview*.
- Fonts are a bit different. I didn't dig into that.
- Menus are a bit different. Didn't dig into that either.
- The PackedGroup for the UI behaved differently. I fought
  with it for a little while, then grew impatient.
The rest was mostly changing a whole lot of fltk::something to Fl_something.



From kelson at pobox.com  Thu Jun 18 18:05:34 2009
From: kelson at pobox.com (Kelson Vibber)
Date: Thu Jun 18 18:06:14 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090618025442.GH10602@dillo.org>
References: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org> <20090616211822.GB5061@assam.Belkin>
	<4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<20090617230916.GI8031@local.gobigwest.com>
	<20090618025442.GH10602@dillo.org>
Message-ID: <D327A817-6C7E-44B1-BB2D-65EB75A2DF68@pobox.com>


On Jun 17, 2009, at 7:54 PM, Jorge Arellano Cid wrote:
>  Well in that case, I assume that no SSL as default is OK.

So...no SSL for the official packages? I'll redo them.

On that front, I haven't been able to get a Fedora 10 x86 LiveCD setup  
to install all the build requirements - it keeps crashing with I/O  
errors.  I've been trying to set up a USB stick system, but it's the  
first time I've tried it and things don't seem to be working right.

I've got the folowing:
Fedora 10 x86_64
RHEL 3 i386
RHEL 4 x86_64
RHEL 5 i386
RHEL 5 x86_64

If anyone wants to try to build a matching RPM on Fedora 10 i686,  
here's the URLs to the sources...

http://www.hyperborea.org/software/dillo/rpms/dillo-2.1-2.src.rpm (-3  
once I turn SSL off again)
http://www.hyperborea.org/software/dillo/rpms/fltk2-2.0.x.r6403-0.2.src.rpm

And here's the list of build requirements I've found so far that  
aren't on the LiveCD

yum install rpm-build openssl-devel gcc make automake automake17  
automake16 automake15 libjpeg-devel libpng-devel zlib-devel xorg-x11- 
proto-devel libXft-devel libSM-devel libICE-devel libXt-devel libX11- 
devel libXi-devel libXinerama-devel libGL-devel libGLU-devel libXext- 
devel gcc-c++


From corvid at lavabit.com  Thu Jun 18 18:11:12 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun 18 18:14:09 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <D327A817-6C7E-44B1-BB2D-65EB75A2DF68@pobox.com>
References: <20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<20090617230916.GI8031@local.gobigwest.com>
	<20090618025442.GH10602@dillo.org>
	<D327A817-6C7E-44B1-BB2D-65EB75A2DF68@pobox.com>
Message-ID: <20090618161112.GN8031@local.gobigwest.com>

Kelson wrote:
> http://www.hyperborea.org/software/dillo/rpms/fltk2-2.0.x.r6403-0.2.src.rpm

We should use >= 6525



From jcid at dillo.org  Thu Jun 18 18:44:50 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 18:45:03 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
Message-ID: <20090618164450.GA3635@dillo.org>

On Thu, Jun 18, 2009 at 05:24:25PM +0200, Devid Antonio Filoni wrote:
> On Wed, Jun 17, 2009 at 11:45 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > [...]
> > ?BTW, the rc2 version of dillo-2.1 (hopefully final) was
> > just uploaded to http://www.dillo.org/download/ so packagers
> > can make the respective files.
> >
> > ?The idea is to make the announcement tomorrow in the morning.
> >
> > ?Devid: please send me the .deb and its directions when done.
> DONE! You can find it at https://launchpad.net/~d.filoni/+archive/ppa
> . However I found an error checking my package using lintian:
> 
> E: dillo: possible-gpl-code-linked-with-openssl
> N:
> N:    This package appears to be covered by the GNU GPL but depends on the
> N:    OpenSSL libssl package and does not mention a license exemption or
> N:    exception for OpenSSL in its copyright file. The GPL (including version
> N:    3) is incompatible with some terms of the OpenSSL license, and therefore
> N:    Debian does not allow GPL-licensed code linked with OpenSSL libraries
> N:    unless there is a license exception explicitly permitting this.
> N:
> N:    If only the Debian packaging, or some other part of the package not
> N:    linked with OpenSSL, is covered by the GNU GPL, please add a lintian
> N:    override for this tag. Lintian currently has no good way of
> N:    distinguishing between that case and problematic packages.
> N:
> N:    Severity: serious, Certainty: wild-guess
> 
> Can you please fix it?

  OK guys, don't hurry!

    ----------------------------------------------------
    Let's make the announcement early this Saturday  20.
    ----------------------------------------------------

  That  way  we  have  until  tomorrow  to sort out the packaging
problem and this license issue.

  I'd proceed in this order:

    1.- Solve the OpenSSL license issue and upload rc3.
    2.- To enable-ssl or not enable-ssl (define what to do).
    3.- Get to the less painful package-system for the user given the
        current situation.
        (most probably distribution repositories)
    4.- Future planning: how to get dillo2 into distros to enlarge
        its user base.
        FLTK2 vs FLTK-1.3 
          * I have plenty of info here, but will hold on until the
            previous points are done.


  Thanks for all the help.


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Thu Jun 18 18:57:00 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 18:57:12 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
Message-ID: <20090618165700.GB3635@dillo.org>

Hi,

  Working on:

     1.- Solve the OpenSSL license issue and upload rc3.


On Thu, Jun 18, 2009 at 05:24:25PM +0200, Devid Antonio Filoni wrote:
> On Wed, Jun 17, 2009 at 11:45 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
> > [...]
> > ?Devid: please send me the .deb and its directions when done.
> DONE! You can find it at https://launchpad.net/~d.filoni/+archive/ppa
> . However I found an error checking my package using lintian:
> 
> E: dillo: possible-gpl-code-linked-with-openssl
> N:
> N:    This package appears to be covered by the GNU GPL but depends on the
> N:    OpenSSL libssl package and does not mention a license exemption or
> N:    exception for OpenSSL in its copyright file. The GPL (including version
> N:    3) is incompatible with some terms of the OpenSSL license, and therefore
> N:    Debian does not allow GPL-licensed code linked with OpenSSL libraries
> N:    unless there is a license exception explicitly permitting this.
> N:
> N:    If only the Debian packaging, or some other part of the package not
> N:    linked with OpenSSL, is covered by the GNU GPL, please add a lintian
> N:    override for this tag. Lintian currently has no good way of
> N:    distinguishing between that case and problematic packages.
> N:
> N:    Severity: serious, Certainty: wild-guess
> 
> Can you please fix it?

  AFAIS, the only program that links to OpenSSL is the https dpi.
i.e. The ssl-enabled dillo binary doesn't link to it.
     https.filter.dpi links to it.

  IANAL, but it looks like giving permission for this dpi is enough,
and it's already done in its sources (dpi/https.c):

 * [...]
 * As a special exception permission is granted to link the code of
 * the https dillo plugin with the OpenSSL project's "OpenSSL"
 * library, and distribute the linked executables, without including
 * the source code for OpenSSL in the source distribution. You must
 * obey the GNU General Public License, version 3, in all respects
 * for all of the code used other than "OpenSSL".
 *
 */


  Please let me know if this is _really_ enough or if some extra
legal formula must be added somewhere else.

  TIA.

-- 
  Cheers
  Jorge.-

From kelson at pobox.com  Thu Jun 18 19:15:58 2009
From: kelson at pobox.com (Kelson Vibber)
Date: Thu Jun 18 19:17:01 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090618161112.GN8031@local.gobigwest.com>
References: <20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<20090617230916.GI8031@local.gobigwest.com>
	<20090618025442.GH10602@dillo.org>
	<D327A817-6C7E-44B1-BB2D-65EB75A2DF68@pobox.com>
	<20090618161112.GN8031@local.gobigwest.com>
Message-ID: <4A3A764E.1070401@pobox.com>

corvid wrote:
> Kelson wrote:
>> http://www.hyperborea.org/software/dillo/rpms/fltk2-2.0.x.r6403-0.2.src.rpm
> 
> We should use >= 6525

Oops!  Wrong link!  That's what I used to build the 2.0 packages last 
October.

I meant this one:
http://www.hyperborea.org/software/dillo/rpms/fltk2-2.0.x.r6786-0.1.src.rpm

-- 
Kelson Vibber
Hyperborea.org - SpeedForce.org

From devidfil at gmail.com  Thu Jun 18 21:01:39 2009
From: devidfil at gmail.com (Devid Antonio Filoni)
Date: Thu Jun 18 21:02:32 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090618165700.GB3635@dillo.org>
References: <20090616180954.GD4239@dillo.org> <20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
	<20090618165700.GB3635@dillo.org>
Message-ID: <64a208ca0906181201u4bdea1f5n32bb224f4fa92789@mail.gmail.com>

On Thu, Jun 18, 2009 at 6:57 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> Hi,
>
> ?Working on:
>
> ? ? 1.- Solve the OpenSSL license issue and upload rc3.
>
>
> On Thu, Jun 18, 2009 at 05:24:25PM +0200, Devid Antonio Filoni wrote:
>> On Wed, Jun 17, 2009 at 11:45 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
>> > On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
>> > [...]
>> > ?Devid: please send me the .deb and its directions when done.
>> DONE! You can find it at https://launchpad.net/~d.filoni/+archive/ppa
>> . However I found an error checking my package using lintian:
>>
>> E: dillo: possible-gpl-code-linked-with-openssl
>> N:
>> N: ? ?This package appears to be covered by the GNU GPL but depends on the
>> N: ? ?OpenSSL libssl package and does not mention a license exemption or
>> N: ? ?exception for OpenSSL in its copyright file. The GPL (including version
>> N: ? ?3) is incompatible with some terms of the OpenSSL license, and therefore
>> N: ? ?Debian does not allow GPL-licensed code linked with OpenSSL libraries
>> N: ? ?unless there is a license exception explicitly permitting this.
>> N:
>> N: ? ?If only the Debian packaging, or some other part of the package not
>> N: ? ?linked with OpenSSL, is covered by the GNU GPL, please add a lintian
>> N: ? ?override for this tag. Lintian currently has no good way of
>> N: ? ?distinguishing between that case and problematic packages.
>> N:
>> N: ? ?Severity: serious, Certainty: wild-guess
>>
>> Can you please fix it?
>
> ?AFAIS, the only program that links to OpenSSL is the https dpi.
> i.e. The ssl-enabled dillo binary doesn't link to it.
> ? ? https.filter.dpi links to it.
>
> ?IANAL, but it looks like giving permission for this dpi is enough,
> and it's already done in its sources (dpi/https.c):
>
> ?* [...]
> ?* As a special exception permission is granted to link the code of
> ?* the https dillo plugin with the OpenSSL project's "OpenSSL"
> ?* library, and distribute the linked executables, without including
> ?* the source code for OpenSSL in the source distribution. You must
> ?* obey the GNU General Public License, version 3, in all respects
> ?* for all of the code used other than "OpenSSL".
> ?*
> ?*/
>
>
> ?Please let me know if this is _really_ enough or if some extra
> legal formula must be added somewhere else.
It should be enough, at least this is what I see for example at
http://lists.octality.com/pipermail/cherokee/2008-November/009408.html
(take a look in that page for more infos)
> ?TIA.
>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

Devid

From jcid at dillo.org  Thu Jun 18 21:28:26 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 21:28:41 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906181201u4bdea1f5n32bb224f4fa92789@mail.gmail.com>
References: <20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<64a208ca0906180824paa02ee6u425a3220da58108c@mail.gmail.com>
	<20090618165700.GB3635@dillo.org>
	<64a208ca0906181201u4bdea1f5n32bb224f4fa92789@mail.gmail.com>
Message-ID: <20090618192826.GC3626@dillo.org>

On Thu, Jun 18, 2009 at 09:01:39PM +0200, Devid Antonio Filoni wrote:
> On Thu, Jun 18, 2009 at 6:57 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > Hi,
> >
> > ?Working on:
> >
> > ? ? 1.- Solve the OpenSSL license issue and upload rc3.
> >
> >
> > On Thu, Jun 18, 2009 at 05:24:25PM +0200, Devid Antonio Filoni wrote:
> >> On Wed, Jun 17, 2009 at 11:45 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> >> > On Wed, Jun 17, 2009 at 10:01:12PM +0200, Devid Antonio Filoni wrote:
> >> > [...]
> >> > ?Devid: please send me the .deb and its directions when done.
> >> DONE! You can find it at https://launchpad.net/~d.filoni/+archive/ppa
> >> . However I found an error checking my package using lintian:
> >>
> >> E: dillo: possible-gpl-code-linked-with-openssl
> >> N:
> >> N: ? ?This package appears to be covered by the GNU GPL but depends on the
> >> N: ? ?OpenSSL libssl package and does not mention a license exemption or
> >> N: ? ?exception for OpenSSL in its copyright file. The GPL (including version
> >> N: ? ?3) is incompatible with some terms of the OpenSSL license, and therefore
> >> N: ? ?Debian does not allow GPL-licensed code linked with OpenSSL libraries
> >> N: ? ?unless there is a license exception explicitly permitting this.
> >> N:
> >> N: ? ?If only the Debian packaging, or some other part of the package not
> >> N: ? ?linked with OpenSSL, is covered by the GNU GPL, please add a lintian
> >> N: ? ?override for this tag. Lintian currently has no good way of
> >> N: ? ?distinguishing between that case and problematic packages.
> >> N:
> >> N: ? ?Severity: serious, Certainty: wild-guess
> >>
> >> Can you please fix it?
> >
> > ?AFAIS, the only program that links to OpenSSL is the https dpi.
> > i.e. The ssl-enabled dillo binary doesn't link to it.
> > ? ? https.filter.dpi links to it.
> >
> > ?IANAL, but it looks like giving permission for this dpi is enough,
> > and it's already done in its sources (dpi/https.c):
> >
> > ?* [...]
> > ?* As a special exception permission is granted to link the code of
> > ?* the https dillo plugin with the OpenSSL project's "OpenSSL"
> > ?* library, and distribute the linked executables, without including
> > ?* the source code for OpenSSL in the source distribution. You must
> > ?* obey the GNU General Public License, version 3, in all respects
> > ?* for all of the code used other than "OpenSSL".
> > ?*
> > ?*/
> >
> >
> > ?Please let me know if this is _really_ enough or if some extra
> > legal formula must be added somewhere else.
> It should be enough, at least this is what I see for example at
> http://lists.octality.com/pipermail/cherokee/2008-November/009408.html
> (take a look in that page for more infos)

  Good!

  After reading it and the suggested URLs, especially [1],
it looks like our current tarball (rc2) is enough. No new tarball
is needed!

  I consider this point solved, so let's move to the second one...


[1] http://www.openssl.org/support/faq.html#LEGAL2


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Thu Jun 18 21:56:29 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 18 21:56:50 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
References: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
Message-ID: <20090618195629.GD3626@dillo.org>

Hi,

  Working on

    2.- To enable-ssl or not enable-ssl (define what to do).


On Thu, Jun 18, 2009 at 10:36:39AM +0200, Michal Nowak wrote:
> [...]
> Generally speaking for Fedora, we won't turn on options which are not
> turned on by default in upstream - it usually brings divergence from
> upstream and comments in upstream mailing lists (not this one :) )
> like: "That poor distroX turned on --enable-coolness so we are not
> supporting users of this distro at all."
> 
> Turning on SSL in upstream means more pressure for fixing it, usually
> :). But I am reading dillo-dev long enough to know it's not that easy.

  Reading  forums  served on https is handy, so I understand if a
user wants to have it enabled.

  Considering  that  making  a  user compile dillo is currently a
complex  operation  (the apparently simple --enable-ssl switch is
complex because of FLTK2 installation issues), I'd try to provide
the  packaged  option  as an alternative to the main package (not
SSL-enabled).

  Something like:

  ---------------------------------------------------------------
  Debian:

     Jaunty, Karmic (click here)

  Fedora:

     F11, F12 (click here)

  ---------------------------------------------------------------
  With alpha HTTPS support:
     * Note that this is NOT checking certificates, may get stuck
  in asking dialogs, but will let you read https forums.

                       USE AT YOUR OWN RISK

  Debian:

     Jaunty, Karmic (click here)

  Fedora:

     F11, F12 (click here)
  ---------------------------------------------------------------



  Obviously the safe option is not to offer ssl-enabled packages,
but that will mainly have the effect of no https-dpi at all.

  I'm not quite sure which one would be best.
  Comments?


-- 
  Cheers
  Jorge.-

From devidfil at gmail.com  Thu Jun 18 23:12:12 2009
From: devidfil at gmail.com (Devid Antonio Filoni)
Date: Thu Jun 18 23:13:06 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090618195629.GD3626@dillo.org>
References: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
Message-ID: <64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>

In Debian, the package in the repo is built with ssl enabled, I prefer
to have the new package with ssl too. Is possible to just show a
warning opening dillo?

Devid

On 6/18/09, Jorge Arellano Cid <jcid@dillo.org> wrote:
> Hi,
>
>   Working on
>
>     2.- To enable-ssl or not enable-ssl (define what to do).
>
>
> On Thu, Jun 18, 2009 at 10:36:39AM +0200, Michal Nowak wrote:
>> [...]
>> Generally speaking for Fedora, we won't turn on options which are not
>> turned on by default in upstream - it usually brings divergence from
>> upstream and comments in upstream mailing lists (not this one :) )
>> like: "That poor distroX turned on --enable-coolness so we are not
>> supporting users of this distro at all."
>>
>> Turning on SSL in upstream means more pressure for fixing it, usually
>> :). But I am reading dillo-dev long enough to know it's not that easy.
>
>   Reading  forums  served on https is handy, so I understand if a
> user wants to have it enabled.
>
>   Considering  that  making  a  user compile dillo is currently a
> complex  operation  (the apparently simple --enable-ssl switch is
> complex because of FLTK2 installation issues), I'd try to provide
> the  packaged  option  as an alternative to the main package (not
> SSL-enabled).
>
>   Something like:
>
>   ---------------------------------------------------------------
>   Debian:
>
>      Jaunty, Karmic (click here)
>
>   Fedora:
>
>      F11, F12 (click here)
>
>   ---------------------------------------------------------------
>   With alpha HTTPS support:
>      * Note that this is NOT checking certificates, may get stuck
>   in asking dialogs, but will let you read https forums.
>
>                        USE AT YOUR OWN RISK
>
>   Debian:
>
>      Jaunty, Karmic (click here)
>
>   Fedora:
>
>      F11, F12 (click here)
>   ---------------------------------------------------------------
>
>
>
>   Obviously the safe option is not to offer ssl-enabled packages,
> but that will mainly have the effect of no https-dpi at all.
>
>   I'm not quite sure which one would be best.
>   Comments?
>
>
> --
>   Cheers
>   Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From newman.x at gmail.com  Thu Jun 18 23:20:51 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Thu Jun 18 23:21:45 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090618195629.GD3626@dillo.org>
References: <64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
Message-ID: <5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>

On Thu, Jun 18, 2009 at 9:56 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> Hi,
>
> ?Working on
>
> ? ?2.- To enable-ssl or not enable-ssl (define what to do).
>
>
> On Thu, Jun 18, 2009 at 10:36:39AM +0200, Michal Nowak wrote:
>> [...]
>> Generally speaking for Fedora, we won't turn on options which are not
>> turned on by default in upstream - it usually brings divergence from
>> upstream and comments in upstream mailing lists (not this one :) )
>> like: "That poor distroX turned on --enable-coolness so we are not
>> supporting users of this distro at all."
>>
>> Turning on SSL in upstream means more pressure for fixing it, usually
>> :). But I am reading dillo-dev long enough to know it's not that easy.

[snip]

>
> ?Obviously the safe option is not to offer ssl-enabled packages,
> but that will mainly have the effect of no https-dpi at all.
>
> ?I'm not quite sure which one would be best.
> ?Comments?

http://mnowak.fedorapeople.org/dillo2/static/

Looks like Kelson's having some problems with building, so I
patched-rebuilt-installed Kelson's static FLTK2 SRPM and rebuilt
Dillo2. Now there are present i586 pkgs for F-11, both SSL on/off,
tomorrow I can build x86-64 pkgs for F-11 at work. And i386
packs for F-10 (hopefully there's still the F-10 beast in KVM).

(But treat them as third party ones, don't trust them :). )

>
>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From jcid at dillo.org  Fri Jun 19 04:23:48 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Fri Jun 19 04:24:04 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
References: <20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
Message-ID: <20090619022348.GF8013@dillo.org>

On Thu, Jun 18, 2009 at 11:12:12PM +0200, Devid Antonio Filoni wrote:
> In Debian, the package in the repo is built with ssl enabled, I prefer
> to have the new package with ssl too. Is possible to just show a
> warning opening dillo?

  Yes it is.

  You can add a warning in the splash page with HTML.
Just try making some changes in IO/about.c

  See the attached page as an example.

  I'd prefer to have both and to offer as an option from the
download page (as with Fedora).

  WARNING: Please don't make the packages yet, I've got a last minute
security vulnerability email, so maybe the tarball will change
once more (the last). I'll try to have this solved tomorrow in the
morning.


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Fri Jun 19 04:29:06 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Fri Jun 19 04:29:20 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
References: <20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
Message-ID: <20090619022906.GG8013@dillo.org>

On Thu, Jun 18, 2009 at 11:20:51PM +0200, Michal Nowak wrote:
> On Thu, Jun 18, 2009 at 9:56 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > Hi,
> >
> > ?Working on
> >
> > ? ?2.- To enable-ssl or not enable-ssl (define what to do).
> >
> >
> > On Thu, Jun 18, 2009 at 10:36:39AM +0200, Michal Nowak wrote:
> >> [...]
> >> Generally speaking for Fedora, we won't turn on options which are not
> >> turned on by default in upstream - it usually brings divergence from
> >> upstream and comments in upstream mailing lists (not this one :) )
> >> like: "That poor distroX turned on --enable-coolness so we are not
> >> supporting users of this distro at all."
> >>
> >> Turning on SSL in upstream means more pressure for fixing it, usually
> >> :). But I am reading dillo-dev long enough to know it's not that easy.
> 
> [snip]
> 
> >
> > ?Obviously the safe option is not to offer ssl-enabled packages,
> > but that will mainly have the effect of no https-dpi at all.
> >
> > ?I'm not quite sure which one would be best.
> > ?Comments?
> 
> http://mnowak.fedorapeople.org/dillo2/static/

  Good!

> Looks like Kelson's having some problems with building, so I
> patched-rebuilt-installed Kelson's static FLTK2 SRPM and rebuilt
> Dillo2. Now there are present i586 pkgs for F-11, both SSL on/off,

  BTW, is there a special instruction to install them on RPM
systems? I mean something like adding a line to /etc/apt/sources.list
in Debian.


> tomorrow I can build x86-64 pkgs for F-11 at work. And i386
> packs for F-10 (hopefully there's still the F-10 beast in KVM).


  WARNING: Please don't make the packages yet, I've got a last minute
security vulnerability email, so maybe the tarball will change
once more (the last). I'll try to have this solved tomorrow in the
morning.


> (But treat them as third party ones, don't trust them :). )

  What do you mean?

-- 
  Cheers
  Jorge.-

From kelson at pobox.com  Fri Jun 19 04:43:15 2009
From: kelson at pobox.com (Kelson Vibber)
Date: Fri Jun 19 04:44:19 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619022348.GF8013@dillo.org>
References: <20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
	<20090619022348.GF8013@dillo.org>
Message-ID: <F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>

On Jun 18, 2009, at 7:23 PM, Jorge Arellano Cid wrote:
> I'd prefer to have both and to offer as an option from the
> download page (as with Fedora).

So just to confirm, two dillo packages per OS version / architecture  
combination, one compiled with SSL, one compiled without?

>  WARNING: Please don't make the packages yet, I've got a last minute
> security vulnerability email, so maybe the tarball will change
> once more (the last). I'll try to have this solved tomorrow in the
> morning.

Okay, I'll wait until tomorrow before building anything else.

The good news is I finally got Fedora 10 i686 running from a USB key,  
and was able to build the current package!

So tomorrow I'll be able to build:
Fedora 10 i686 and x86_64
RHEL 3 i386
RHEL 4 x86_64
RHEL 5 i686 and x86_64


From jcid at dillo.org  Fri Jun 19 04:55:14 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Fri Jun 19 04:55:28 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
	<20090619022348.GF8013@dillo.org>
	<F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>
Message-ID: <20090619025514.GH8013@dillo.org>

On Thu, Jun 18, 2009 at 07:43:15PM -0700, Kelson Vibber wrote:
> On Jun 18, 2009, at 7:23 PM, Jorge Arellano Cid wrote:
>> I'd prefer to have both and to offer as an option from the
>> download page (as with Fedora).
>
> So just to confirm, two dillo packages per OS version / architecture  
> combination, one compiled with SSL, one compiled without?

  That's the idea. Starting with the most used ones.


>>  WARNING: Please don't make the packages yet, I've got a last minute
>> security vulnerability email, so maybe the tarball will change
>> once more (the last). I'll try to have this solved tomorrow in the
>> morning.
>
> Okay, I'll wait until tomorrow before building anything else.
>
> The good news is I finally got Fedora 10 i686 running from a USB key,  
> and was able to build the current package!
>
> So tomorrow I'll be able to build:
> Fedora 10 i686 and x86_64
> RHEL 3 i386
> RHEL 4 x86_64
> RHEL 5 i686 and x86_64

  BTW, which is the easier way to install an rpm?
Just download and "rpm -ivh <PKG>" or is there a ppa-like thing?

-- 
  Cheers
  Jorge.-

From newman.x at gmail.com  Fri Jun 19 10:00:30 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Fri Jun 19 10:00:54 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619025514.GH8013@dillo.org>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
	<20090619022348.GF8013@dillo.org>
	<F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>
	<20090619025514.GH8013@dillo.org>
Message-ID: <5e9a80350906190100s37c79426iac3e2d455584adf7@mail.gmail.com>

On Fri, Jun 19, 2009 at 4:55 AM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> On Thu, Jun 18, 2009 at 07:43:15PM -0700, Kelson Vibber wrote:
>> On Jun 18, 2009, at 7:23 PM, Jorge Arellano Cid wrote:
>>> I'd prefer to have both and to offer as an option from the
>>> download page (as with Fedora).
>>
>> So just to confirm, two dillo packages per OS version / architecture
>> combination, one compiled with SSL, one compiled without?
>
> ?That's the idea. Starting with the most used ones.
>
>
>>> ?WARNING: Please don't make the packages yet, I've got a last minute
>>> security vulnerability email, so maybe the tarball will change
>>> once more (the last). I'll try to have this solved tomorrow in the
>>> morning.
>>
>> Okay, I'll wait until tomorrow before building anything else.
>>
>> The good news is I finally got Fedora 10 i686 running from a USB key,
>> and was able to build the current package!
>>
>> So tomorrow I'll be able to build:
>> Fedora 10 i686 and x86_64
>> RHEL 3 i386
>> RHEL 4 x86_64
>> RHEL 5 i686 and x86_64
>
> ?BTW, which is the easier way to install an rpm?
> Just download and "rpm -ivh <PKG>" or is there a ppa-like thing?
>

It's not that hard to create a repository with RPM packages but as I said
it's generally bad thing to encourage users to use this as "repository", they
would expect the same service like from general distribution distro
(e.g. security fixes), which we don't wanna provide - because we believe
Dillo2 in official distribution is The way.

The `rpm -ivh <pkg>` is easy enough, I believe.

> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From newman.x at gmail.com  Fri Jun 19 10:02:19 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Fri Jun 19 10:02:43 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>
References: <20090616211822.GB5061@assam.Belkin>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<64a208ca0906181412g110476e1jeaa8b7141a7df023@mail.gmail.com>
	<20090619022348.GF8013@dillo.org>
	<F58C9871-C5B4-4CBB-AB46-84CE386F9526@pobox.com>
Message-ID: <5e9a80350906190102w70416f76m1208fcdf35273547@mail.gmail.com>

On Fri, Jun 19, 2009 at 4:43 AM, Kelson Vibber<kelson@pobox.com> wrote:
> On Jun 18, 2009, at 7:23 PM, Jorge Arellano Cid wrote:
>>
>> I'd prefer to have both and to offer as an option from the
>> download page (as with Fedora).
>
> So just to confirm, two dillo packages per OS version / architecture
> combination, one compiled with SSL, one compiled without?
>
>> ?WARNING: Please don't make the packages yet, I've got a last minute
>> security vulnerability email, so maybe the tarball will change
>> once more (the last). I'll try to have this solved tomorrow in the
>> morning.
>
> Okay, I'll wait until tomorrow before building anything else.
>
> The good news is I finally got Fedora 10 i686 running from a USB key, and
> was able to build the current package!
>
> So tomorrow I'll be able to build:
> Fedora 10 i686 and x86_64
> RHEL 3 i386
> RHEL 4 x86_64
> RHEL 5 i686 and x86_64

Just a comment: I'll be out for the whole weekend, if there's demand for
Fedora 11 packages I'll create them Sunday evening or Monday morning.

>
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From newman.x at gmail.com  Fri Jun 19 10:07:37 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Fri Jun 19 10:08:00 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619022906.GG8013@dillo.org>
References: <20090616211822.GB5061@assam.Belkin>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org>
Message-ID: <5e9a80350906190107p6b143bc8nebeb9209ab77a510@mail.gmail.com>

On Fri, Jun 19, 2009 at 4:29 AM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> On Thu, Jun 18, 2009 at 11:20:51PM +0200, Michal Nowak wrote:
>> On Thu, Jun 18, 2009 at 9:56 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
>> > Hi,
>> >
>> > ?Working on
>> >
>> > ? ?2.- To enable-ssl or not enable-ssl (define what to do).
>> >
>> >
>> > On Thu, Jun 18, 2009 at 10:36:39AM +0200, Michal Nowak wrote:
>> >> [...]
>> >> Generally speaking for Fedora, we won't turn on options which are not
>> >> turned on by default in upstream - it usually brings divergence from
>> >> upstream and comments in upstream mailing lists (not this one :) )
>> >> like: "That poor distroX turned on --enable-coolness so we are not
>> >> supporting users of this distro at all."
>> >>
>> >> Turning on SSL in upstream means more pressure for fixing it, usually
>> >> :). But I am reading dillo-dev long enough to know it's not that easy.
>>
>> [snip]
>>
>> >
>> > ?Obviously the safe option is not to offer ssl-enabled packages,
>> > but that will mainly have the effect of no https-dpi at all.
>> >
>> > ?I'm not quite sure which one would be best.
>> > ?Comments?
>>
>> http://mnowak.fedorapeople.org/dillo2/static/
>
> ?Good!
>
>> Looks like Kelson's having some problems with building, so I
>> patched-rebuilt-installed Kelson's static FLTK2 SRPM and rebuilt
>> Dillo2. Now there are present i586 pkgs for F-11, both SSL on/off,
>
> ?BTW, is there a special instruction to install them on RPM
> systems? I mean something like adding a line to /etc/apt/sources.list
> in Debian.
>
>
>> tomorrow I can build x86-64 pkgs for F-11 at work. And i386
>> packs for F-10 (hopefully there's still the F-10 beast in KVM).
>
>
> ?WARNING: Please don't make the packages yet, I've got a last minute
> security vulnerability email, so maybe the tarball will change
> once more (the last). I'll try to have this solved tomorrow in the
> morning.
>
>
>> (But treat them as third party ones, don't trust them :). )
>
> ?What do you mean?

The point was that the packages are not signed, nor verified by
independent authority [1]: just wanna to ask you *not* have the
packages in the dillo.org web page directly but only as a separate
link to third party directory/repository.
--
[1] Just created by me with the best effort.

>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From jcid at dillo.org  Fri Jun 19 19:44:52 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Fri Jun 19 19:45:07 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619022906.GG8013@dillo.org>
References: <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org>
Message-ID: <20090619174452.GA7648@dillo.org>

On Thu, Jun 18, 2009 at 10:29:06PM -0400, Jorge Arellano Cid wrote:
> [...]
>   WARNING: Please don't make the packages yet, I've got a last minute
> security vulnerability email, so maybe the tarball will change
> once more (the last). I'll try to have this solved tomorrow in the
> morning.

  OK, the last tarball was just uploaded (rc3) and it will
be announced tomorrow in the morning. It has a patch
for malformed PNG images.

  Please make the respective packages and let me know
when ready to link them from the downloads page.

  Here we go!

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Sat Jun 20 01:20:35 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 20 01:20:50 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619174452.GA7648@dillo.org>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
Message-ID: <20090619232035.GC26421@dillo.org>

On Fri, Jun 19, 2009 at 01:44:52PM -0400, Jorge Arellano Cid wrote:
> On Thu, Jun 18, 2009 at 10:29:06PM -0400, Jorge Arellano Cid wrote:
> > [...]
> >   WARNING: Please don't make the packages yet, I've got a last minute
> > security vulnerability email, so maybe the tarball will change
> > once more (the last). I'll try to have this solved tomorrow in the
> > morning.
> 
>   OK, the last tarball was just uploaded (rc3) and it will
> be announced tomorrow in the morning. It has a patch
> for malformed PNG images.
> 
>   Please make the respective packages and let me know
> when ready to link them from the downloads page.

  BTW, the announcement will be on Saturday 20's morning
(UTC - 4). So there's still some time to finish the packages.
Please make sure you have the last tarball by checking the
signature, and let me know to update the linking page.

  TIA.

-- 
  Cheers
  Jorge.-

From kelson at pobox.com  Sat Jun 20 08:03:15 2009
From: kelson at pobox.com (Kelson Vibber)
Date: Sat Jun 20 08:03:50 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619232035.GC26421@dillo.org>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org>
Message-ID: <96D8179E-0BD1-44AA-9E66-5C9DBF5B4C9E@pobox.com>

>  BTW, the announcement will be on Saturday 20's morning
> (UTC - 4). So there's still some time to finish the packages.
> Please make sure you have the last tarball by checking the
> signature, and let me know to update the linking page.

Sorry, I got mixed up over the timezone, or I would have posted the  
packages that were ready earlier instead of waiting until they were  
all done.

I have RPMS for both Fedora 10 (both 32 and 64-bit), RHEL 3 (32bit),  
RHEL4 (64bit) and RHEL5 (32 and 64 bit), with and without SSL except  
for RHEL3.

Location:
http://www.hyperborea.org/software/dillo/

From devidfil at gmail.com  Sat Jun 20 14:56:22 2009
From: devidfil at gmail.com (Devid Antonio Filoni)
Date: Sat Jun 20 14:57:15 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <96D8179E-0BD1-44AA-9E66-5C9DBF5B4C9E@pobox.com>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org>
	<96D8179E-0BD1-44AA-9E66-5C9DBF5B4C9E@pobox.com>
Message-ID: <64a208ca0906200556gfa645a4ke542a340db37c792@mail.gmail.com>

On Sat, Jun 20, 2009 at 8:03 AM, Kelson Vibber<kelson@pobox.com> wrote:
>> ?BTW, the announcement will be on Saturday 20's morning
>> (UTC - 4). So there's still some time to finish the packages.
>> Please make sure you have the last tarball by checking the
>> signature, and let me know to update the linking page.
>
> Sorry, I got mixed up over the timezone, or I would have posted the packages
> that were ready earlier instead of waiting until they were all done.
>
> I have RPMS for both Fedora 10 (both 32 and 64-bit), RHEL 3 (32bit), RHEL4
> (64bit) and RHEL5 (32 and 64 bit), with and without SSL except for RHEL3.
>
> Location:
> http://www.hyperborea.org/software/dillo/

Sorry for the delay, my internet connection sucks, however you can
find the Debian packages at the following links:
Dillo: https://launchpad.net/~d.filoni/+archive/dillo
Dillo+SSL:  https://launchpad.net/~d.filoni/+archive/dillo+ssl

Devid
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

From sas at 321.hu  Sat Jun 20 15:22:39 2009
From: sas at 321.hu (=?ISO-8859-1?Q?SZERV=C1C_Attila?=)
Date: Sat Jun 20 15:23:32 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <64a208ca0906200556gfa645a4ke542a340db37c792@mail.gmail.com>
References: <5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org>
	<96D8179E-0BD1-44AA-9E66-5C9DBF5B4C9E@pobox.com>
	<64a208ca0906200556gfa645a4ke542a340db37c792@mail.gmail.com>
Message-ID: <cf41cf410906200622t55921302o9d450c8eeed94e73@mail.gmail.com>

On Sat, Jun 20, 2009 at 2:56 PM, Devid Antonio Filoni <devidfil@gmail.com>wrote:

> find the Debian packages at the following links:
> Dillo: https://launchpad.net/~d.filoni/+archive/dillo<https://launchpad.net/%7Ed.filoni/+archive/dillo>
> Dillo+SSL:  https://launchpad.net/~d.filoni/+archive/dillo+ssl<https://launchpad.net/%7Ed.filoni/+archive/dillo+ssl>


just for sid, not lenny/squeeze: depends on libxi6 1.2

http://packages.debian.org/search?keywords=libxi6

-- 
SZERV?C Attila - zeneszerz?
http://google.com/search?q=szerv?c <http://google.com/search?q=szerv%C3%A1c>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: /pipermail/attachments/20090620/135aa305/attachment.html
From jcid at dillo.org  Sat Jun 20 15:51:27 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 20 15:51:42 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090619232035.GC26421@dillo.org>
References: <20090617190217.GB10602@dillo.org>
	<64a208ca0906171301n7cc92107k99e8ce40e371cb3@mail.gmail.com>
	<20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org>
Message-ID: <20090620135127.GA5510@dillo.org>

On Fri, Jun 19, 2009 at 07:20:35PM -0400, Jorge Arellano Cid wrote:
> On Fri, Jun 19, 2009 at 01:44:52PM -0400, Jorge Arellano Cid wrote:
> > On Thu, Jun 18, 2009 at 10:29:06PM -0400, Jorge Arellano Cid wrote:
> > > [...]
> > >   WARNING: Please don't make the packages yet, I've got a last minute
> > > security vulnerability email, so maybe the tarball will change
> > > once more (the last). I'll try to have this solved tomorrow in the
> > > morning.
> > 
> >   OK, the last tarball was just uploaded (rc3) and it will
> > be announced tomorrow in the morning. It has a patch
> > for malformed PNG images.
> > 
> >   Please make the respective packages and let me know
> > when ready to link them from the downloads page.
> 
>   BTW, the announcement will be on Saturday 20's morning
> (UTC - 4). So there's still some time to finish the packages.
> Please make sure you have the last tarball by checking the
> signature, and let me know to update the linking page.


  OK, the dillo-2.1 release announcement was submitted
to freshmeat and the download page updated with the URLs
of the latest packages.

  AFAIS everything is OK. Now I have to go out so if there's
something missing in the website, please let Corvid or Johannes
know here in dillo-dev.

  Great, let's hope for a good reception!

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Sat Jun 20 17:32:00 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun 20 17:34:58 2009
Subject: [Dillo-dev] experimental patch: nowrap
Message-ID: <20090620153200.GR8031@local.gobigwest.com>

Currently dillo does not handle the case where certain regions of a
line can be wrapped and other regions cannot. A prominent example
is the list of browsers at the bottom of http://en.wikipedia.org/wiki/Dillo


Here is a patch that minimizes memory use (adds one int per textblock)
at some cost of recalculating things
http://www.dillo.org/test/nowrap.patch

When whitespace isn't WHITE_SPACE_NORMAL, Textblock::add* functions
still add words to the word list, but postpone wrapping until the
entire nowrap/pre chunk has been added or a break has been seen.
This is so that we know whether to put it all on a new line.

Some possibilities:
 Putting some kind of spanWidth in each Word, calculating it in addNowrapWords
 and sticking this nonzero value into the beginning word. We'd have to
 remember to deal with it if things in the span changed size, or if dillo
 got on-the-fly display:none someday or whatever.

 Taking the time to stick the whole chunk into one word when the style is
 all the same. (Similar difficulties as the above.) I'm not sure whether
 that would make life more difficult if dillo got bidirectional text
 someday.

 Putting the nowrap Words into a Something, so that what is now a Word list
 would contain Word Word Word Something Word Something Word...
 That sounds complicated.

 Let the add* functions put the nowrap Words through wordWrap, and keep track
 of shifts between normal/nowrap in a line. When a line is completed, set
 up rewrap to do it over. This would be in an effort to "push down the bubble"
 of ickiness around add*/addNowrapWords/rewrap, although the resulting new
 bubble of ickiness that would pop up next to it would perhaps be similar.

 Small things that might or might not be improvements: make breaks have
 normal whitespace, and make lines with only one word have normal whitespace
 (text/plain).



From corvid at lavabit.com  Sat Jun 20 17:39:56 2009
From: corvid at lavabit.com (corvid)
Date: Sat Jun 20 17:42:53 2009
Subject: [Dillo-dev] trimming system includes
Message-ID: <20090620153956.GS8031@local.gobigwest.com>

Would anyone have strong objections if I go through
and make some patches to remove system includes where
I can't see any evidence that any code now in that file
still needs that header?



From jcid at dillo.org  Sun Jun 21 18:08:06 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sun Jun 21 18:08:21 2009
Subject: [Dillo-dev] trimming system includes
In-Reply-To: <20090620153956.GS8031@local.gobigwest.com>
References: <20090620153956.GS8031@local.gobigwest.com>
Message-ID: <20090621160806.GC6003@dillo.org>

On Sat, Jun 20, 2009 at 03:39:56PM +0000, corvid wrote:
> Would anyone have strong objections if I go through
> and make some patches to remove system includes where
> I can't see any evidence that any code now in that file
> still needs that header?

  OK, but please test is still works on the different
platforms.

-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Sun Jun 21 18:57:44 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Sun Jun 21 18:59:26 2009
Subject: [Dillo-dev] trimming system includes
In-Reply-To: <20090621160806.GC6003@dillo.org>
References: <20090620153956.GS8031@local.gobigwest.com>
	<20090621160806.GC6003@dillo.org>
Message-ID: <20090621165744.GA98409@blob.baaderstrasse.com>

On Sun, Jun 21, 2009 at 12:08:06PM -0400, Jorge Arellano Cid wrote:
> On Sat, Jun 20, 2009 at 03:39:56PM +0000, corvid wrote:
> > Would anyone have strong objections if I go through
> > and make some patches to remove system includes where
> > I can't see any evidence that any code now in that file
> > still needs that header?
> 
>   OK, but please test is still works on the different
> platforms.

I'm all for it and will be happy to test it on DragonFly BSD.

Cheers,
Johannes

From corvid at lavabit.com  Sun Jun 21 19:47:34 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun 21 19:50:38 2009
Subject: [Dillo-dev] form widgets, ascent/descent
In-Reply-To: <20090606223436.GF8570@dillo.org>
References: <20090604181143.GA1688@local.gobigwest.com>
	<20090606223436.GF8570@dillo.org>
Message-ID: <20090621174734.GW8031@local.gobigwest.com>

Jorge wrote:
> On Thu, Jun 04, 2009 at 06:11:43PM +0000, corvid wrote:
> > I was playing around in dw, and noticed that,
> > whereas form widgets normally like to put
> > much of their height into descent, when style
> > sets the height, Textblock::calcWidgetSize()
> > puts it all into ascent. 
> > 
> > I checked firefox and saw that their form widgets ascend.
> > 
> > If we made everything ascend and just put font->descent
> > into the descent, it would make life simpler.
> > Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I
> > could almost ignore that...
> 
>   Not knowing exactly about the details, I'd be very careful
> in changing ascents, descents and friends because the may
> interfere with correct handling of CSS.
> 
>   If you're sure it's OK to do it, even considering the "details"
> (e.g. reliefs, spacings, paddings), then why not.

Our details when it comes to form controls don't seem to be
exactly right to begin with, so I'm not making anything worse.
Little patch:
-------------- next part --------------
diff -r 9a913c474271 dw/fltkui.cc
--- a/dw/fltkui.cc	Sun Jun 21 12:19:13 2009 -0400
+++ b/dw/fltkui.cc	Sun Jun 21 17:22:14 2009 +0000
@@ -697,10 +697,10 @@ void FltkMultiLineTextResource::sizeRequ
          (int)::fltk::getwidth ("n", 1) * numCols +
          2 * RELIEF_X_THICKNESS;
       requisition->ascent =
-         font->ascent + RELIEF_Y_THICKNESS;
+         RELIEF_Y_THICKNESS + font->ascent +
+         (font->ascent + font->descent) * (numRows - 1);
       requisition->descent =
          font->descent +
-         (font->ascent + font->descent) * (numRows - 1) +
          RELIEF_Y_THICKNESS;
    } else {
       requisition->width = 1;
@@ -1310,9 +1310,9 @@ void FltkListResource::sizeRequest (core
        * options, at the cost of showing too much whitespace at times.
        */
       requisition->width = getMaxStringWidth() + 24;
-      requisition->ascent = font->ascent + 2;
-      requisition->descent = font->descent + 3 +
-                             (rows - 1) * (font->ascent + font->descent + 1);
+      requisition->ascent = font->ascent + 2 +
+                            (rows - 1) * (font->ascent + font->descent + 1);
+      requisition->descent = font->descent + 3;
    } else {
       requisition->width = 1;
       requisition->ascent = 1;
From corvid at lavabit.com  Sun Jun 21 19:57:25 2009
From: corvid at lavabit.com (corvid)
Date: Sun Jun 21 20:00:23 2009
Subject: [Dillo-dev] trimming system includes
In-Reply-To: <20090621165744.GA98409@blob.baaderstrasse.com>
References: <20090620153956.GS8031@local.gobigwest.com>
	<20090621160806.GC6003@dillo.org>
	<20090621165744.GA98409@blob.baaderstrasse.com>
Message-ID: <20090621175725.GX8031@local.gobigwest.com>

Johannes wrote:
> On Sun, Jun 21, 2009 at 12:08:06PM -0400, Jorge Arellano Cid wrote:
> > On Sat, Jun 20, 2009 at 03:39:56PM +0000, corvid wrote:
> > > Would anyone have strong objections if I go through
> > > and make some patches to remove system includes where
> > > I can't see any evidence that any code now in that file
> > > still needs that header?
> > 
> >   OK, but please test is still works on the different
> > platforms.
> 
> I'm all for it and will be happy to test it on DragonFly BSD.

Oh, good, because I was looking around at my extensive collection
of...one computer...that I can't easily put OSes on, thinking,
"Well, so much for that idea..."



From Johannes.Hofmann at gmx.de  Sun Jun 21 20:36:48 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Sun Jun 21 20:38:33 2009
Subject: [Dillo-dev] form widgets, ascent/descent
In-Reply-To: <20090621174734.GW8031@local.gobigwest.com>
References: <20090604181143.GA1688@local.gobigwest.com>
	<20090606223436.GF8570@dillo.org>
	<20090621174734.GW8031@local.gobigwest.com>
Message-ID: <20090621183648.GA1739@blob.baaderstrasse.com>

On Sun, Jun 21, 2009 at 05:47:34PM +0000, corvid wrote:
> Jorge wrote:
> > On Thu, Jun 04, 2009 at 06:11:43PM +0000, corvid wrote:
> > > I was playing around in dw, and noticed that,
> > > whereas form widgets normally like to put
> > > much of their height into descent, when style
> > > sets the height, Textblock::calcWidgetSize()
> > > puts it all into ascent. 
> > > 
> > > I checked firefox and saw that their form widgets ascend.
> > > 
> > > If we made everything ascend and just put font->descent
> > > into the descent, it would make life simpler.
> > > Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I
> > > could almost ignore that...
> > 
> >   Not knowing exactly about the details, I'd be very careful
> > in changing ascents, descents and friends because the may
> > interfere with correct handling of CSS.
> > 
> >   If you're sure it's OK to do it, even considering the "details"
> > (e.g. reliefs, spacings, paddings), then why not.
> 
> Our details when it comes to form controls don't seem to be
> exactly right to begin with, so I'm not making anything worse.
> Little patch:

> diff -r 9a913c474271 dw/fltkui.cc
> --- a/dw/fltkui.cc	Sun Jun 21 12:19:13 2009 -0400
> +++ b/dw/fltkui.cc	Sun Jun 21 17:22:14 2009 +0000
> @@ -697,10 +697,10 @@ void FltkMultiLineTextResource::sizeRequ
>           (int)::fltk::getwidth ("n", 1) * numCols +
>           2 * RELIEF_X_THICKNESS;
>        requisition->ascent =
> -         font->ascent + RELIEF_Y_THICKNESS;
> +         RELIEF_Y_THICKNESS + font->ascent +
> +         (font->ascent + font->descent) * (numRows - 1);
>        requisition->descent =
>           font->descent +
> -         (font->ascent + font->descent) * (numRows - 1) +
>           RELIEF_Y_THICKNESS;
>     } else {
>        requisition->width = 1;
> @@ -1310,9 +1310,9 @@ void FltkListResource::sizeRequest (core
>         * options, at the cost of showing too much whitespace at times.
>         */
>        requisition->width = getMaxStringWidth() + 24;
> -      requisition->ascent = font->ascent + 2;
> -      requisition->descent = font->descent + 3 +
> -                             (rows - 1) * (font->ascent + font->descent + 1);
> +      requisition->ascent = font->ascent + 2 +
> +                            (rows - 1) * (font->ascent + font->descent + 1);
> +      requisition->descent = font->descent + 3;
>     } else {
>        requisition->width = 1;
>        requisition->ascent = 1;

+1 from me.
I can't see why this was handled different before.

Cheers,
Johannes

From newman.x at gmail.com  Mon Jun 22 14:32:11 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Mon Jun 22 14:32:35 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <20090620135127.GA5510@dillo.org>
References: <20090617190217.GB10602@dillo.org>
	<20090617214502.GD10602@dillo.org> <20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org> <20090620135127.GA5510@dillo.org>
Message-ID: <5e9a80350906220532n13da9915vbeb50d67949568fc@mail.gmail.com>

On Sat, Jun 20, 2009 at 3:51 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> On Fri, Jun 19, 2009 at 07:20:35PM -0400, Jorge Arellano Cid wrote:
>> On Fri, Jun 19, 2009 at 01:44:52PM -0400, Jorge Arellano Cid wrote:
>> > On Thu, Jun 18, 2009 at 10:29:06PM -0400, Jorge Arellano Cid wrote:
>> > > [...]
>> > > ? WARNING: Please don't make the packages yet, I've got a last minute
>> > > security vulnerability email, so maybe the tarball will change
>> > > once more (the last). I'll try to have this solved tomorrow in the
>> > > morning.
>> >
>> > ? OK, the last tarball was just uploaded (rc3) and it will
>> > be announced tomorrow in the morning. It has a patch
>> > for malformed PNG images.
>> >
>> > ? Please make the respective packages and let me know
>> > when ready to link them from the downloads page.
>>
>> ? BTW, the announcement will be on Saturday 20's morning
>> (UTC - 4). So there's still some time to finish the packages.
>> Please make sure you have the last tarball by checking the
>> signature, and let me know to update the linking page.
>
>
> ?OK, the dillo-2.1 release announcement was submitted
> to freshmeat and the download page updated with the URLs
> of the latest packages.
>
> ?AFAIS everything is OK. Now I have to go out so if there's
> something missing in the website, please let Corvid or Johannes
> know here in dillo-dev.
>
> ?Great, let's hope for a good reception!
>
> --
> ?Cheers
> ?Jorge.-
>
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
>

FYI

Static Fedora-11 i586 & x86-64 packages:

http://mnowak.fedorapeople.org/dillo2/static/F-11/

Michal

From corvid at lavabit.com  Mon Jun 22 16:02:28 2009
From: corvid at lavabit.com (corvid)
Date: Mon Jun 22 16:05:29 2009
Subject: [Dillo-dev] trimming system includes
In-Reply-To: <20090622055840.GA854@blob.baaderstrasse.com>
References: <20090620153956.GS8031@local.gobigwest.com>
	<20090621160806.GC6003@dillo.org>
	<20090621165744.GA98409@blob.baaderstrasse.com>
	<20090622020801.GZ8031@local.gobigwest.com>
	<20090622055840.GA854@blob.baaderstrasse.com>
Message-ID: <20090622140228.GB4493@local.gobigwest.com>

Johannes wrote:
> On Mon, Jun 22, 2009 at 02:08:01AM +0000, corvid wrote:
> > Johannes wrote:
> > > I'm all for it and will be happy to test it on DragonFly BSD.
> > 
> > Does this come reasonably close to compiling?
> 
> Works just fine here.

Well, if it works for Johannes... :)

Anyway, I looked through the cvs archive a little, and it was interesting
to see the prehistoric origins of some of this stuff, dating as far back
as gzilla presumably. One is unavoidably reminded of how a living thing
today bears the mark of billions of years of evolutionary past.

-------------- next part --------------
diff -r 1491bc7989f9 src/IO/IO.c
--- a/src/IO/IO.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/IO/IO.c	Mon Jun 22 02:00:25 2009 +0000
@@ -13,14 +13,9 @@
  * Dillo's event driven IO engine
  */
 
-#include <stdio.h>
-#include <string.h>
 #include <errno.h>
 #include <fcntl.h>
 #include <unistd.h>
-#include <sys/stat.h>
-#include <sys/uio.h>
-#include <sys/socket.h>
 #include "../msg.h"
 #include "../chain.h"
 #include "../klist.h"
diff -r 1491bc7989f9 src/IO/IO.h
--- a/src/IO/IO.h	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/IO/IO.h	Mon Jun 22 02:00:25 2009 +0000
@@ -1,8 +1,5 @@
 #ifndef __IO_H__
 #define __IO_H__
-
-#include <unistd.h>
-#include <sys/uio.h>
 
 #include "d_size.h"
 #include "../../dlib/dlib.h"
diff -r 1491bc7989f9 src/IO/dpi.c
--- a/src/IO/dpi.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/IO/dpi.c	Mon Jun 22 02:00:25 2009 +0000
@@ -21,13 +21,10 @@
 #include <unistd.h>
 #include <stdlib.h>
 #include <sys/types.h>
-#include <sys/stat.h>
-#include <fcntl.h>
 #include <string.h>
 #include <stdio.h>
 #include <errno.h>           /* for errno */
 
-#include <stdio.h>
 #include <sys/socket.h>
 #include <sys/un.h>
 #include <netinet/in.h>
diff -r 1491bc7989f9 src/IO/http.c
--- a/src/IO/http.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/IO/http.c	Mon Jun 22 02:00:25 2009 +0000
@@ -20,9 +20,7 @@
 #include <unistd.h>
 #include <errno.h>              /* for errno */
 #include <stdlib.h>
-#include <signal.h>
 #include <fcntl.h>
-#include <sys/wait.h>
 #include <sys/socket.h>         /* for lots of socket stuff */
 #include <netinet/in.h>         /* for ntohl and stuff */
 #include <arpa/inet.h>          /* for inet_ntop */
diff -r 1491bc7989f9 src/IO/mime.h
--- a/src/IO/mime.h	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/IO/mime.h	Mon Jun 22 02:00:25 2009 +0000
@@ -13,7 +13,6 @@
 #define __MIME_H__
 
 #include <config.h>
-#include <stddef.h>
 
 #ifdef __cplusplus
 extern "C" {
diff -r 1491bc7989f9 src/bookmark.c
--- a/src/bookmark.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/bookmark.c	Mon Jun 22 02:00:25 2009 +0000
@@ -9,10 +9,7 @@
  * (at your option) any later version.
  */
 
-#include <errno.h>
-#include <stdio.h>
 #include <stdlib.h>
-#include <string.h>
 
 #include "msg.h"
 #include "history.h"
diff -r 1491bc7989f9 src/bw.h
--- a/src/bw.h	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/bw.h	Mon Jun 22 02:00:25 2009 +0000
@@ -1,7 +1,5 @@
 #ifndef __BW_H__
 #define __BW_H__
-
-#include <sys/types.h>
 
 #include "url.h"     /* for DilloUrl */
 
diff -r 1491bc7989f9 src/cache.c
--- a/src/cache.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/cache.c	Mon Jun 22 02:00:25 2009 +0000
@@ -16,11 +16,8 @@
 #include <ctype.h>              /* for tolower */
 #include <sys/types.h>
 
-#include <sys/stat.h>
 #include <stdlib.h>
 #include <string.h>
-#include <fcntl.h>
-#include <unistd.h>
 
 #include "msg.h"
 #include "IO/Url.h"
diff -r 1491bc7989f9 src/cookies.c
--- a/src/cookies.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/cookies.c	Mon Jun 22 02:00:25 2009 +0000
@@ -34,7 +34,6 @@ void a_Cookies_init(void)
 #include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <time.h>       /* for time() and time_t */
 #include <ctype.h>
 
 #include "msg.h"
diff -r 1491bc7989f9 src/css.cc
--- a/src/css.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/css.cc	Mon Jun 22 02:00:25 2009 +0000
@@ -10,7 +10,6 @@
  */
 
 #include <stdio.h>
-#include <math.h>
 #include "../dlib/dlib.h"
 #include "misc.h"
 #include "html_common.hh"
diff -r 1491bc7989f9 src/cssparser.cc
--- a/src/cssparser.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/cssparser.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -18,7 +18,6 @@
 #include <ctype.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <string.h>
 
 #include "msg.h"
 #include "colors.h"
diff -r 1491bc7989f9 src/dicache.c
--- a/src/dicache.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/dicache.c	Mon Jun 22 02:00:26 2009 +0000
@@ -9,9 +9,7 @@
  * (at your option) any later version.
  */
 
-#include <sys/time.h>       /* for libc5 compatibility */
 #include <string.h>         /* for memset */
-#include <stdio.h>
 #include <stdlib.h>
 
 #include "msg.h"
diff -r 1491bc7989f9 src/dns.c
--- a/src/dns.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/dns.c	Mon Jun 22 02:00:26 2009 +0000
@@ -21,10 +21,8 @@
 #include <arpa/inet.h>
 #include <netinet/in.h>
 #include <errno.h>
-#include <unistd.h>
 #include <stdlib.h>
 #include <stdio.h>
-#include <signal.h>
 #include <string.h>
 
 #include "msg.h"
diff -r 1491bc7989f9 src/html.cc
--- a/src/html.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/html.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -20,7 +20,6 @@
 #include <string.h>     /* for memcpy and memmove */
 #include <stdlib.h>
 #include <stdio.h>      /* for sprintf */
-#include <math.h>       /* for rint */
 #include <errno.h>
 
 #include "bw.h"         /* for BrowserWindow */
diff -r 1491bc7989f9 src/image.cc
--- a/src/image.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/image.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -14,9 +14,6 @@
  * This file implements image data transfer methods. It handles the transfer
  * of data from an Image to a DwImage widget.
  */
-
-#include <stdio.h>
-#include <string.h>
 
 #include "msg.h"
 
diff -r 1491bc7989f9 src/menu.cc
--- a/src/menu.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/menu.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -11,8 +11,6 @@
 
 // Functions/Methods for menus
 
-#include <stdio.h>
-#include <stdarg.h>
 #include <fltk/events.h>
 #include <fltk/PopupMenu.h>
 #include <fltk/Item.h>
diff -r 1491bc7989f9 src/misc.c
--- a/src/misc.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/misc.c	Mon Jun 22 02:00:26 2009 +0000
@@ -12,7 +12,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <unistd.h>
 #include <string.h>
 #include <ctype.h>
 
diff -r 1491bc7989f9 src/plain.cc
--- a/src/plain.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/plain.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -12,9 +12,6 @@
 /*
  * Module for decoding a text/plain object into a dw widget.
  */
-
-#include <string.h>     /* for memcpy and memmove */
-#include <math.h>       /* for rint() */
 
 #include "msg.h"
 #include "prefs.h"
diff -r 1491bc7989f9 src/png.c
--- a/src/png.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/png.c	Mon Jun 22 02:00:26 2009 +0000
@@ -13,11 +13,7 @@
 #include <config.h>
 #ifdef ENABLE_PNG
 
-#include <stdio.h>
-#include <string.h>
 #include <stdlib.h> /* For abort() */
-
-#include <zlib.h>
 
 #ifdef HAVE_LIBPNG_PNG_H
 #include <libpng/png.h>
diff -r 1491bc7989f9 src/prefsparser.cc
--- a/src/prefsparser.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/prefsparser.cc	Mon Jun 22 02:00:26 2009 +0000
@@ -10,10 +10,7 @@
  */
 
 #include <sys/types.h>
-#include <sys/stat.h>
 #include <stdlib.h>
-#include <fcntl.h>
-#include <unistd.h>
 #include <locale.h>            /* for setlocale */
 
 #include "prefs.h"
diff -r 1491bc7989f9 src/styleengine.cc
--- a/src/styleengine.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/styleengine.cc	Mon Jun 22 02:00:27 2009 +0000
@@ -9,8 +9,7 @@
  * (at your option) any later version.
  */
 
-#include <stdio.h>
-#include <math.h>
+/* #include <stdio.h> */
 #include "../dlib/dlib.h"
 #include "msg.h"
 #include "prefs.h"
diff -r 1491bc7989f9 src/ui.cc
--- a/src/ui.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/ui.cc	Mon Jun 22 02:00:27 2009 +0000
@@ -11,7 +11,6 @@
 
 // UI for Dillo
 
-#include <stdlib.h>
 #include <stdio.h>
 
 #include <fltk/HighlightButton.h>
diff -r 1491bc7989f9 src/url.c
--- a/src/url.c	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/url.c	Mon Jun 22 02:00:27 2009 +0000
@@ -42,8 +42,6 @@
  *    - path is never "undefined" though it may be "empty".
  */
 
-
-#include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 #include <ctype.h>
diff -r 1491bc7989f9 src/url.h
--- a/src/url.h	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/url.h	Mon Jun 22 02:00:27 2009 +0000
@@ -10,7 +10,6 @@
 #ifndef __URL_H__
 #define __URL_H__
 
-#include <string.h>       /* for strcmp */
 #include "d_size.h"
 #include "../dlib/dlib.h"
 
diff -r 1491bc7989f9 src/web.cc
--- a/src/web.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/web.cc	Mon Jun 22 02:00:27 2009 +0000
@@ -8,10 +8,6 @@
  * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
  */
-
-#include <stdio.h>
-#include <stdlib.h>
-#include <math.h>      /* for rint */
 
 #include "msg.h"
 #include "nav.h"
diff -r 1491bc7989f9 src/xembed.cc
--- a/src/xembed.cc	Sun Jun 21 17:20:12 2009 +0000
+++ b/src/xembed.cc	Mon Jun 22 02:00:27 2009 +0000
@@ -9,7 +9,6 @@
  * (at your option) any later version.
  */
 
-#include <stdio.h>
 #include <string.h>
 #include <ctype.h>
 
From sandshrew at gmail.com  Mon Jun 22 16:12:07 2009
From: sandshrew at gmail.com (Tomas R)
Date: Mon Jun 22 16:13:00 2009
Subject: [Dillo-dev] dillo 2.1
Message-ID: <20090622171207.18d7c924@ubuntu>

Been testing dillo 2.1 for some time and would like to share my
experience. 

It's really great to see some basic css support (appearance of most if
not all websites has improved alot), properly resized images,
redirection and basic authentication working now :)

Anyway, even dillo improved alot recently there still seems to be some
issues. Here are some I've noticed after testing this release for few
days:
Rendering
1) ubuntu.lt
Not sure if it's dillo fault or website's malformed stylesheet, but
with default dillo settings some of the lithuanian characters are not
displayed. This can be fixed by just adding "* {font-family:
serif !important}" to the style.css. Here is a pic with some of the
places where letters are missing marked in red:
http://img4.imageshack.us/img4/2227/ubuntult.png
2) gmail
It's nice that login works now, but with default dillo settings the
size of most of the text is 1px. This can be partially fixed by adding
font_min_size to dillorc, but it's obviously a dillo bug as this
doesn't happen with links-hacked.
3) google
What's with the textarea in the top left corner of the page? And just
for information: signing out doesn't work because it requires basic
javascript support (works with links-hacked).
4) Black on black, white on white...
http://www.nma-fallout.com/forum/viewtopic.php?t=42776&start=2660&sid=a5712379bdb845ed64a2dfdca10509ea
For some reason black font color is used here and we get black text on
black background in some posts (doesn't happen with links-hacked).
http://www.acetoneteam.org/
Background color is not set here and if we have "body
{background-color: white}" rule in our style.css file, we get white
text on white background.
5) http://ubuntuforums.org/showthread.php?p=6592005
What's with the PINK blocks? If that's more of a "feature" then a bug,
can the color be changed by using some css rule?
6) http://www.binaryworld.skynet.lt/DUK.html
If we use one link with fragment identifier in the page, all the others
are marked as visited too.
7) Authentication
Basic authentication does work now, but at first the server displays a
message saying "wrong credentials or browser doesn't 
understand how to supply the credentials" and only then a window
pops up asking for the credentials...

UI
1) Positioning the tab close button on the top RIGHT corner of the
browser isn't a good thing because:
a) The distance between the most commonly used buttons and the tab
close button is pretty big (especially when widescreen monitors are
pretty common nowadays);
b) It only allows closing the active tab;
I think it would be much better if all tabs had close buttons or at
least the button was placed near the last tab.
2) Trivial but... because the setting to enable/disable image loading
now is in the wrench menu it is two clicks away instead of one as it
used to be in dillo 2.0. Maybe css settings could be left where they are
now, but the setting for enabling/disabling images could be moved where
it was in dillo 2.0?
3) UPPERCASE letters should be used in the File menu to define keyboard
shortcuts, because now L looks like I (Open url... ctrl+l)
4) Don't you think "Are you sure you want to close the browser?"
message is pretty annoying?

Other:
It seems whoever designed the new website theme has no idea what
READABILITY means... It looks like someone just used some stupid online
color picker, which just picks some similar colors to the one user
chooses. The old website looked MUCH MUCH better. Imho, it's a
regression... 

PS: how to install dillo 2.1 claws-mail plugin?

-- 
Brain: an apparatus with which we think we think. - A. Bierce

From jcid at dillo.org  Mon Jun 22 18:17:38 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun 22 18:17:54 2009
Subject: [Dillo-dev] trimming system includes
In-Reply-To: <20090622140228.GB4493@local.gobigwest.com>
References: <20090620153956.GS8031@local.gobigwest.com>
	<20090621160806.GC6003@dillo.org>
	<20090621165744.GA98409@blob.baaderstrasse.com>
	<20090622020801.GZ8031@local.gobigwest.com>
	<20090622055840.GA854@blob.baaderstrasse.com>
	<20090622140228.GB4493@local.gobigwest.com>
Message-ID: <20090622161738.GC3876@dillo.org>

On Mon, Jun 22, 2009 at 02:02:28PM +0000, corvid wrote:
> Johannes wrote:
> > On Mon, Jun 22, 2009 at 02:08:01AM +0000, corvid wrote:
> > > Johannes wrote:
> > > > I'm all for it and will be happy to test it on DragonFly BSD.
> > > 
> > > Does this come reasonably close to compiling?
> > 
> > Works just fine here.
> 
> Well, if it works for Johannes... :)

  Good.  Please commit so people can test from the repo.


> Anyway, I looked through the cvs archive a little, and it was interesting
> to see the prehistoric origins of some of this stuff, dating as far back
> as gzilla presumably. One is unavoidably reminded of how a living thing
> today bears the mark of billions of years of evolutionary past.

  Maybe  the original designers didn't have enough time to remove
or polish the rough edges, henceforth leaving the hybrid creature
on its own to do the job!  :-)


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Mon Jun 22 18:20:32 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun 22 18:20:46 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906220532n13da9915vbeb50d67949568fc@mail.gmail.com>
References: <20090617214502.GD10602@dillo.org>
	<20090617220022.GE10602@dillo.org>
	<5e9a80350906180136v4310720cp13d57a3df5be9abf@mail.gmail.com>
	<20090618195629.GD3626@dillo.org>
	<5e9a80350906181420p6bfb25a0jeed504a11cfbc64b@mail.gmail.com>
	<20090619022906.GG8013@dillo.org> <20090619174452.GA7648@dillo.org>
	<20090619232035.GC26421@dillo.org>
	<20090620135127.GA5510@dillo.org>
	<5e9a80350906220532n13da9915vbeb50d67949568fc@mail.gmail.com>
Message-ID: <20090622162032.GD3876@dillo.org>

On Mon, Jun 22, 2009 at 02:32:11PM +0200, Michal Nowak wrote:
> On Sat, Jun 20, 2009 at 3:51 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> > On Fri, Jun 19, 2009 at 07:20:35PM -0400, Jorge Arellano Cid wrote:
> >> On Fri, Jun 19, 2009 at 01:44:52PM -0400, Jorge Arellano Cid wrote:
> >> > On Thu, Jun 18, 2009 at 10:29:06PM -0400, Jorge Arellano Cid wrote:
> >> > > [...]
> >> > > ? WARNING: Please don't make the packages yet, I've got a last minute
> >> > > security vulnerability email, so maybe the tarball will change
> >> > > once more (the last). I'll try to have this solved tomorrow in the
> >> > > morning.
> >> >
> >> > ? OK, the last tarball was just uploaded (rc3) and it will
> >> > be announced tomorrow in the morning. It has a patch
> >> > for malformed PNG images.
> >> >
> >> > ? Please make the respective packages and let me know
> >> > when ready to link them from the downloads page.
> >>
> >> ? BTW, the announcement will be on Saturday 20's morning
> >> (UTC - 4). So there's still some time to finish the packages.
> >> Please make sure you have the last tarball by checking the
> >> signature, and let me know to update the linking page.
> >
> >
> > ?OK, the dillo-2.1 release announcement was submitted
> > to freshmeat and the download page updated with the URLs
> > of the latest packages.
> >
> > ?AFAIS everything is OK. Now I have to go out so if there's
> > something missing in the website, please let Corvid or Johannes
> > know here in dillo-dev.
> >
> > ?Great, let's hope for a good reception!
> >
> > --
> > ?Cheers
> > ?Jorge.-
> >
> > _______________________________________________
> > Dillo-dev mailing list
> > Dillo-dev@dillo.org
> > http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev
> >
> 
> FYI
> 
> Static Fedora-11 i586 & x86-64 packages:
> 
> http://mnowak.fedorapeople.org/dillo2/static/F-11/

  Good. It's linked from the downloads page.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Mon Jun 22 18:28:29 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Mon Jun 22 18:28:46 2009
Subject: [Dillo-dev] form widgets, ascent/descent
In-Reply-To: <20090621183648.GA1739@blob.baaderstrasse.com>
References: <20090604181143.GA1688@local.gobigwest.com>
	<20090606223436.GF8570@dillo.org>
	<20090621174734.GW8031@local.gobigwest.com>
	<20090621183648.GA1739@blob.baaderstrasse.com>
Message-ID: <20090622162829.GE3876@dillo.org>

On Sun, Jun 21, 2009 at 08:36:48PM +0200, Johannes Hofmann wrote:
> On Sun, Jun 21, 2009 at 05:47:34PM +0000, corvid wrote:
> > Jorge wrote:
> > > On Thu, Jun 04, 2009 at 06:11:43PM +0000, corvid wrote:
> > > > I was playing around in dw, and noticed that,
> > > > whereas form widgets normally like to put
> > > > much of their height into descent, when style
> > > > sets the height, Textblock::calcWidgetSize()
> > > > puts it all into ascent. 
> > > > 
> > > > I checked firefox and saw that their form widgets ascend.
> > > > 
> > > > If we made everything ascend and just put font->descent
> > > > into the descent, it would make life simpler.
> > > > Or, nearly. I guess there is RELIEF_Y_THICKNESS, but I
> > > > could almost ignore that...
> > > 
> > >   Not knowing exactly about the details, I'd be very careful
> > > in changing ascents, descents and friends because the may
> > > interfere with correct handling of CSS.
> > > 
> > >   If you're sure it's OK to do it, even considering the "details"
> > > (e.g. reliefs, spacings, paddings), then why not.
> > 
> > Our details when it comes to form controls don't seem to be
> > exactly right to begin with, so I'm not making anything worse.
> > Little patch:
> 
> > diff -r 9a913c474271 dw/fltkui.cc
> > --- a/dw/fltkui.cc  Sun Jun 21 12:19:13 2009 -0400
> > +++ b/dw/fltkui.cc  Sun Jun 21 17:22:14 2009 +0000
> > @@ -697,10 +697,10 @@ void FltkMultiLineTextResource::sizeRequ
> >           (int)::fltk::getwidth ("n", 1) * numCols +
> >           2 * RELIEF_X_THICKNESS;
> >        requisition->ascent =
> > -         font->ascent + RELIEF_Y_THICKNESS;
> > +         RELIEF_Y_THICKNESS + font->ascent +
> > +         (font->ascent + font->descent) * (numRows - 1);
> >        requisition->descent =
> >           font->descent +
> > -         (font->ascent + font->descent) * (numRows - 1) +
> >           RELIEF_Y_THICKNESS;
> >     } else {
> >        requisition->width = 1;
> > @@ -1310,9 +1310,9 @@ void FltkListResource::sizeRequest (core
> >         * options, at the cost of showing too much whitespace at times.
> >         */
> >        requisition->width = getMaxStringWidth() + 24;
> > -      requisition->ascent = font->ascent + 2;
> > -      requisition->descent = font->descent + 3 +
> > -                             (rows - 1) * (font->ascent + font->descent + 1);
> > +      requisition->ascent = font->ascent + 2 +
> > +                            (rows - 1) * (font->ascent + font->descent + 1);
> > +      requisition->descent = font->descent + 3;
> >     } else {
> >        requisition->width = 1;
> >        requisition->ascent = 1;
> 
> +1 from me.
> I can't see why this was handled different before.
> 

  OK, please commit.

-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Mon Jun 22 18:49:06 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Mon Jun 22 18:50:50 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622171207.18d7c924@ubuntu>
References: <20090622171207.18d7c924@ubuntu>
Message-ID: <20090622164836.GA59439@blob.baaderstrasse.com>

Hi Tomas,

On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> Been testing dillo 2.1 for some time and would like to share my
> experience. 
> 
> It's really great to see some basic css support (appearance of most if
> not all websites has improved alot), properly resized images,
> redirection and basic authentication working now :)
> 
> Anyway, even dillo improved alot recently there still seems to be some
> issues. Here are some I've noticed after testing this release for few
> days:
> Rendering
> 1) ubuntu.lt
> Not sure if it's dillo fault or website's malformed stylesheet, but
> with default dillo settings some of the lithuanian characters are not
> displayed. This can be fixed by just adding "* {font-family:
> serif !important}" to the style.css. Here is a pic with some of the
> places where letters are missing marked in red:
> http://img4.imageshack.us/img4/2227/ubuntult.png

I guess the problem is that the font simply does not contain those
glyphs. There are some rules how this case should be handled, but
dillo does not implement them currently.

> 2) gmail
> It's nice that login works now, but with default dillo settings the
> size of most of the text is 1px. This can be partially fixed by adding
> font_min_size to dillorc, but it's obviously a dillo bug as this
> doesn't happen with links-hacked.

I don't have a gmail account, so I can't reproduce it, but
there seems to be a general bug in the CSS code that makes fonts
smaller than in other browsers.

> 3) google
> What's with the textarea in the top left corner of the page? And just
> for information: signing out doesn't work because it requires basic
> javascript support (works with links-hacked).

That textarea is in the google page. It's just hidden due to a
"display: none" CSS directive which is not supported yet by dillo.
Actually I'd like to know the reason why it is there before
hiding it.

> 4) Black on black, white on white...
> http://www.nma-fallout.com/forum/viewtopic.php?t=42776&start=2660&sid=a5712379bdb845ed64a2dfdca10509ea
> For some reason black font color is used here and we get black text on
> black background in some posts (doesn't happen with links-hacked).

Oh. This is just horrible HTML / CSS, it's full of bugs!
The reason for black on black is:
<body bgcolor="#000000" text="#C0C0C0" link="#33CC00" vlink="#33CC00" />

I.e. body is immediately closed. But there is tons of other bugs on
this page.

> http://www.acetoneteam.org/
> Background color is not set here and if we have "body
> {background-color: white}" rule in our style.css file, we get white
> text on white background.

dillo does not handle color definitions of the form rgb(255,255,255)
yet. I guess we can fix that.

> 5) http://ubuntuforums.org/showthread.php?p=6592005
> What's with the PINK blocks? If that's more of a "feature" then a bug,
> can the color be changed by using some css rule?

I can't find pink blocks on that page. Where exactly do you see
them? Maybe post a screenshot.

> 6) http://www.binaryworld.skynet.lt/DUK.html
> If we use one link with fragment identifier in the page, all the others
> are marked as visited too.

Not sure how this should be handled correctly. Someone will have to
check the specs.

> 7) Authentication
> Basic authentication does work now, but at first the server displays a
> message saying "wrong credentials or browser doesn't 
> understand how to supply the credentials" and only then a window
> pops up asking for the credentials...
> 
> UI
> 1) Positioning the tab close button on the top RIGHT corner of the
> browser isn't a good thing because:
> a) The distance between the most commonly used buttons and the tab
> close button is pretty big (especially when widescreen monitors are
> pretty common nowadays);
> b) It only allows closing the active tab;
> I think it would be much better if all tabs had close buttons or at
> least the button was placed near the last tab.

Agreed. Patch welcome :)

> 2) Trivial but... because the setting to enable/disable image loading
> now is in the wrench menu it is two clicks away instead of one as it
> used to be in dillo 2.0. Maybe css settings could be left where they are
> now, but the setting for enabling/disabling images could be moved where
> it was in dillo 2.0?
> 3) UPPERCASE letters should be used in the File menu to define keyboard
> shortcuts, because now L looks like I (Open url... ctrl+l)
> 4) Don't you think "Are you sure you want to close the browser?"
> message is pretty annoying?

Which one exactly? When exiting dillo with multiple tabs/windows
open? 
I don't think dillo asks a lot for confirmation, but I normally use
multiple Ctrl-q's to close all tabs and windows and quit.

> 
> Other:
> It seems whoever designed the new website theme has no idea what
> READABILITY means... It looks like someone just used some stupid online
> color picker, which just picks some similar colors to the one user
> chooses. The old website looked MUCH MUCH better. Imho, it's a
> regression... 

Hm I like the new design, but I agree that readability might be a problem.
Let's see what other say.

> 
> PS: how to install dillo 2.1 claws-mail plugin?

Just install claws and the dillo plugin from source or packages
depending on your distribution.
Then make sure that dillo-2.1 is the dillo binary in your PATH.

Cheers,
Johannes

From corvid at lavabit.com  Mon Jun 22 19:24:28 2009
From: corvid at lavabit.com (corvid)
Date: Mon Jun 22 19:27:28 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622164836.GA59439@blob.baaderstrasse.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
Message-ID: <20090622172428.GC4493@local.gobigwest.com>

Johannes wrote:
> On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> > 1) ubuntu.lt
> > Not sure if it's dillo fault or website's malformed stylesheet, but
> > with default dillo settings some of the lithuanian characters are not
> > displayed. This can be fixed by just adding "* {font-family:
> > serif !important}" to the style.css. Here is a pic with some of the
> > places where letters are missing marked in red:
> > http://img4.imageshack.us/img4/2227/ubuntult.png
> 
> I guess the problem is that the font simply does not contain those
> glyphs. There are some rules how this case should be handled, but
> dillo does not implement them currently.

Yeah, everything works for me because I have a real shortage of fonts,
so 99.9999% of text is shown in DejaVu fonts.

> > 6) http://www.binaryworld.skynet.lt/DUK.html
> > If we use one link with fragment identifier in the page, all the others
> > are marked as visited too.
> 
> Not sure how this should be handled correctly. Someone will have to
> check the specs.

I'm not aware of anything in the HTML spec on it, at least.

> > 3) UPPERCASE letters should be used in the File menu to define keyboard
> > shortcuts, because now L looks like I (Open url... ctrl+l)

I'll look into this.

> > It seems whoever designed the new website theme has no idea what
> > READABILITY means... It looks like someone just used some stupid online
> > color picker, which just picks some similar colors to the one user
> > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > regression... 
> 
> Hm I like the new design, but I agree that readability might be a problem.
> Let's see what other say.

I still find visited text to be hard to read, but I know I should
break down and get a new display...



From sandshrew at gmail.com  Mon Jun 22 20:53:08 2009
From: sandshrew at gmail.com (Tomas Rimkus)
Date: Mon Jun 22 20:54:38 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622164836.GA59439@blob.baaderstrasse.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
Message-ID: <20090622185308.GA13793@lan-84-240-35-19.skynet.lt>

On Mon, Jun 22, 2009 at 06:49:06PM +0200, Johannes Hofmann wrote:
> Hi Tomas,
> 
> On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> > Been testing dillo 2.1 for some time and would like to share my
> > experience. 
> > 
> > It's really great to see some basic css support (appearance of most if
> > not all websites has improved alot), properly resized images,
> > redirection and basic authentication working now :)
> > 
> > Anyway, even dillo improved alot recently there still seems to be some
> > issues. Here are some I've noticed after testing this release for few
> > days:
> > Rendering
> > 1) ubuntu.lt
> > Not sure if it's dillo fault or website's malformed stylesheet, but
> > with default dillo settings some of the lithuanian characters are not
> > displayed. This can be fixed by just adding "* {font-family:
> > serif !important}" to the style.css. Here is a pic with some of the
> > places where letters are missing marked in red:
> > http://img4.imageshack.us/img4/2227/ubuntult.png
> 
> I guess the problem is that the font simply does not contain those
> glyphs. There are some rules how this case should be handled, but
> dillo does not implement them currently.
> 

I see.

> > 2) gmail
> > It's nice that login works now, but with default dillo settings the
> > size of most of the text is 1px. This can be partially fixed by adding
> > font_min_size to dillorc, but it's obviously a dillo bug as this
> > doesn't happen with links-hacked.
> 
> I don't have a gmail account, so I can't reproduce it, but
> there seems to be a general bug in the CSS code that makes fonts
> smaller than in other browsers.

The account is just few clicks away ;)

> > 3) google
> > What's with the textarea in the top left corner of the page? And just
> > for information: signing out doesn't work because it requires basic
> > javascript support (works with links-hacked).
> 
> That textarea is in the google page. It's just hidden due to a
> "display: none" CSS directive which is not supported yet by dillo.
> Actually I'd like to know the reason why it is there before
> hiding it.
> 

I guess, that's a honeypot for spambots.

> > 4) Black on black, white on white...
> > http://www.nma-fallout.com/forum/viewtopic.php?t=42776&start=2660&sid=a5712379bdb845ed64a2dfdca10509ea
> > For some reason black font color is used here and we get black text on
> > black background in some posts (doesn't happen with links-hacked).
> 
> Oh. This is just horrible HTML / CSS, it's full of bugs!
> The reason for black on black is:
> <body bgcolor="#000000" text="#C0C0C0" link="#33CC00" vlink="#33CC00" />
> 
> I.e. body is immediately closed. But there is tons of other bugs on
> this page.
 
I see. I'll try to contact the admin and see if I can fix some of the bugs.

> > http://www.acetoneteam.org/
> > Background color is not set here and if we have "body
> > {background-color: white}" rule in our style.css file, we get white
> > text on white background.
> 
> dillo does not handle color definitions of the form rgb(255,255,255)
> yet. I guess we can fix that.
> 
Sounds good :)

> > 5) http://ubuntuforums.org/showthread.php?p=6592005
> > What's with the PINK blocks? If that's more of a "feature" then a bug,
> > can the color be changed by using some css rule?
> 
> I can't find pink blocks on that page. Where exactly do you see
> them? Maybe post a screenshot.
> 
Sure. Some of the blocks marked in red:
http://img20.imageshack.us/img20/2749/ubuntuforums.png
http://img20.imageshack.us/img20/6066/ubuntuforums1.png

> > 6) http://www.binaryworld.skynet.lt/DUK.html
> > If we use one link with fragment identifier in the page, all the others
> > are marked as visited too.
> 
> Not sure how this should be handled correctly. Someone will have to
> check the specs.
> 
I've checked opera, firefox, midori and chromium (aka google chrome under 
BSD license) browsers. None of them act like that.

> > 7) Authentication
> > Basic authentication does work now, but at first the server displays a
> > message saying "wrong credentials or browser doesn't 
> > understand how to supply the credentials" and only then a window
> > pops up asking for the credentials...
> > 
> > UI
> > 1) Positioning the tab close button on the top RIGHT corner of the
> > browser isn't a good thing because:
> > a) The distance between the most commonly used buttons and the tab
> > close button is pretty big (especially when widescreen monitors are
> > pretty common nowadays);
> > b) It only allows closing the active tab;
> > I think it would be much better if all tabs had close buttons or at
> > least the button was placed near the last tab.
> 
> Agreed. Patch welcome :)
> 
> > 2) Trivial but... because the setting to enable/disable image loading
> > now is in the wrench menu it is two clicks away instead of one as it
> > used to be in dillo 2.0. Maybe css settings could be left where they are
> > now, but the setting for enabling/disabling images could be moved where
> > it was in dillo 2.0?
> > 3) UPPERCASE letters should be used in the File menu to define keyboard
> > shortcuts, because now L looks like I (Open url... ctrl+l)
> > 4) Don't you think "Are you sure you want to close the browser?"
> > message is pretty annoying?
> 
> Which one exactly? When exiting dillo with multiple tabs/windows
> open? 
> I don't think dillo asks a lot for confirmation, but I normally use
> multiple Ctrl-q's to close all tabs and windows and quit.
> 

Yup, the one with multiple tabs. I just use my WM's shortcut for closing the
window.

> > 
> > Other:
> > It seems whoever designed the new website theme has no idea what
> > READABILITY means... It looks like someone just used some stupid online
> > color picker, which just picks some similar colors to the one user
> > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > regression... 
> 
> Hm I like the new design, but I agree that readability might be a problem.
> Let's see what other say.
> 
> > 
> > PS: how to install dillo 2.1 claws-mail plugin?
> 
> Just install claws and the dillo plugin from source or packages
> depending on your distribution.
> Then make sure that dillo-2.1 is the dillo binary in your PATH.

Ok, I'll try.

From corvid at lavabit.com  Mon Jun 22 20:51:55 2009
From: corvid at lavabit.com (corvid)
Date: Mon Jun 22 20:54:54 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622172428.GC4493@local.gobigwest.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
	<20090622172428.GC4493@local.gobigwest.com>
Message-ID: <20090622185155.GG4493@local.gobigwest.com>

I wrote:
> Johannes wrote:
> > On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> > > 3) UPPERCASE letters should be used in the File menu to define keyboard
> > > shortcuts, because now L looks like I (Open url... ctrl+l)
> 
> I'll look into this.

Hmm, I thought you were saying that this was new behaviour, but I
see the old code worked that way as well. You give the shortcut
to fltk and it draws it however it wants to draw it.

Oh, maybe your UI font used to be a serif font...
It is currently hardcoded to use font_sans_serif
(the reason being that whatever default UI font fltk picked out
for us was reasonably likely to have worse unicode coverage
than the fonts we set in dillorc), but there has been talk
of adding prefs for UI font and fontsize -- which I'd be
willing to do.



From sandshrew at gmail.com  Mon Jun 22 21:49:05 2009
From: sandshrew at gmail.com (Tomas Rimkus)
Date: Mon Jun 22 21:50:34 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622164836.GA59439@blob.baaderstrasse.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
Message-ID: <20090622194905.GA15843@lan-84-240-35-19.skynet.lt>

> > UI
> > 1) Positioning the tab close button on the top RIGHT corner of the
> > browser isn't a good thing because:
> > a) The distance between the most commonly used buttons and the tab
> > close button is pretty big (especially when widescreen monitors are
> > pretty common nowadays);
> > b) It only allows closing the active tab;
> > I think it would be much better if all tabs had close buttons or at
> > least the button was placed near the last tab.
> 
> Agreed. Patch welcome :)
> 

It seems this requires patching fltk -> http://www.mail-archive.com/fltk@easysw.com/msg05658.html

From Johannes.Hofmann at gmx.de  Mon Jun 22 21:57:35 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Mon Jun 22 22:01:03 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622194905.GA15843@lan-84-240-35-19.skynet.lt>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
	<20090622194905.GA15843@lan-84-240-35-19.skynet.lt>
Message-ID: <20090622195735.GA61775@blob.baaderstrasse.com>

On Mon, Jun 22, 2009 at 10:49:05PM +0300, Tomas Rimkus wrote:
> > > UI
> > > 1) Positioning the tab close button on the top RIGHT corner of the
> > > browser isn't a good thing because:
> > > a) The distance between the most commonly used buttons and the tab
> > > close button is pretty big (especially when widescreen monitors are
> > > pretty common nowadays);
> > > b) It only allows closing the active tab;
> > > I think it would be much better if all tabs had close buttons or at
> > > least the button was placed near the last tab.
> > 
> > Agreed. Patch welcome :)
> > 
> 
> It seems this requires patching fltk -> http://www.mail-archive.com/fltk@easysw.com/msg05658.html

This just means, that fltk does not support that out of the box. It
would certainly be possible to implement it in dillo by overriding
the default fltk tab drawing code.

Cheers,
Johannes

From sandshrew at gmail.com  Mon Jun 22 22:01:12 2009
From: sandshrew at gmail.com (Tomas Rimkus)
Date: Mon Jun 22 22:02:41 2009
Subject: [Dillo-dev] dillo 2.1]
Message-ID: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>


Accidentally sent to corvid only. Forwarding to dillo-dev.

> > > It seems whoever designed the new website theme has no idea what
> > > READABILITY means... It looks like someone just used some stupid online
> > > color picker, which just picks some similar colors to the one user
> > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > regression... 
> > 
> > Hm I like the new design, but I agree that readability might be a problem.
> > Let's see what other say.
> 
> I still find visited text to be hard to read, but I know I should
> break down and get a new display...
> 

I wonder if you are the only dillo user with old display... BTW, I am using
pretty new LCD display and still find it hard to read.

From Johannes.Hofmann at gmx.de  Tue Jun 23 13:16:05 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Tue Jun 23 13:17:53 2009
Subject: [Dillo-dev] css font-size and nested tables
Message-ID: <20090623111603.GA68774@blob.baaderstrasse.com>

Hi,

trying to find the reason for the tiny fonts in gmail, I found the
following:

<html>
<head>
<style type="text/css">
td {font-family: arial; font-size:50%}
</style>
</head>
<body>

<table>
<tr> <td> foo bar </td> </tr>
<tr> <td> <table> <tr> <td>foo bar</td> </tr> </table> </td> </tr>
</table>

</body>
</html>

is rendered with the same font size in both lines in firefox,
konqueror, and opera.
Can someone enlighten me why the nested <td> does not decrease the
font size again in the second line?

If I change the CSS to act on <table> instead of <td> it works as
expected.

Cheers,
Johannes

From Johannes.Hofmann at gmx.de  Tue Jun 23 13:37:11 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Tue Jun 23 13:39:02 2009
Subject: [Dillo-dev] css font-size and nested tables
In-Reply-To: <20090623111603.GA68774@blob.baaderstrasse.com>
References: <20090623111603.GA68774@blob.baaderstrasse.com>
Message-ID: <20090623113711.GA39176@blob.baaderstrasse.com>

Oh well. Just found this here:

http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode

Not sure whether I want to do anything about it.
Adding quirks in browsers just causes web developers to add quirks to
fix them and so on...

Cheers,
Johannes


On Tue, Jun 23, 2009 at 01:16:05PM +0200, Johannes Hofmann wrote:
> Hi,
> 
> trying to find the reason for the tiny fonts in gmail, I found the
> following:
> 
> <html>
> <head>
> <style type="text/css">
> td {font-family: arial; font-size:50%}
> </style>
> </head>
> <body>
> 
> <table>
> <tr> <td> foo bar </td> </tr>
> <tr> <td> <table> <tr> <td>foo bar</td> </tr> </table> </td> </tr>
> </table>
> 
> </body>
> </html>
> 
> is rendered with the same font size in both lines in firefox,
> konqueror, and opera.
> Can someone enlighten me why the nested <td> does not decrease the
> font size again in the second line?
> 
> If I change the CSS to act on <table> instead of <td> it works as
> expected.
> 
> Cheers,
> Johannes
> 
> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

From sandshrew at gmail.com  Tue Jun 23 16:13:29 2009
From: sandshrew at gmail.com (Tomas R)
Date: Tue Jun 23 16:14:23 2009
Subject: [Dillo-dev] css font-size and nested tables
In-Reply-To: <20090623113711.GA39176@blob.baaderstrasse.com>
References: <20090623111603.GA68774@blob.baaderstrasse.com>
	<20090623113711.GA39176@blob.baaderstrasse.com>
Message-ID: <20090623171329.0ffc13e6@ubuntu>

On Tue, 23 Jun 2009 13:37:11 +0200
Johannes Hofmann <Johannes.Hofmann@gmx.de> wrote:

> Oh well. Just found this here:
> 
> http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode
> 
> Not sure whether I want to do anything about it.
> Adding quirks in browsers just causes web developers to add quirks to
> fix them and so on...
> 

For now, as a workaround font_min_size could be set to 10-12 by
default (anything lower than 10 is unreadable), but not sure how this
will effect some websites, where text is intentionally hidden by
setting its size to negative or very low value.


From sandshrew at gmail.com  Tue Jun 23 16:13:56 2009
From: sandshrew at gmail.com (Tomas R)
Date: Tue Jun 23 16:14:49 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622195735.GA61775@blob.baaderstrasse.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
	<20090622194905.GA15843@lan-84-240-35-19.skynet.lt>
	<20090622195735.GA61775@blob.baaderstrasse.com>
Message-ID: <20090623171356.6b8ba450@ubuntu>

One more thing that I forgot to mention in the first message is text
wrapping in textareas. By default unlike all the popular browsers dillo
does not wrap text in textareas. Actually discussion about this was
started in this mailing list some time ago but unexpectedly finished
after corvid pointed out that according to the standards it's up to the
browser to decide whether to wrap text or not. Maybe, if someone thinks
it's better when text is not wrapped, this could be made optional?
Would it be easy to implement this setting with fltk?

From jcid at dillo.org  Tue Jun 23 17:01:28 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 23 17:01:43 2009
Subject: [Dillo-dev] css font-size and nested tables
In-Reply-To: <20090623113711.GA39176@blob.baaderstrasse.com>
References: <20090623111603.GA68774@blob.baaderstrasse.com>
	<20090623113711.GA39176@blob.baaderstrasse.com>
Message-ID: <20090623150128.GC3600@dillo.org>

On Tue, Jun 23, 2009 at 01:37:11PM +0200, Johannes Hofmann wrote:
> Oh well. Just found this here:
> 
> http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode
> 
> Not sure whether I want to do anything about it.
> Adding quirks in browsers just causes web developers to add quirks to
> fix them and so on...

  Well, it's a quirk...

  and we already have the font_min_size to tackle the problem.
I'd  prefer  to  focus  our  scarce  development time into issues
deemed high priority (e.g. the column rendering in textblock).


-- 
  Cheers
  Jorge.-

From Johannes.Hofmann at gmx.de  Tue Jun 23 17:07:06 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Tue Jun 23 17:08:51 2009
Subject: [Dillo-dev] css font-size and nested tables
In-Reply-To: <20090623171329.0ffc13e6@ubuntu>
References: <20090623111603.GA68774@blob.baaderstrasse.com>
	<20090623113711.GA39176@blob.baaderstrasse.com>
	<20090623171329.0ffc13e6@ubuntu>
Message-ID: <20090623150705.GA55437@blob.baaderstrasse.com>

On Tue, Jun 23, 2009 at 05:13:29PM +0300, Tomas R wrote:
> On Tue, 23 Jun 2009 13:37:11 +0200
> Johannes Hofmann <Johannes.Hofmann@gmx.de> wrote:
> 
> > Oh well. Just found this here:
> > 
> > http://developer.mozilla.org/En/Fixing_Table_Inheritance_in_Quirks_Mode
> > 
> > Not sure whether I want to do anything about it.
> > Adding quirks in browsers just causes web developers to add quirks to
> > fix them and so on...
> > 
> 
> For now, as a workaround font_min_size could be set to 10-12 by
> default (anything lower than 10 is unreadable), but not sure how this
> will effect some websites, where text is intentionally hidden by
> setting its size to negative or very low value.

To simulate the behaviour of other browsers, you can add

table, caption {font-size: medium}

to your ~/.dillo/style.css for now.
Maybe we should add this to the FAQ?

Cheers,
Johannes

From jcid at dillo.org  Tue Jun 23 22:01:24 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 23 22:01:41 2009
Subject: [Dillo-dev] Re: Dillo 2.1 questions
In-Reply-To: <4A3F7A2F.8000509@student.ethz.ch>
References: <4A3F7A2F.8000509@student.ethz.ch>
Message-ID: <20090623200124.GA11865@dillo.org>

Hi,

On Mon, Jun 22, 2009 at 02:33:51PM +0200, Donjan Rodic wrote:
> Hello Jorge
>
> First off, Dillo 2.1 is awesome. It got exactly the features I hoped for  

  Good!

> and isn't noticably more resource hungry.

  In fact it has half the memory footprint of the dillo1 series.
  http://www.dillo.org/memory.html

> Too bad it doesn't support column layouts in CSS yet... can we expect  
> this in the next release?

  I hope!

  The column layout problem is mainly a lack of implementation
of floating elements in the textblock. it is one of the top priorities
for the next release (if not the topmost).

  We'll work on it and try to fix it. We're yet to find out
how much work it will be.


> One thing I can't figure out are the available keybinding commands. For  
> example, how would I call "scroll-one-screen-up", which I'd like to bind  
> to <Shift>Space. Similar to how Space scrolls one screen down.
> Also "open-link-in-new-tab" to <Ctrl>"left-mouse-click"...
> I couldn't find any documentation on such commands, except for the keys  
> listed in .dillo/keysrc.

  You should have an installation-wide keysrc file along with dillorc.
If not, just read http://www.dillo.org/keysrc.

  AFAIS, we haven't included that keybinding, but will probably
exist in the source repository soon.

  Maybe: coarse-scroll-down, coarse-scroll-up,
         fine-scroll-down, fine-scroll-up



> Another topic: is the adblock.txt in the .dillo folder supposed to work?  
> Is there any recent documentation on this?

  No, AFAIK it isn't in the release.
  I'd really like to have it in the next release though.


-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Tue Jun 23 23:18:57 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 23 23:19:13 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622172428.GC4493@local.gobigwest.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090622164836.GA59439@blob.baaderstrasse.com>
	<20090622172428.GC4493@local.gobigwest.com>
Message-ID: <20090623211857.GC11865@dillo.org>

On Mon, Jun 22, 2009 at 05:24:28PM +0000, corvid wrote:
> Johannes wrote:
> > On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> > > [...]
> > > 6) http://www.binaryworld.skynet.lt/DUK.html
> > > If we use one link with fragment identifier in the page, all the others
> > > are marked as visited too.
> > 
> > Not sure how this should be handled correctly. Someone will have to
> > check the specs.
> 
> I'm not aware of anything in the HTML spec on it, at least.

  Dillo  shows pages already in memory in visited color. That way
you  can  easily tell an in-memory link from one that's yet to be
downloaded.  This  is  very  useful when switching from online to
offline mode (e.g. dialup).

  IOW those links are rendered as visited because they're cached.

  In  the  same  page  (answers  section),  unvisited  links  are
rendered as such.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Tue Jun 23 23:49:29 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Tue Jun 23 23:49:45 2009
Subject: [Dillo-dev] dillo-2.1.tar.bz2
In-Reply-To: <5e9a80350906180127q9994cd4gc60d5bf8a4dfbb67@mail.gmail.com>
References: <20090616180954.GD4239@dillo.org>
	<64a208ca0906161234t7480693dx9b798233040870a@mail.gmail.com>
	<20090616201059.GE4239@dillo.org>
	<20090616211822.GB5061@assam.Belkin> <4A3812C4.4040207@pobox.com>
	<5e9a80350906170611ib21c986va4b83b06b7a29a7a@mail.gmail.com>
	<20090617190217.GB10602@dillo.org>
	<5e9a80350906180127q9994cd4gc60d5bf8a4dfbb67@mail.gmail.com>
Message-ID: <20090623214929.GD11865@dillo.org>

On Thu, Jun 18, 2009 at 10:27:20AM +0200, Michal Nowak wrote:
> On Wed, Jun 17, 2009 at 9:02 PM, Jorge Arellano Cid<jcid@dillo.org> wrote:
> >  [...]
> > ?In a nutshell (from my point of view):
> >
> > ? * fltk2 is not officially released, and maybe never will.
> > ? * dillo2 uses fltk2, and this creates pressure to package it.
> > ? * Distros have a policy against statically-linked binaries.
> 
> Definitely agree. The first and the second one can be somehow
> sorted out and fltk2 pushed to distribution, the last one is blocker.
>


> [...]
> You greatly outlined the problems with having Dillo-2 in distribution;
> the problem is FLTK2. While watching at "changes" in FLTK2 snapshots
> I can't thing that the development is stalled or even stopped.

  You  surely  refer  to  the  1.3  series because FLTK2 is quite
stalled.

  e.g. (nov 2008 version against current)

    diff -pru fltk-2.0.x-r6525 fltk-2.0.x-r6786|less

      /* Only whitespace and an email address change here! */


  FLTK-1.3 is the active one
  (a fact recognized by Bill Spitzak).


> 
> I understand that my proposal won't be popular but switching from
> FLTK2 is necessary - we hardly have FLTK2 in distributions (read: no
> Dillo-2 in distribution) and that's shortening our user base.

  I agree on the shortened user base, but the proposal to switch
to FLTK-1.3 is the probable course of action.


> How hard it would be to rewrite/port Dillo-2 to FLTK-1.3?
> 
> (I see that the speed of v1.3 development is nothing exciting, but
> from what I read months ago they at least plan to have a release
> ever.)

  This  branch  has  advanced  a  lot. It has less open bugs than
FLTK-2.0  [1],  an  active set of developers, and they've devoted
plenty of time to good documentation.


> While looking at the devel cycle of Dillo - two releases per year -
> I believe this porting should be mid-term goal. Unless we wanna
> spend another year out of mainstream distributions. (And frankly:
> even with Dillo-2 based on FLTK-1.3 we are quite far from Dillo-2
> in distribution...)

  Some  months  ago  I  had  long  emails  with  FLTK  developers
regarding  this  point. FLTK-1.3 may have a release in the middle
of  2009  and  they  may  even consider a compatibility layer for
FLTK-2.0  apps  (for them, it would be a most appealing assset to
have FLTK-2.0 apps. compile with FLTK-1.3 painlessly).

  Now,  given  the  effort  estimation  by  corvid, I'd go with a
native   port  as  soon  as  FLTK-1.3  is  released  (unless  the
compatibility  layer is there, or porting turns out to be a major
endeavour).  If  they succeed in an official release, chances are
we'll have FLTK-1.3 in distros when we finish our port.

  BTW,  their  advice  is  to wait for the first release and then
decide what to do.



[1] http://fltk.org/roadmap.php

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 24 00:06:03 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 00:06:20 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
Message-ID: <20090623220603.GG11865@dillo.org>

On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> 
> Accidentally sent to corvid only. Forwarding to dillo-dev.
> 
> > > > It seems whoever designed the new website theme has no idea what
> > > > READABILITY means... It looks like someone just used some stupid online
> > > > color picker, which just picks some similar colors to the one user
> > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > regression... 
> > > 
> > > Hm I like the new design, but I agree that readability might be a problem.
> > > Let's see what other say.
> > 
> > I still find visited text to be hard to read, but I know I should
> > break down and get a new display...
> > 
> 
> I wonder if you are the only dillo user with old display... BTW, I am using
> pretty new LCD display and still find it hard to read.

  OK,  we also had readability concerns but we agreed that it was
enough. OTOH some people bashed the old design as prehistoric!

  After all it's a matter of taste.
  Usability  is a different thing. Maybe you need higher contrast
to  see  clearly  (I  suffer with white backgrounds). Do you find
this one better to read [1]?

  What do other people think about the new web design?
  Aesthetically and from a readability point of view.
  Please comment.


[1] http://www.dillo.org/test/website/dillo2.2.html


-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Wed Jun 24 01:05:07 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 01:08:09 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090623220603.GG11865@dillo.org>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
	<20090623220603.GG11865@dillo.org>
Message-ID: <20090623230507.GJ6014@local.gobigwest.com>

Jorge wrote:
> On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> > 
> > Accidentally sent to corvid only. Forwarding to dillo-dev.
> > 
> > > > > It seems whoever designed the new website theme has no idea what
> > > > > READABILITY means... It looks like someone just used some stupid online
> > > > > color picker, which just picks some similar colors to the one user
> > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > > regression... 
> > > > 
> > > > Hm I like the new design, but I agree that readability might be a problem.
> > > > Let's see what other say.
> > > 
> > > I still find visited text to be hard to read, but I know I should
> > > break down and get a new display...
> > > 
> > 
> > I wonder if you are the only dillo user with old display... BTW, I am using
> > pretty new LCD display and still find it hard to read.
> 
>   OK,  we also had readability concerns but we agreed that it was
> enough. OTOH some people bashed the old design as prehistoric!
> 
>   After all it's a matter of taste.
>   Usability  is a different thing. Maybe you need higher contrast
> to  see  clearly  (I  suffer with white backgrounds). Do you find
> this one better to read [1]?
> 
>   What do other people think about the new web design?
>   Aesthetically and from a readability point of view.
>   Please comment.
> 
> 
> [1] http://www.dillo.org/test/website/dillo2.2.html

The test page's visited text is easier for me to read than
the home page's visited text.

Does anyone know what the contemporary way is to show the information
in Plans.html? I remember ball.gif being ubiquitous in html in 1995 --
in stratigraphy it is regarded as a valuable 'index fossil', often found
together with a variety of brightly-colored line.gifs and blink tags --
but I don't know what to do about it.



From corvid at lavabit.com  Wed Jun 24 02:20:54 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 02:24:02 2009
Subject: [Dillo-dev] patch: a binding for stop
In-Reply-To: <20090529193803.GR6001@local.gobigwest.com>
References: <20090506144645.GG6255@local.gobigwest.com>
	<20090506153231.GB6113@dillo.org>
	<20090506154731.GE29980@omphalos.singularity>
	<20090527142256.GH6001@local.gobigwest.com>
	<20090528144057.GA3663@dillo.org>
	<20090529023904.GP6001@local.gobigwest.com>
	<20090529155317.GB5026@dillo.org>
	<20090529193803.GR6001@local.gobigwest.com>
Message-ID: <20090624002054.GK6014@local.gobigwest.com>

How about if we just don't give it any default binding:

-------------- next part --------------
diff -r 2367c730f679 src/keys.cc
--- a/src/keys.cc	Tue Jun 23 21:33:46 2009 +0200
+++ b/src/keys.cc	Wed Jun 24 00:14:17 2009 +0000
@@ -90,6 +90,7 @@ static const KeyBinding_t default_keys[]
    { "bookmarks"    , KEYS_BOOKMARKS    , fltk::CTRL   , 'b'                },
    { "fullscreen"   , KEYS_FULLSCREEN   , fltk::CTRL   , fltk::SpaceKey     },
    { "reload"       , KEYS_RELOAD       , fltk::CTRL   , 'r'                },
+   { "stop"         , KEYS_STOP         , 0            , 0                  },
    { "hide-panels"  , KEYS_HIDE_PANELS  , 0            , fltk::EscapeKey    },
    { "file-menu"    , KEYS_FILE_MENU    , fltk::ALT    , 'f'                },
    { "close-all"    , KEYS_CLOSE_ALL    , fltk::ALT    , 'q'                },
@@ -115,12 +116,14 @@ void Keys::init()
    // Fill our key bindings list
    bindings = dList_new(32);
    for (uint_t i = 0; i < sizeof(default_keys) / sizeof(KeyBinding_t); i++) {
-      node = dNew(KeyBinding_t, 1);
-      node->name = dStrdup(default_keys[i].name);
-      node->cmd = default_keys[i].cmd;
-      node->modifier = default_keys[i].modifier;
-      node->key = default_keys[i].key;
-      dList_insert_sorted(bindings, node, nodeByKeyCmp);
+      if (default_keys[i].key) {
+         node = dNew(KeyBinding_t, 1);
+         node->name = dStrdup(default_keys[i].name);
+         node->cmd = default_keys[i].cmd;
+         node->modifier = default_keys[i].modifier;
+         node->key = default_keys[i].key;
+         dList_insert_sorted(bindings, node, nodeByKeyCmp);
+      }
    }
 }
 
diff -r 2367c730f679 src/keys.hh
--- a/src/keys.hh	Tue Jun 23 21:33:46 2009 +0200
+++ b/src/keys.hh	Wed Jun 24 00:14:17 2009 +0000
@@ -29,6 +29,7 @@ typedef enum {
    KEYS_BOOKMARKS,
    KEYS_FULLSCREEN,
    KEYS_RELOAD,
+   KEYS_STOP,
    KEYS_HIDE_PANELS,
    KEYS_FILE_MENU,
    KEYS_CLOSE_ALL,
diff -r 2367c730f679 src/ui.cc
--- a/src/ui.cc	Tue Jun 23 21:33:46 2009 +0200
+++ b/src/ui.cc	Wed Jun 24 00:14:17 2009 +0000
@@ -789,6 +789,9 @@ int UI::handle(int event)
          ret = 1;
       } else if (cmd == KEYS_RELOAD) {
          a_UIcmd_reload(a_UIcmd_get_bw_by_widget(this));
+         ret = 1;
+      } else if (cmd == KEYS_STOP) {
+         a_UIcmd_stop(a_UIcmd_get_bw_by_widget(this));
          ret = 1;
       } else if (cmd == KEYS_FULLSCREEN) {
          panelmode_cb_i();
From corvid at lavabit.com  Wed Jun 24 07:13:51 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 07:17:02 2009
Subject: [Dillo-dev] patch: viewport keybindings
Message-ID: <20090624051351.GM6014@local.gobigwest.com>

Here is an idea for viewport keybindings.

It just builds a SimpleVector once and lets all of the viewports point to it,
which I think goes against the dillo/dw boundary rules, but we'll see how
the general idea goes over...

-------------- next part --------------
diff -r 3d9d1d3d838e dw/fltkviewport.cc
--- a/dw/fltkviewport.cc	Mon Jun 22 20:27:04 2009 +0000
+++ b/dw/fltkviewport.cc	Wed Jun 24 04:57:17 2009 +0000
@@ -59,6 +59,7 @@ FltkViewport::FltkViewport (int x, int y
    gadgets =
       new container::typed::List <object::TypedPointer < ::fltk::Widget> >
       (true);
+   bindings = NULL;
 }
 
 FltkViewport::~FltkViewport ()
@@ -282,57 +283,55 @@ int FltkViewport::handle (int event)
 
    case ::fltk::KEY:
       /* tell fltk we want to receive these KEY events as SHORTCUT */
-      switch (::fltk::event_key()) {
-      case PageUpKey:
-      case PageDownKey:
-      case SpaceKey:
-      case DownKey:
-      case UpKey:
-      case RightKey:
-      case LeftKey:
-      case HomeKey:
-      case EndKey:
-         return 0;
-      }
-      break;
+      return 0;
 
    case ::fltk::SHORTCUT:
-      switch (::fltk::event_key()) {
-      case PageUpKey:
-      case 'b':
-      case 'B':
-         scroll (0, -vscrollbar->pagesize ());
-         return 1;
-
-      case PageDownKey:
-      case SpaceKey:
-         scroll (0, vscrollbar->pagesize ());
-         return 1;
-
-      case DownKey:
-         scroll (0, (int) vscrollbar->linesize ());
-         return 1;
-
-      case UpKey:
-         scroll (0, (int) -vscrollbar->linesize ());
-         return 1;
-
-      case RightKey:
-         scroll ((int) hscrollbar->linesize (), 0);
-         return 1;
-
-      case LeftKey:
-         scroll ((int) -hscrollbar->linesize (), 0);
-         return 1;
-
-      case HomeKey:
-         scrollTo (scrollX, 0);
-         return 1;
-
-      case EndKey:
-         scrollTo (scrollX, canvasHeight); /* gets adjusted in scrollTo () */
-         return 1;
-      }
+   {  int shortcut = ::fltk::event_key() |
+                     (::fltk::event_state() & (::fltk::SHIFT | ::fltk::CTRL |
+                                               ::fltk::ALT | ::fltk::META));
+      int len = bindings->size();
+
+      for (int i = 0; i < len; i++) {
+         Keybinding *b = bindings->getRef(i);
+
+         if (shortcut == b->shortcut) {
+            
+            switch (b->cmd) {
+            case SCREEN_UP_CMD:
+               scroll (0, -vscrollbar->pagesize ());
+               return 1;
+
+            case SCREEN_DOWN_CMD:
+               scroll (0, vscrollbar->pagesize ());
+               return 1;
+
+            case LINE_DOWN_CMD:
+               scroll (0, (int) vscrollbar->linesize ());
+               return 1;
+
+            case LINE_UP_CMD:
+               scroll (0, (int) -vscrollbar->linesize ());
+               return 1;
+
+            case RIGHT_CMD:
+               scroll ((int) hscrollbar->linesize (), 0);
+               return 1;
+
+            case LEFT_CMD:
+               scroll ((int) -hscrollbar->linesize (), 0);
+               return 1;
+
+            case TOP_CMD:
+               scrollTo (scrollX, 0);
+               return 1;
+
+            case BOTTOM_CMD:
+               scrollTo (scrollX, canvasHeight); /* adjusted in scrollTo () */
+               return 1;
+            }
+         }
+      }
+   }
    }
 
    return FltkWidgetView::handle (event);
diff -r 3d9d1d3d838e dw/fltkviewport.hh
--- a/dw/fltkviewport.hh	Mon Jun 22 20:27:04 2009 +0000
+++ b/dw/fltkviewport.hh	Wed Jun 24 04:57:17 2009 +0000
@@ -15,6 +15,12 @@ class FltkViewport: public FltkWidgetVie
 {
 public:
    enum GadgetOrientation { GADGET_VERTICAL, GADGET_HORIZONTAL };
+   enum KeyCommand {SCREEN_UP_CMD, SCREEN_DOWN_CMD, LINE_UP_CMD,
+                    LINE_DOWN_CMD, LEFT_CMD, RIGHT_CMD, TOP_CMD, BOTTOM_CMD};
+   struct Keybinding {
+      KeyCommand cmd;
+      int shortcut;
+   };
 
 private:
    enum { SCROLLBAR_THICKNESS = 15 };
@@ -24,6 +30,7 @@ private:
    int dragScrolling, dragX, dragY;
 
    ::fltk::Scrollbar *vscrollbar, *hscrollbar;
+   lout::misc::SimpleVector<Keybinding> *bindings;
 
    GadgetOrientation gadgetOrientation[4];
    container::typed::List <object::TypedPointer < ::fltk::Widget> > *gadgets;
@@ -68,6 +75,8 @@ public:
    void setGadgetOrientation (bool hscrollbarVisible, bool vscrollbarVisible,
                               GadgetOrientation gadgetOrientation);
    void addGadget (::fltk::Widget *gadget);
+   inline void setKeybindings(lout::misc::SimpleVector<Keybinding> *bindings)
+                                                  {this->bindings = bindings;};
 };
 
 } // namespace fltk
diff -r 3d9d1d3d838e src/keys.cc
--- a/src/keys.cc	Mon Jun 22 20:27:04 2009 +0000
+++ b/src/keys.cc	Wed Jun 24 04:57:17 2009 +0000
@@ -98,7 +98,17 @@ static const KeyBinding_t default_keys[]
    { "forward"      , KEYS_FORWARD      , fltk::SHIFT  , fltk::BackSpaceKey },
    { "forward"      , KEYS_FORWARD      , 0            , '.'                },
    { "goto"         , KEYS_GOTO         , fltk::CTRL   , 'l'                },
-   { "home"         , KEYS_HOME         , fltk::CTRL   , 'h'                }
+   { "home"         , KEYS_HOME         , fltk::CTRL   , 'h'                },
+   { "screen-up"    , KEYS_SCREEN_UP    , 0            , fltk::PageUpKey    },
+   { "screen-up"    , KEYS_SCREEN_UP    , 0            , 'b'                },
+   { "screen-down"  , KEYS_SCREEN_DOWN  , 0            , fltk::PageDownKey  },
+   { "screen-down"  , KEYS_SCREEN_DOWN  , 0            , fltk::SpaceKey     },
+   { "line-up"      , KEYS_LINE_UP      , 0            , fltk::UpKey        },
+   { "line-down"    , KEYS_LINE_DOWN    , 0            , fltk::DownKey      },
+   { "left"         , KEYS_LEFT         , 0            , fltk::LeftKey      },
+   { "right"        , KEYS_RIGHT        , 0            , fltk::RightKey     },
+   { "top"          , KEYS_TOP          , 0            , fltk::HomeKey      },
+   { "bottom"       , KEYS_BOTTOM       , 0            , fltk::EndKey       },
 };
 
 static Dlist *bindings;
@@ -256,6 +266,26 @@ int Keys::getShortcut(KeysCommand_t cmd)
          return node->modifier + node->key;
    }
    return 0;
+}
+
+/*
+ * Given a keys command, return a list of all shortcuts for it, or NULL
+ * if there are none.
+ */
+Dlist *Keys::getShortcuts(KeysCommand_t cmd)
+{
+   int len = dList_length(bindings);
+   Dlist *ret = NULL;
+
+   for (int i = 0; i < len; i++) {
+      KeyBinding_t *node = (KeyBinding_t*)dList_nth_data(bindings, i);
+      if (cmd == node->cmd) {
+         if (!ret)
+            ret = dList_new(4);
+         dList_append(ret, INT2VOIDP(node->modifier + node->key));
+      }
+   }
+   return ret;
 }
 
 /*
diff -r 3d9d1d3d838e src/keys.hh
--- a/src/keys.hh	Mon Jun 22 20:27:04 2009 +0000
+++ b/src/keys.hh	Wed Jun 24 04:57:17 2009 +0000
@@ -12,6 +12,7 @@
 #ifndef __KEYS_HH__
 #define __KEYS_HH__
 
+#include "../dlib/dlib.h"
 
 typedef enum {
    KEYS_INVALID = -1,
@@ -35,7 +36,15 @@ typedef enum {
    KEYS_BACK,
    KEYS_FORWARD,
    KEYS_GOTO,
-   KEYS_HOME
+   KEYS_HOME,
+   KEYS_SCREEN_UP,
+   KEYS_SCREEN_DOWN,
+   KEYS_LINE_UP,
+   KEYS_LINE_DOWN,
+   KEYS_LEFT,
+   KEYS_RIGHT,
+   KEYS_TOP,
+   KEYS_BOTTOM
 } KeysCommand_t;
 
 class Keys {
@@ -52,6 +61,7 @@ public:
    static void parse(FILE *fp);
    static KeysCommand_t getKeyCmd(void);
    static int getShortcut(KeysCommand_t cmd);
+   static Dlist *getShortcuts(KeysCommand_t cmd);
 };
 
 
diff -r 3d9d1d3d838e src/uicmd.cc
--- a/src/uicmd.cc	Mon Jun 22 20:27:04 2009 +0000
+++ b/src/uicmd.cc	Wed Jun 24 04:57:17 2009 +0000
@@ -34,6 +34,7 @@
 #include "history.h"
 #include "msg.h"
 #include "prefs.h"
+#include "keys.hh"
 
 #include "dw/fltkviewport.hh"
 
@@ -386,12 +387,59 @@ void a_UIcmd_send_event_to_tabs_by_wid(i
 }
 
 /*
+ * Return the key bindings that are relevant to the viewport.
+ */
+static lout::misc::SimpleVector<FltkViewport::Keybinding>
+                                                * UIcmd_get_viewport_bindings()
+{
+   typedef struct {
+      KeysCommand_t keys_cmd;
+      FltkViewport::KeyCommand dw_cmd;
+   } mapping_t;
+
+   const mapping_t map[] = {
+      {KEYS_SCREEN_UP, FltkViewport::SCREEN_UP_CMD},
+      {KEYS_SCREEN_DOWN, FltkViewport::SCREEN_DOWN_CMD},
+      {KEYS_LINE_UP, FltkViewport::LINE_UP_CMD},
+      {KEYS_LINE_DOWN, FltkViewport::LINE_DOWN_CMD},
+      {KEYS_LEFT, FltkViewport::LEFT_CMD},
+      {KEYS_RIGHT, FltkViewport::RIGHT_CMD},
+      {KEYS_TOP, FltkViewport::TOP_CMD},
+      {KEYS_BOTTOM, FltkViewport::BOTTOM_CMD},
+   };
+
+   lout::misc::SimpleVector<FltkViewport::Keybinding> *ret =
+                   new lout::misc::SimpleVector<FltkViewport::Keybinding> (16);
+
+   for (uint_t i = 0; i < (sizeof(map)/sizeof(mapping_t)); i++) {
+      Dlist *shortcuts = Keys::getShortcuts(map[i].keys_cmd);
+
+      if (shortcuts) {
+         FltkViewport::Keybinding binding;
+         int len = dList_length(shortcuts);
+
+         binding.cmd = map[i].dw_cmd;
+         for (int j = 0; j < len; j++) {
+            binding.shortcut = VOIDP2INT(dList_nth_data(shortcuts, j));
+
+            ret->increase();
+            ret->set(ret->size() - 1, binding);
+         }
+         dList_free(shortcuts);
+      }
+   }
+   return ret;
+}
+
+/*
  * Create a new UI and its associated BrowserWindow data structure.
  * Use style from v_ui. If non-NULL it must be of type UI*.
  */
 BrowserWindow *a_UIcmd_browser_window_new(int ww, int wh,
                                           uint32_t xid, const void *vbw)
 {
+   static lout::misc::SimpleVector<FltkViewport::Keybinding> *viewportBindings
+                                                                        = NULL;
    BrowserWindow *old_bw = (BrowserWindow*)vbw;
    BrowserWindow *new_bw = NULL;
    Window *win;
@@ -444,6 +492,9 @@ BrowserWindow *a_UIcmd_browser_window_ne
       viewport->setBufferedDrawing (true);
    else
       viewport->setBufferedDrawing (false);
+   if (!viewportBindings)
+      viewportBindings = UIcmd_get_viewport_bindings();
+   viewport->setKeybindings(viewportBindings);
 
    layout->attachView (viewport);
    new_ui->set_render_layout(*viewport);
From newman.x at gmail.com  Wed Jun 24 11:03:26 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Wed Jun 24 11:04:23 2009
Subject: [Dillo-dev] [PATCH] warning: ignoring
	=?utf-8?q?return_value_of_=E2=80=98int_?=
	=?utf-8?b?Y2hkaXIoY29uc3QgY2hhciop4oCZ?=
Message-ID: <20090624090326.GA2865@assam.Belkin>

gcc-4.4.0-4.i586

HG tip:

newman src $ make | grep -i warning
[...]
paths.cc: In static member function ?static void Paths::init()?:
paths.cc:38: warning: ignoring return value of ?int chdir(const char*)?, declared with attribute warn_unused_result

With the patch dillo-guard-chdir.patch no warning. But this
patch alone won't have any effect, all MSG(...) from 
Paths::init() won't write anything to output due to 
prefs.show_msg not being set to TRUE at that moment. Patch 
dillo-use-MSG-asap.patch moves a_Prefs_init()
before Paths::init() is called. Hope it's not breaking 
anything.

Tested
  - setting non-existing directory instead of /tmp
  - Dillo won't crash on start, basic browsing works
-- 
Regards,
Michal Nowak
-------------- next part --------------
diff -r 95b8ea81632a src/paths.cc
--- a/src/paths.cc	Wed Jun 24 08:16:33 2009 +0200
+++ b/src/paths.cc	Wed Jun 24 10:50:28 2009 +0200
@@ -32,10 +32,15 @@
 {
    char *path;
    struct stat st;
+   int rc = 0;
 
    dFree(oldWorkingDir);
    oldWorkingDir = dGetcwd();
-   chdir("/tmp");
+   rc = chdir("/tmp");
+   if (rc == -1) {
+      MSG("paths: error changing directory to /tmp: %s\n", 
+          dStrerror(errno));
+   }
 
    path = dStrconcat(dGethomedir(), "/.dillo", NULL);
    if (stat(path, &st) == -1) {
-------------- next part --------------
diff -r 95b8ea81632a src/dillo.cc
--- a/src/dillo.cc	Wed Jun 24 08:16:33 2009 +0200
+++ b/src/dillo.cc	Wed Jun 24 10:50:28 2009 +0200
@@ -258,15 +258,15 @@
    }
    dFree(opt_argv);
 
+   // set the default values for the preferences
+   a_Prefs_init();
+
    // create ~/.dillo if not present
    Paths::init();
 
    // initialize default key bindings
    Keys::init();
 
-   // set the default values for the preferences
-   a_Prefs_init();
-
    // parse dillorc
    if ((fp = Paths::getPrefsFP(PATHS_RC_PREFS))) {
       PrefsParser::parse(fp);
From Johannes.Hofmann at gmx.de  Wed Jun 24 14:24:41 2009
From: Johannes.Hofmann at gmx.de (Johannes Hofmann)
Date: Wed Jun 24 14:26:44 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090622171207.18d7c924@ubuntu>
References: <20090622171207.18d7c924@ubuntu>
Message-ID: <20090624122441.GA4368@blob.baaderstrasse.com>

On Mon, Jun 22, 2009 at 05:12:07PM +0300, Tomas R wrote:
> Been testing dillo 2.1 for some time and would like to share my
> experience. 
> 
> It's really great to see some basic css support (appearance of most if
> not all websites has improved alot), properly resized images,
> redirection and basic authentication working now :)
> 
> Anyway, even dillo improved alot recently there still seems to be some
> issues. Here are some I've noticed after testing this release for few
> days:
> Rendering
> 1) ubuntu.lt
> Not sure if it's dillo fault or website's malformed stylesheet, but
> with default dillo settings some of the lithuanian characters are not
> displayed. This can be fixed by just adding "* {font-family:
> serif !important}" to the style.css. Here is a pic with some of the
> places where letters are missing marked in red:
> http://img4.imageshack.us/img4/2227/ubuntult.png
> 2) gmail
> It's nice that login works now, but with default dillo settings the
> size of most of the text is 1px. This can be partially fixed by adding
> font_min_size to dillorc, but it's obviously a dillo bug as this
> doesn't happen with links-hacked.
> 3) google
> What's with the textarea in the top left corner of the page? And just
> for information: signing out doesn't work because it requires basic
> javascript support (works with links-hacked).
> 4) Black on black, white on white...
> http://www.nma-fallout.com/forum/viewtopic.php?t=42776&start=2660&sid=a5712379bdb845ed64a2dfdca10509ea
> For some reason black font color is used here and we get black text on
> black background in some posts (doesn't happen with links-hacked).
> http://www.acetoneteam.org/
> Background color is not set here and if we have "body
> {background-color: white}" rule in our style.css file, we get white
> text on white background.

hg tip now has support for color definitions of the form
rgb(255,255,255).

Please give it a try.

Cheers,
Johannes

From sandshrew at gmail.com  Wed Jun 24 16:24:05 2009
From: sandshrew at gmail.com (Tomas R)
Date: Wed Jun 24 16:25:01 2009
Subject: [Dillo-dev] dillo 2.1
In-Reply-To: <20090624122441.GA4368@blob.baaderstrasse.com>
References: <20090622171207.18d7c924@ubuntu>
	<20090624122441.GA4368@blob.baaderstrasse.com>
Message-ID: <20090624172405.4353fae7@ubuntu>

On Wed, 24 Jun 2009 14:24:41 +0200
Johannes Hofmann <Johannes.Hofmann@gmx.de> wrote:

> hg tip now has support for color definitions of the form
> rgb(255,255,255).
> 
> Please give it a try.
> 

Thanks. It seems to work ok.

I have also tried the patch which makes text wrapping work in textareas
( http://lists.auriga.wearlab.de/pipermail/dillo-dev/2009-April/006267.html ).
The text does wrap but it doesn't automatically scroll down. Maybe the
patch could be committed with some adjustments?

-- 
Brain: an apparatus with which we think we think. - A. Bierce

From corvid at lavabit.com  Wed Jun 24 16:50:17 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 16:53:22 2009
Subject: [Dillo-dev] patch: save bookmark segfault when dpis not found
Message-ID: <20090624145017.GN6014@local.gobigwest.com>

A new one seen in the bugtracker...

a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled.

Anyway, the reason this is interesting is that I had always figured
the URL_*() macros were protecting against a NULL URL, when really
they protect against NULL fields in URLs.

-------------- next part --------------
diff -r 3d9d1d3d838e src/capi.c
--- a/src/capi.c	Mon Jun 22 20:27:04 2009 +0000
+++ b/src/capi.c	Wed Jun 24 14:39:46 2009 +0000
@@ -583,7 +583,7 @@ void a_Capi_ccc(int Op, int Branch, int 
                a_UIcmd_set_msg(conn->bw,
                                "ERROR: can't start dpid daemon "
                                "(URL scheme = '%s')!",
-                               URL_SCHEME(conn->url));
+                               conn->url ? URL_SCHEME(conn->url) : "");
             /* finish conn */
             Capi_conn_unref(conn);
             dFree(Info);
From jcid at dillo.org  Wed Jun 24 17:50:54 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 17:51:10 2009
Subject: [Dillo-dev] patch: save bookmark segfault when dpis not found
In-Reply-To: <20090624145017.GN6014@local.gobigwest.com>
References: <20090624145017.GN6014@local.gobigwest.com>
Message-ID: <20090624155054.GA3858@dillo.org>

On Wed, Jun 24, 2009 at 02:50:17PM +0000, corvid wrote:
> A new one seen in the bugtracker...
> 
> a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled.
> 
> Anyway, the reason this is interesting is that I had always figured
> the URL_*() macros were protecting against a NULL URL, when really
> they protect against NULL fields in URLs.

  Right.

  Please commit (with changelog entry) and update the
bug track entry as "done".

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 24 18:00:44 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 18:01:01 2009
Subject: [Dillo-dev] patch: a binding for stop
In-Reply-To: <20090624002054.GK6014@local.gobigwest.com>
References: <20090506144645.GG6255@local.gobigwest.com>
	<20090506153231.GB6113@dillo.org>
	<20090506154731.GE29980@omphalos.singularity>
	<20090527142256.GH6001@local.gobigwest.com>
	<20090528144057.GA3663@dillo.org>
	<20090529023904.GP6001@local.gobigwest.com>
	<20090529155317.GB5026@dillo.org>
	<20090529193803.GR6001@local.gobigwest.com>
	<20090624002054.GK6014@local.gobigwest.com>
Message-ID: <20090624160044.GB3858@dillo.org>

On Wed, Jun 24, 2009 at 12:20:54AM +0000, corvid wrote:
> How about if we just don't give it any default binding:

  Committed.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 24 18:20:11 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 18:26:22 2009
Subject: [Dillo-dev] [PATCH] warning: ignoring return value of ???int
	chdir(const char*)???
In-Reply-To: <20090624090326.GA2865@assam.Belkin>
References: <20090624090326.GA2865@assam.Belkin>
Message-ID: <20090624162011.GC3858@dillo.org>

On Wed, Jun 24, 2009 at 11:03:26AM +0200, Michal Nowak wrote:
> gcc-4.4.0-4.i586
> 
> HG tip:
> 
> newman src $ make | grep -i warning
> [...]
> paths.cc: In static member function ???static void Paths::init()???:
> paths.cc:38: warning: ignoring return value of ???int chdir(const char*)???, declared with attribute warn_unused_result
> 
> With the patch dillo-guard-chdir.patch no warning. But this
> patch alone won't have any effect, all MSG(...) from 
> Paths::init() won't write anything to output due to 
> prefs.show_msg not being set to TRUE at that moment. Patch 
> dillo-use-MSG-asap.patch moves a_Prefs_init()
> before Paths::init() is called. Hope it's not breaking 
> anything.
> 
> Tested
>   - setting non-existing directory instead of /tmp
>   - Dillo won't crash on start, basic browsing works

  Committed.


  There're also:

    cookies.c:90: warning: ignoring return value of 'write',
    cookies.c:249: warning: ignoring return value of 'fgets',
    dpid.c:754: warning: ignoring return value of 'write'
    bookmarks.c:696: warning: ignoring return value of 'system'
    bookmarks.c:698: warning: ignoring return value of 'system'
    cookies.c:188: warning: ignoring return value of 'write'
    cookies.c:276: warning: ignoring return value of 'fgets'
    cookies.c:341: warning: ignoring return value of 'fgets'
    cookies.c:428: warning: ignoring return value of 'ftruncate'
    cookies.c:1234: warning: ignoring return value of 'fgets'
    datauri.c:283: warning: ignoring return value of 'chdir'
    ftp.c:280: warning: ignoring return value of 'chdir'

  Can you please make a patch for those too?

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 24 19:48:28 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 19:48:55 2009
Subject: [Dillo-dev] patch: viewport keybindings
In-Reply-To: <20090624051351.GM6014@local.gobigwest.com>
References: <20090624051351.GM6014@local.gobigwest.com>
Message-ID: <20090624174828.GD3858@dillo.org>

On Wed, Jun 24, 2009 at 05:13:51AM +0000, corvid wrote:
> Here is an idea for viewport keybindings.
> 
> It just builds a SimpleVector once and lets all of the viewports point to it,
> which I think goes against the dillo/dw boundary rules, but we'll see how
> the general idea goes over...
> 

  Well, that's one way to do it...

  I'm   more   inclined   to  have  an  scrolling  keys  enum  in
fltkviewport.hh,  and  to export another scrollTo() function that
receives  them  as  parameter.  Then we can catch the shortcut in
UI::handle(),  and  map between KEYS_* and the enum in a function
like a_UIcmd_set_scroll_xy().

  That avoids stepping over the dillo/dw boundaries.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Wed Jun 24 20:38:17 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 20:38:45 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090623230507.GJ6014@local.gobigwest.com>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
	<20090623220603.GG11865@dillo.org>
	<20090623230507.GJ6014@local.gobigwest.com>
Message-ID: <20090624183817.GE3858@dillo.org>

On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote:
> Jorge wrote:
> > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> > > 
> > > Accidentally sent to corvid only. Forwarding to dillo-dev.
> > > 
> > > > > > It seems whoever designed the new website theme has no idea what
> > > > > > READABILITY means... It looks like someone just used some stupid online
> > > > > > color picker, which just picks some similar colors to the one user
> > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > > > regression... 
> > > > > 
> > > > > Hm I like the new design, but I agree that readability might be a problem.
> > > > > Let's see what other say.
> > > > 
> > > > I still find visited text to be hard to read, but I know I should
> > > > break down and get a new display...
> > > > 
> > > 
> > > I wonder if you are the only dillo user with old display... BTW, I am using
> > > pretty new LCD display and still find it hard to read.
> > 
> >   OK,  we also had readability concerns but we agreed that it was
> > enough. OTOH some people bashed the old design as prehistoric!
> > 
> >   After all it's a matter of taste.
> >   Usability  is a different thing. Maybe you need higher contrast
> > to  see  clearly  (I  suffer with white backgrounds). Do you find
> > this one better to read [1]?
> > 
> >   What do other people think about the new web design?
> >   Aesthetically and from a readability point of view.
> >   Please comment.
> > 
> > 
> > [1] http://www.dillo.org/test/website/dillo2.2.html
> 
> The test page's visited text is easier for me to read than
> the home page's visited text.

  Funny how it's the reverse effect for me! :-)


  Please test:

    :visited {color:  #403090 !important}

  and

    :visited {color:  #603060 !important}

  on http://www.dillo.org/ and FAQ.

  I prefer the first one because it fits the palette better.



-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Wed Jun 24 20:59:00 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 21:02:00 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090624183817.GE3858@dillo.org>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
	<20090623220603.GG11865@dillo.org>
	<20090623230507.GJ6014@local.gobigwest.com>
	<20090624183817.GE3858@dillo.org>
Message-ID: <20090624185900.GP6014@local.gobigwest.com>

Jorge wrote:
> On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote:
> > Jorge wrote:
> > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> > > > 
> > > > Accidentally sent to corvid only. Forwarding to dillo-dev.
> > > > 
> > > > > > > It seems whoever designed the new website theme has no idea what
> > > > > > > READABILITY means... It looks like someone just used some stupid online
> > > > > > > color picker, which just picks some similar colors to the one user
> > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > > > > regression... 
> > > > > > 
> > > > > > Hm I like the new design, but I agree that readability might be a problem.
> > > > > > Let's see what other say.
> > > > > 
> > > > > I still find visited text to be hard to read, but I know I should
> > > > > break down and get a new display...
> > > > > 
> > > > 
> > > > I wonder if you are the only dillo user with old display... BTW, I am using
> > > > pretty new LCD display and still find it hard to read.
> > > 
> > >   OK,  we also had readability concerns but we agreed that it was
> > > enough. OTOH some people bashed the old design as prehistoric!
> > > 
> > >   After all it's a matter of taste.
> > >   Usability  is a different thing. Maybe you need higher contrast
> > > to  see  clearly  (I  suffer with white backgrounds). Do you find
> > > this one better to read [1]?
> > > 
> > >   What do other people think about the new web design?
> > >   Aesthetically and from a readability point of view.
> > >   Please comment.
> > > 
> > > 
> > > [1] http://www.dillo.org/test/website/dillo2.2.html
> > 
> > The test page's visited text is easier for me to read than
> > the home page's visited text.
> 
>   Funny how it's the reverse effect for me! :-)
> 
> 
>   Please test:
> 
>     :visited {color:  #403090 !important}
> 
>   and
> 
>     :visited {color:  #603060 !important}
> 
>   on http://www.dillo.org/ and FAQ.
> 
>   I prefer the first one because it fits the palette better.

First one is easier.



From jcid at dillo.org  Wed Jun 24 21:06:52 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Wed Jun 24 21:07:08 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090624185900.GP6014@local.gobigwest.com>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
	<20090623220603.GG11865@dillo.org>
	<20090623230507.GJ6014@local.gobigwest.com>
	<20090624183817.GE3858@dillo.org>
	<20090624185900.GP6014@local.gobigwest.com>
Message-ID: <20090624190652.GH3858@dillo.org>

On Wed, Jun 24, 2009 at 06:59:00PM +0000, corvid wrote:
> Jorge wrote:
> > On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote:
> > > Jorge wrote:
> > > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> > > > > 
> > > > > Accidentally sent to corvid only. Forwarding to dillo-dev.
> > > > > 
> > > > > > > > It seems whoever designed the new website theme has no idea what
> > > > > > > > READABILITY means... It looks like someone just used some stupid online
> > > > > > > > color picker, which just picks some similar colors to the one user
> > > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > > > > > regression... 
> > > > > > > 
> > > > > > > Hm I like the new design, but I agree that readability might be a problem.
> > > > > > > Let's see what other say.
> > > > > > 
> > > > > > I still find visited text to be hard to read, but I know I should
> > > > > > break down and get a new display...
> > > > > > 
> > > > > 
> > > > > I wonder if you are the only dillo user with old display... BTW, I am using
> > > > > pretty new LCD display and still find it hard to read.
> > > > 
> > > >   OK,  we also had readability concerns but we agreed that it was
> > > > enough. OTOH some people bashed the old design as prehistoric!
> > > > 
> > > >   After all it's a matter of taste.
> > > >   Usability  is a different thing. Maybe you need higher contrast
> > > > to  see  clearly  (I  suffer with white backgrounds). Do you find
> > > > this one better to read [1]?
> > > > 
> > > >   What do other people think about the new web design?
> > > >   Aesthetically and from a readability point of view.
> > > >   Please comment.
> > > > 
> > > > 
> > > > [1] http://www.dillo.org/test/website/dillo2.2.html
> > > 
> > > The test page's visited text is easier for me to read than
> > > the home page's visited text.
> > 
> >   Funny how it's the reverse effect for me! :-)
> > 
> > 
> >   Please test:
> > 
> >     :visited {color:  #403090 !important}
> > 
> >   and
> > 
> >     :visited {color:  #603060 !important}
> > 
> >   on http://www.dillo.org/ and FAQ.
> > 
> >   I prefer the first one because it fits the palette better.
> 
> First one is easier.

  Is it good enough for you?

-- 
  Cheers
  Jorge.-

From corvid at lavabit.com  Wed Jun 24 22:04:53 2009
From: corvid at lavabit.com (corvid)
Date: Wed Jun 24 22:07:54 2009
Subject: [Dillo-dev] patch: save bookmark segfault when dpis not found
In-Reply-To: <20090624155054.GA3858@dillo.org>
References: <20090624145017.GN6014@local.gobigwest.com>
	<20090624155054.GA3858@dillo.org>
Message-ID: <20090624200453.GR6014@local.gobigwest.com>

Jorge wrote:
> On Wed, Jun 24, 2009 at 02:50:17PM +0000, corvid wrote:
> > A new one seen in the bugtracker...
> > 
> > a_Bookmarks_chat_add() sets URL to NULL, so it needs to be handled.
> > 
> > Anyway, the reason this is interesting is that I had always figured
> > the URL_*() macros were protecting against a NULL URL, when really
> > they protect against NULL fields in URLs.
> 
>   Right.
> 
>   Please commit (with changelog entry) and update the
> bug track entry as "done".

The entry is also partly about the fact that the dpis aren't working
with their deb package. Perhaps something is broken in it with
sysconfdir changing.



From jcid at dillo.org  Wed Jun 24 23:53:23 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 25 00:13:07 2009
Subject: [Dillo-dev] dillo 2.1]
In-Reply-To: <20090624185900.GP6014@local.gobigwest.com>
References: <20090622200112.GB15843@lan-84-240-35-19.skynet.lt>
	<20090623220603.GG11865@dillo.org>
	<20090623230507.GJ6014@local.gobigwest.com>
	<20090624183817.GE3858@dillo.org>
	<20090624185900.GP6014@local.gobigwest.com>
Message-ID: <20090624215323.GI3858@dillo.org>

On Wed, Jun 24, 2009 at 06:59:00PM +0000, corvid wrote:
> Jorge wrote:
> > On Tue, Jun 23, 2009 at 11:05:07PM +0000, corvid wrote:
> > > Jorge wrote:
> > > > On Mon, Jun 22, 2009 at 11:01:12PM +0300, Tomas Rimkus wrote:
> > > > > 
> > > > > Accidentally sent to corvid only. Forwarding to dillo-dev.
> > > > > 
> > > > > > > > It seems whoever designed the new website theme has no idea what
> > > > > > > > READABILITY means... It looks like someone just used some stupid online
> > > > > > > > color picker, which just picks some similar colors to the one user
> > > > > > > > chooses. The old website looked MUCH MUCH better. Imho, it's a
> > > > > > > > regression... 
> > > > > > > 
> > > > > > > Hm I like the new design, but I agree that readability might be a problem.
> > > > > > > Let's see what other say.
> > > > > > 
> > > > > > I still find visited text to be hard to read, but I know I should
> > > > > > break down and get a new display...
> > > > > > 
> > > > > 
> > > > > I wonder if you are the only dillo user with old display... BTW, I am using
> > > > > pretty new LCD display and still find it hard to read.
> > > > 
> > > >   OK,  we also had readability concerns but we agreed that it was
> > > > enough. OTOH some people bashed the old design as prehistoric!
> > > > 
> > > >   After all it's a matter of taste.
> > > >   Usability  is a different thing. Maybe you need higher contrast
> > > > to  see  clearly  (I  suffer with white backgrounds). Do you find
> > > > this one better to read [1]?
> > > > 
> > > >   What do other people think about the new web design?
> > > >   Aesthetically and from a readability point of view.
> > > >   Please comment.
> > > > 
> > > > 
> > > > [1] http://www.dillo.org/test/website/dillo2.2.html
> > > 
> > > The test page's visited text is easier for me to read than
> > > the home page's visited text.
> > 
> >   Funny how it's the reverse effect for me! :-)
> > 
> > 
> >   Please test:
> > 
> >     :visited {color:  #403090 !important}
> > 
> >   and
> > 
> >     :visited {color:  #603060 !important}
> > 
> >   on http://www.dillo.org/ and FAQ.
> > 
> >   I prefer the first one because it fits the palette better.
> 
> First one is easier.

  Committed.

-- 
  Cheers
  Jorge.-

From jcid at dillo.org  Thu Jun 25 00:12:50 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Thu Jun 25 00:13:14 2009
Subject: [Dillo-dev] [marcio.ccamargo@gmail.com: Thank u!]
Message-ID: <20090624221250.GJ3858@dillo.org>

Hi,

  :)

-- 
  Cheers
  Jorge.-
-------------- next part --------------
An embedded message was scrubbed...
From: marcio <marcio.ccamargo@gmail.com>
Subject: Thank u!
Date: Wed, 24 Jun 2009 18:41:39 -0300
Size: 2251
Url: /pipermail/attachments/20090624/49a79f9b/attachment.mht
From newman.x at gmail.com  Thu Jun 25 20:36:45 2009
From: newman.x at gmail.com (Michal Nowak)
Date: Thu Jun 25 19:37:12 2009
Subject: [Dillo-dev] [PATCH] warning: ignoring return value of ???int
	chdir(const char*)???
In-Reply-To: <20090624162011.GC3858@dillo.org>
References: <20090624090326.GA2865@assam.Belkin>
	<20090624162011.GC3858@dillo.org>
Message-ID: <20090625183644.GA2779@assam.lab.eng.brq.redhat.com>

On Wed, Jun 24, 2009 at 12:20:11PM -0400, Jorge Arellano Cid wrote:
> On Wed, Jun 24, 2009 at 11:03:26AM +0200, Michal Nowak wrote:
> > gcc-4.4.0-4.i586
> > 
> > HG tip:
> > 
> > newman src $ make | grep -i warning
> > [...]
> > paths.cc: In static member function ???static void Paths::init()???:
> > paths.cc:38: warning: ignoring return value of ???int chdir(const char*)???, declared with attribute warn_unused_result
> > 
> > With the patch dillo-guard-chdir.patch no warning. But this
> > patch alone won't have any effect, all MSG(...) from 
> > Paths::init() won't write anything to output due to 
> > prefs.show_msg not being set to TRUE at that moment. Patch 
> > dillo-use-MSG-asap.patch moves a_Prefs_init()
> > before Paths::init() is called. Hope it's not breaking 
> > anything.
> > 
> > Tested
> >   - setting non-existing directory instead of /tmp
> >   - Dillo won't crash on start, basic browsing works
> 
>   Committed.
> 
> 
>   There're also:
> 
>     cookies.c:90: warning: ignoring return value of 'write',
>     cookies.c:249: warning: ignoring return value of 'fgets',
>     dpid.c:754: warning: ignoring return value of 'write'
>     bookmarks.c:696: warning: ignoring return value of 'system'
>     bookmarks.c:698: warning: ignoring return value of 'system'
>     cookies.c:188: warning: ignoring return value of 'write'
>     cookies.c:276: warning: ignoring return value of 'fgets'
>     cookies.c:341: warning: ignoring return value of 'fgets'
>     cookies.c:428: warning: ignoring return value of 'ftruncate'
>     cookies.c:1234: warning: ignoring return value of 'fgets'
>     datauri.c:283: warning: ignoring return value of 'chdir'
>     ftp.c:280: warning: ignoring return value of 'chdir'
> 
>   Can you please make a patch for those too?

Attaching the patch.

But few comments first.

cookies.c:
+      rc = fgets(line, LINE_MAXLEN, stream);
+      if (!rc) {
+         MSG("Cookies: Error while reading rule from cookiesrc\n");
+         /* (Partially) corrupted file? Skip this unreadable line */
+         continue;
+      }

The idea was to read all the lines with rules and skip those
unreadable, so we have the rules before and after the unreadable 
part. But - can something like this happen? And will it in reality
perform like I expect in the code?

Another quirk I found is that I always receive one this line
at Dillo start:

  Cookies: Error while reading rule from cookiesrc

I guess there's some problem with EOF handling.

> 
> -- 
>   Cheers
>   Jorge.-
> 

Michal

> _______________________________________________
> Dillo-dev mailing list
> Dillo-dev@dillo.org
> http://lists.auriga.wearlab.de/cgi-bin/mailman/listinfo/dillo-dev

-- 
Regards,
Michal Nowak
-------------- next part --------------
diff -r 97f3d9265b00 ChangeLog
--- a/ChangeLog	Wed Jun 24 12:12:42 2009 -0400
+++ b/ChangeLog	Thu Jun 25 20:00:05 2009 +0200
@@ -12,6 +12,9 @@
    Added the "nop" keybinding (nop = NO_OPERATION; cancels a default hook).
    Patches: place (AKA corvid)
 +- Check chdir() return code in Paths::init.
+ - Reduced 'warning: ignoring return value of ...'
+ - Removed return from a_Nav_unref_buf()
+ - Do not build proto.c (file is empty); GCC warning
    Patch: Michal Nowak
 
 -----------------------------------------------------------------------------
diff -r 97f3d9265b00 dpi/bookmarks.c
--- a/dpi/bookmarks.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/dpi/bookmarks.c	Thu Jun 25 20:00:05 2009 +0200
@@ -687,15 +687,30 @@
       "grep -i \"href\" %s | "
       "sed -e 's/<li><A HREF=\"/s0 /' -e 's/\">/ /' -e 's/<.*$//' >> %s";
    Dstr *dstr = dStr_new("");
+   int rc = 0;
 
 
    if (access(BmFile, F_OK) != 0) {
       OldBmFile = dStrconcat(dGethomedir(), "/.dillo/bookmarks.html", NULL);
       if (access(OldBmFile, F_OK) == 0) {
          dStr_sprintf(dstr, cmd1, BmFile);
-         system(dstr->str);
+         if (dstr->str) {
+            rc = system(dstr->str);
+            if (rc == 127)
+               MSG("Bookmarks: /bin/sh could not be executed\n");
+            else if (rc == -1)
+               MSG("Bookmarks: process creation failure: %s\n", 
+                  dStrerror(errno));
+         }
          dStr_sprintf(dstr, cmd2, OldBmFile, BmFile);
-         system(dstr->str);
+         if (dstr->str) {
+            rc = system(dstr->str);
+            if (rc == 127)
+               MSG("Bookmarks: /bin/sh could not be executed\n");
+            else if (rc == -1)
+               MSG("Bookmarks: process creation failure: %s\n", 
+                  dStrerror(errno));
+         }
          dStr_free(dstr, TRUE);
          dFree(OldBmFile);
       }
diff -r 97f3d9265b00 dpi/cookies.c
--- a/dpi/cookies.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/dpi/cookies.c	Thu Jun 25 20:00:05 2009 +0200
@@ -179,13 +179,19 @@
 {
    FILE *F_in;
    int fd;
+   int rc = 0;
 
    if ((F_in = fopen(filename, mode)) == NULL) {
       /* Create the file */
       fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
       if (fd != -1) {
-         if (init_str)
-            write(fd, init_str, strlen(init_str));
+         if (init_str) {
+            rc = write(fd, init_str, strlen(init_str));
+            if (rc == -1) {
+               MSG("Cookies: Could not write initial string to file %s: %s\n",
+                  filename, dStrerror(errno));
+            }
+         }
          close(fd);
 
          MSG("Created file: %s\n", filename);
@@ -224,6 +230,7 @@
    CookieData_t *cookie;
    char *filename;
    char line[LINE_MAXLEN];
+   void *rc = NULL;
 #ifndef HAVE_LOCKF
    struct flock lck;
 #endif
@@ -273,7 +280,12 @@
    /* Get all lines in the file */
    while (!feof(file_stream)) {
       line[0] = '\0';
-      fgets(line, LINE_MAXLEN, file_stream);
+      rc = fgets(line, LINE_MAXLEN, file_stream);
+      if (!rc) {
+         MSG("Cookies: Error while reading rule from cookiesrc\n");
+         /* (Partially) corrupted file? Skip this unreadable line */
+         continue;
+      }
 
       /* Remove leading and trailing whitespaces */
       dStrstrip(line);
@@ -338,7 +350,12 @@
       /* Get all lines in the file */
       while (!feof(old_cookies_file_stream)) {
          line[0] = '\0';
-         fgets(line, LINE_MAXLEN, old_cookies_file_stream);
+         rc = fgets(line, LINE_MAXLEN, old_cookies_file_stream);
+         if (!rc) {
+            MSG("Cookies: Error while reading rule from cookiesrc\n");
+            /* (Partially) corrupted file? Skip this unreadable line */
+            continue;
+         }
 
          /* Remove leading and trailing whitespaces */
          dStrstrip(line);
@@ -413,6 +430,7 @@
 static void Cookies_save_and_free()
 {
    int i, fd;
+   int rc = 0;
    CookieNode *node;
    CookieData_t *cookie;
 
@@ -425,7 +443,9 @@
 
    rewind(file_stream);
    fd = fileno(file_stream);
-   ftruncate(fd, 0);
+   rc = ftruncate(fd, 0);
+   if (rc == -1)
+      MSG("Cookies: Truncate file stream failed: %s\n", dStrerror(errno));
    fprintf(file_stream, "%s", cookies_txt_header_str);
 
    /* Iterate cookies per domain, saving and freeing */
@@ -1218,6 +1238,7 @@
    char domain[LINE_MAXLEN];
    char rule[LINE_MAXLEN];
    int i, j;
+   void *rc = NULL;
    bool_t enabled = FALSE;
 
    /* Get a file pointer */
@@ -1231,7 +1252,12 @@
    /* Get all lines in the file */
    while (!feof(stream)) {
       line[0] = '\0';
-      fgets(line, LINE_MAXLEN, stream);
+      rc = fgets(line, LINE_MAXLEN, stream);
+      if (!rc) {
+         MSG("Cookies: Error while reading rule from cookiesrc\n");
+         /* (Partially) corrupted file? Skip this unreadable line */
+         continue;
+      }
 
       /* Remove leading and trailing whitespaces */
       dStrstrip(line);
diff -r 97f3d9265b00 dpi/datauri.c
--- a/dpi/datauri.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/dpi/datauri.c	Thu Jun 25 20:00:05 2009 +0200
@@ -275,12 +275,18 @@
 {
    char *dpip_tag = NULL, *cmd = NULL, *url = NULL, *mime_type;
    unsigned char *data;
+   int rc = 0;
    size_t data_size = 0;
 
    /* Initialize the SockHandler */
    sh = sock_handler_new(STDIN_FILENO, STDOUT_FILENO, 8*1024);
 
-   chdir("/tmp");
+   rc = chdir("/tmp");
+   if (rc == -1) {
+      MSG("paths: error changing directory to /tmp: %s\n",
+         dStrerror(errno));
+   }
+
 
    /* Read the dpi command from STDIN */
    dpip_tag = sock_handler_read(sh);
diff -r 97f3d9265b00 dpi/ftp.c
--- a/dpi/ftp.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/dpi/ftp.c	Thu Jun 25 20:00:05 2009 +0200
@@ -267,6 +267,7 @@
 {
    char *dpip_tag = NULL, *cmd = NULL, *url = NULL, *url2 = NULL;
    int nb;
+   int rc = 0;
    char *p, *d_cmd;
 
    /* Debugging with a command line argument */
@@ -277,7 +278,12 @@
    sh = sock_handler_new(STDIN_FILENO, STDOUT_FILENO, 8*1024);
 
    /* wget may need to write a temporary file... */
-   chdir("/tmp");
+   rc = chdir("/tmp");
+   if (rc == -1) {
+      MSG("paths: error changing directory to /tmp: %s\n", 
+          dStrerror(errno));
+   }
+
 
    /* Read the dpi command from STDIN */
    if (!dpip_tag)
diff -r 97f3d9265b00 dpid/dpid.c
--- a/dpid/dpid.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/dpid/dpid.c	Thu Jun 25 20:00:05 2009 +0200
@@ -721,6 +721,7 @@
 {
    static char *DpiBye_cmd = NULL;
    int i, dpi_socket;
+   int rc = 0;
    struct sockaddr_un dpi_addr;
    struct sockaddr_un sa;
    size_t sun_path_len, addr_len;
@@ -751,7 +752,10 @@
          ERRMSG("stop_active_dpis", "connect", errno);
          MSG_ERR("%s\n", dpi_addr.sun_path);
       }
-      (void) write(dpi_socket, DpiBye_cmd, strlen(DpiBye_cmd));
+      rc = write(dpi_socket, DpiBye_cmd, strlen(DpiBye_cmd));
+      if (rc == -1)
+         MSG("stop_active_dpis: Error on sending BYE command: %s\n",
+            dStrerror(errno));
       a_Misc_close_fd(dpi_socket);
    }
 }
diff -r 97f3d9265b00 src/IO/Makefile.am
--- a/src/IO/Makefile.am	Wed Jun 24 12:12:42 2009 -0400
+++ b/src/IO/Makefile.am	Thu Jun 25 20:00:05 2009 +0200
@@ -8,7 +8,6 @@
 	mime.h \
 	about.c \
 	Url.h \
-	proto.c	\
 	http.c \
 	dpi.c \
 	IO.c \
diff -r 97f3d9265b00 src/cookies.c
--- a/src/cookies.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/src/cookies.c	Thu Jun 25 20:00:05 2009 +0200
@@ -35,6 +35,7 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <ctype.h>
+#include <errno.h>
 
 #include "msg.h"
 #include "IO/Url.h"
@@ -80,13 +81,19 @@
 {
    FILE *F_in;
    int fd;
+   int rc = 0;
 
    if ((F_in = fopen(filename, "r")) == NULL) {
       /* Create the file */
       fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC, S_IRUSR | S_IWUSR);
       if (fd != -1) {
-         if (init_str)
-            write(fd, init_str, strlen(init_str));
+         if (init_str) {
+            rc = write(fd, init_str, strlen(init_str));
+            if (rc == -1) {
+               MSG("Cookies: Could not write initial string to file %s: %s\n",
+                  filename, dStrerror(errno));
+            }
+         }
          close(fd);
 
          MSG("Cookies: Created file: %s\n", filename);
@@ -233,6 +240,7 @@
    char rule[LINE_MAXLEN];
    int i, j;
    bool_t enabled = FALSE;
+   void *rc = NULL;
 
    /* Get a file pointer */
    filename = dStrconcat(dGethomedir(), "/.dillo/cookiesrc", NULL);
@@ -245,7 +253,12 @@
    /* Get all lines in the file */
    while (!feof(stream)) {
       line[0] = '\0';
-      fgets(line, LINE_MAXLEN, stream);
+      rc = fgets(line, LINE_MAXLEN, stream);
+      if (!rc) {
+         MSG("Cookies: Error while reading rule from cookiesrc\n");
+         /* (Partially) corrupted file? Skip this unreadable line */
+         continue;
+      }
 
       /* Remove leading and trailing whitespaces */
       dStrstrip(line);
diff -r 97f3d9265b00 src/nav.c
--- a/src/nav.c	Wed Jun 24 12:12:42 2009 -0400
+++ b/src/nav.c	Thu Jun 25 20:00:05 2009 +0200
@@ -597,5 +597,5 @@
  */
 void a_Nav_unref_buf(const DilloUrl *Url)
 {
-   return a_Capi_unref_buf(Url);
+   a_Capi_unref_buf(Url);
 }
From corvid at lavabit.com  Thu Jun 25 21:20:27 2009
From: corvid at lavabit.com (corvid)
Date: Thu Jun 25 21:23:28 2009
Subject: [Dillo-dev] [PATCH] warning: ignoring return value of ???int
	chdir(const char*)???
In-Reply-To: <20090625183644.GA2779@assam.lab.eng.brq.redhat.com>
References: <20090624090326.GA2865@assam.Belkin>
	<20090624162011.GC3858@dillo.org>
	<20090625183644.GA2779@assam.lab.eng.brq.redhat.com>
Message-ID: <20090625192027.GV6014@local.gobigwest.com>

Michal wrote:
> cookies.c:
> +      rc = fgets(line, LINE_MAXLEN, stream);
> +      if (!rc) {
> +         MSG("Cookies: Error while reading rule from cookiesrc\n");
> +         /* (Partially) corrupted file? Skip this unreadable line */
> +         continue;
> +      }
> 
> The idea was to read all the lines with rules and skip those
> unreadable, so we have the rules before and after the unreadable 
> part. But - can something like this happen? And will it in reality
> perform like I expect in the code?
> 
> Another quirk I found is that I always receive one this line
> at Dillo start:
> 
>   Cookies: Error while reading rule from cookiesrc
> 
> I guess there's some problem with EOF handling.

I think I would just loop while the return from fgets() > 0
and then give an error if ferror(stream) is nonzero.



From jcid at dillo.org  Sat Jun 27 04:43:04 2009
From: jcid at dillo.org (Jorge Arellano Cid)
Date: Sat Jun 27 04:43:22 2009
Subject: [Dillo-dev] [PATCH] warning: ignoring return value of ???int
	chdir(const char*)???
In-Reply-To: <20090625192027.GV6014@local.gobigwest.com>
References: <20090624090326.GA2865@assam.Belkin>
	<20090624162011.GC3858@dillo.org>
	<20090625183644.GA2779@assam.lab.eng.brq.redhat.com>
	<20090625192027.GV6014@local.gobigwest.com>
Message-ID: <20090627024304.GJ13779@dillo.org>

On Thu, Jun 25, 2009 at 07:20:27PM +0000, corvid wrote:
> Michal wrote:
> > cookies.c:
> > +      rc = fgets(line, LINE_MAXLEN, stream);
> > +      if (!rc) {
> > +         MSG("Cookies: Error while reading rule from cookiesrc\n");
> > +         /* (Partially) corrupted file? Skip this unreadable line */
> > +         continue;
> > +      }
> > 
> > The idea was to read all the lines with rules and skip those
> > unreadable, so we have the rules before and after the unreadable 
> > part. But - can something like this happen? And will it in reality
> > perform like I expect in the code?
> > 
> > Another quirk I found is that I always receive one this line
> > at Dillo start:
> > 
> >   Cookies: Error while reading rule from cookiesrc
> > 
> > I guess there's some problem with EOF handling.
> 
> I think I would just loop while the return from fgets() > 0
> and then give an error if ferror(stream) is nonzero.

  Committed with modifications.
  Please check it.

-- 
  Cheers
  Jorge.-

From jorl17.8 at gmail.com  Tue Jun 30 23:43:26 2009
From: jorl17.8 at gmail.com (=?ISO-8859-1?Q?Jo=E3o?= Ricardo =?ISO-8859-1?Q?Louren=E7o?=)
Date: Tue Jun 30 23:55:18 2009
Subject: [Dillo-dev] Feels good to be free. Close-tab button.
Message-ID: <1246398206.13209.105.camel@jorl17-laptop>

Well, I promised I would report to you when I got more free time. Guess
what, I'm on vacation! Getting free time from my own personal projects
finally lets me take a closer look at Dillo. I am sorry for being away
for such a long time, though.

I would like to contribute to one area that I have contributed
previously -- the close-tab button. It isn't critical, I know, but, for
now, it's the best I can do. The idea now is to finally have a button in
each tab.

It is tough, but I am getting somewhere. The 'initial' drawing part is
done, but I have had to make some small changes to some virtual
functions, and also changing non-virtual functions and finding a way to
'enable' them in the code.

It's pretty hackish right now, but I have managed to print the button
and am now starting to handle all the events and different button states
(clicked, over, etcetera).

I'll keep you updated!

Jo?o